Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add versioning in the native module NMR structs #3513

Closed
saxena-anurag opened this issue May 1, 2024 · 1 comment
Closed

Add versioning in the native module NMR structs #3513

saxena-anurag opened this issue May 1, 2024 · 1 comment
Assignees
@saxena-anurag
Labels
enhancement New feature or request P2 triaged Discussed in a triage meeting
Milestone
2405

Comments

@saxena-anurag
Copy link
Contributor

No description provided.

@saxena-anurag saxena-anurag mentioned this issue May 1, 2024
Open
@saxena-anurag saxena-anurag self-assigned this May 5, 2024
@saxena-anurag saxena-anurag added this to the 2405 milestone May 5, 2024
@dahavey dahavey added triaged Discussed in a triage meeting enhancement New feature or request P2 labels May 6, 2024
@saxena-anurag
Copy link
Contributor Author

BPF2C embeds version in generated native code, which is same as the eBPF version. That can be used to determine which bpf2c version was used to compile the native module, hence ebpfcore can determine exactly what was the definition of the various structs in that version.

Closing this issue as wont fix.

@saxena-anurag saxena-anurag closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saxena-anurag saxena-anurag

Labels
enhancement New feature or request P2 triaged Discussed in a triage meeting
Projects
None yet
Milestone
2405
Development

No branches or pull requests
2 participants
@dahavey @saxena-anurag