Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add close watcher where supported in place of escape key handlers #6878

Closed
lukewarlow opened this issue Dec 13, 2023 · 1 comment
Closed
Labels
closed:obsolete No longer valid status:triage New Issue - needs triage

Comments

@lukewarlow
Copy link

馃檵 Feature Request

Use the new CloseWatcher API [1][2] (where supported) instead of an escape keydown event listener. This means you can dismiss these components using Android back gestures/button among other close signals.

[1] https://html.spec.whatwg.org/multipage/interaction.html#the-closewatcher-interface
[2] https://developer.chrome.com/blog/new-in-chrome-120#close-watcher

馃 Expected Behavior

Android back gesture should close an open modal dialog along with a few other elements that close with eacape key.

馃槸 Current Behavior

Only escape key closes them.

馃拋 Possible Solution

The close watcher api mentioned above is the perfect candidate

馃敠 Context

馃捇 Examples

https://close-watcher-demo.glitch.me/

@janechu
Copy link
Collaborator

janechu commented May 29, 2024

Unfortunately @microsoft/fast-foundation is being deprecated, refer to #6955. I see this was mentioned in a PR, we will be addressing open PRs and merging what we can before we snap an archive branch to preserve the latest state of Foundation, however to bring us up to date I am closing out issues.

@janechu janechu closed this as completed May 29, 2024
@janechu janechu added the closed:obsolete No longer valid label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:obsolete No longer valid status:triage New Issue - needs triage
Projects
None yet
Development

No branches or pull requests

2 participants