-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update picker item and picker list roles #6884
Comments
This would be just the flyout list and not the "selected items" list? |
I believe any lists and items that are using aria-selected should have their roles updated to |
The selected items list does not currently use "aria-selected" if that's the criteria. |
What is the accessible role for the element itself? |
The Picker itself doesn't have a role explicitly mapped to it. |
|
Note - we could quickly merge a fix which addresses the roles in the flyout menu, which clearly should be "listbox/option" and continue discussing how to handle roles in the selected items list. |
I'm wondering if those roles shouldn't be configurable by authors. Maybe in some scenarios picker is being used to edit something that is contextually a "textbox" and in other cases a "list"? |
Unfortunately |
馃悰 Bug Report
With Picker presenting a list of selectable items selected using
aria-selected
, the roles for the picker list and the options should belistbox
andoption
rather thanlist
andlistitem
respectively.馃捇 Repro or Code Sample
馃 Expected Behavior
The roles for the list and items should use appropriate roles for using aria-selected
馃槸 Current Behavior
The current roles used are
list
andlistitem
which tend to be more appropriate for static lists.馃拋 Possible Solution
The roles that should be used are
listbox
andoption
.馃敠 Context
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-selected
馃實 Your Environment
The text was updated successfully, but these errors were encountered: