Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add title property in web-components/fast-foundation/src/button #6956

Closed
marcoseiza opened this issue May 6, 2024 · 1 comment
Closed
Labels
closed:obsolete No longer valid status:triage New Issue - needs triage

Comments

@marcoseiza
Copy link

馃悰 Bug Report

The web component button implementation doesn't have a title attribute. (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title)

This means that the button doesn't show a tooltip when keyboard focused.

馃捇 Repro or Code Sample

<fast-button title="test"></fast-button>

  • Hover over the element, observe tooltip
  • Keyboard focus the element, observe no tooltip

馃 Expected Behavior

Both hover and keyboard focus should show a tooltip.

馃拋 Possible Solution

Add a title attribute to web-components/fast-foundation/src/button

馃敠 Context

This is an accessibility concern with the button implementation.

@marcoseiza marcoseiza added the status:triage New Issue - needs triage label May 6, 2024
@janechu
Copy link
Collaborator

janechu commented May 29, 2024

Unfortunately @microsoft/fast-foundation is being deprecated, refer to #6955.

@janechu janechu closed this as completed May 29, 2024
@janechu janechu added the closed:obsolete No longer valid label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:obsolete No longer valid status:triage New Issue - needs triage
Projects
None yet
Development

No branches or pull requests

2 participants