Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Code Examples in Control-Documentation no longer scrollable using mouse wheel in Firefox #10865

Closed
alex3683 opened this issue Oct 16, 2019 · 6 comments · Fixed by #10973

Comments

@alex3683
Copy link

Environment Information

  • Browser and OS versions: Firefox 69.0.3 (64-Bit) on Windows 10

Please provide a reproduction of the bug in a codepen:

Actual behavior:

The code does not scroll in Firefox. In Chrome for example, scrolling works.

Expected behavior:

The code is scrollable by mouse wheel in every major browser.

Priorities and help requested:

Are you willing to submit a PR to fix? (Yes, No) No

Requested priority: (Blocking, High, Normal, Low) Normal

Products/sites affected: (if applicable) Every Code Example

@alex3683 alex3683 changed the title Documentation: Code Examples in Control-Documenation no longer scollable using mouse wheel in Firefox Documentation: Code Examples in Control-Documentation no longer scrollable using mouse wheel in Firefox Oct 16, 2019
@marygans
Copy link
Collaborator

marygans commented Oct 16, 2019

Hi @alex3683 thank you for submitting this issue! I was also able to confirm this issue in Firefox.

It looks like this was an existing issue with the monaco editor as there was a recently closed issue here. We will need to bump our monaco version monaco-editor@0.17.1 to0.18.1to get the fix which seems to address the issue adequately for folks.

FYI @ecraig12345 and @kenotron

@ecraig12345
Copy link
Member

At least last I looked at the latest monaco-editor version, bumping it introduced some other issue which would be impossible to work around (unfortunately don't remember what that was...). I'll have to check whether that's still the case. Either way I can deal with this one.

@ecraig12345
Copy link
Member

Looked into this and probably the issue I ran into before was this one (though it's misleadingly named). I submitted a fix (microsoft/monaco-typescript#49) and also found a workaround which will let us upgrade our Monaco version in the meantime.

@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #10973, which has now been successfully released as @uifabric/monaco-editor@v0.4.0.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #10973, which has now been successfully released as @uifabric/tsx-editor@v0.10.3.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #10973, which has now been successfully released as @uifabric/fabric-website-resources@v7.4.0.:tada:

Handy links:

@microsoft microsoft locked as resolved and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants