Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project: Upgrade v8 to React 17 #20507

Closed
TristanWatanabe opened this issue Nov 4, 2021 · 1 comment
Closed

Project: Upgrade v8 to React 17 #20507

TristanWatanabe opened this issue Nov 4, 2021 · 1 comment
Assignees
@TristanWatanabe
Labels
Area: Build System Effort III: Weeks Fluent UI react (v8) Issues about @fluentui/react (v8)
Projects
CXE Redmond - @microsoft/cxe-red
Milestone
November Project ...

Comments

@TristanWatanabe
Copy link
Member

TristanWatanabe commented Nov 4, 2021 •
edited

Problem

Since we’re looking into upgrading our whole repo to React 17, this project specifically focuses on how upgrading to React 17 will affect v8.

Related to: #16886, #17050, #20145

Appetite

Weeks

Solution

Upgrade to react 17 and see what breaks. How tests are handled may need to be changed as well since Enzyme does not officially support react 17 yet, however, there is an unofficial adapter that could be used.

Risks (Rabbit holes)

With build work, it could be anything! Also, the unofficial adapter may not fully work for all tests.

Out of scope (No-gos)

Implementation will be done but may not be merged until upgrading north-star and v9 are ready.
@TristanWatanabe TristanWatanabe self-assigned this Nov 4, 2021
@TristanWatanabe TristanWatanabe added this to To do in CXE Redmond - @microsoft/cxe-red via automation Nov 4, 2021
@khmakoto khmakoto moved this from To do to Projects in CXE Redmond - @microsoft/cxe-red Nov 4, 2021
@ecraig12345
Copy link
Member

Should we close this and I can make a new one now that I'm working on this instead?

@ecraig12345 ecraig12345 mentioned this issue Feb 9, 2022
Closed
12 tasks
@microsoft microsoft locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TristanWatanabe TristanWatanabe

Labels
Area: Build System Effort III: Weeks Fluent UI react (v8) Issues about @fluentui/react (v8)
Projects
No open projects
CXE Redmond - @microsoft/cxe-red
Projects
Milestone
November Project Cycle Q4 2021
Development

No branches or pull requests
2 participants
@ecraig12345 @TristanWatanabe