diff --git a/.vscode/tasks.json b/.vscode/tasks.json index ca45419df32c0..91711c7b9c048 100644 --- a/.vscode/tasks.json +++ b/.vscode/tasks.json @@ -5,13 +5,7 @@ "label": "Typescript (oufr) watch", "type": "process", "command": "node", - "args": [ - "./scripts/node_modules/typescript/bin/tsc", - "-p", - "packages/office-ui-fabric-react/tsconfig.json", - "-w", - "--noEmit" - ], + "args": ["./scripts/node_modules/typescript/bin/tsc", "-p", "packages/office-ui-fabric-react/tsconfig.json", "-w", "--noEmit"], "problemMatcher": "$tsc", "group": { "kind": "build", @@ -22,13 +16,7 @@ "label": "Typescript (vr-tests) watch", "type": "process", "command": "node", - "args": [ - "./scripts/node_modules/typescript/bin/tsc", - "-p", - "apps/vr-tests/tsconfig.json", - "-w", - "--noEmit" - ], + "args": ["./scripts/node_modules/typescript/bin/tsc", "-p", "apps/vr-tests/tsconfig.json", "-w", "--noEmit"], "problemMatcher": "$tsc", "group": { "kind": "build", @@ -39,18 +27,23 @@ "label": "Typescript (experiments) watch", "type": "process", "command": "node", - "args": [ - "./scripts/node_modules/typescript/bin/tsc", - "-p", - "packages/experiments/tsconfig.json", - "-w", - "--noEmit" - ], + "args": ["./scripts/node_modules/typescript/bin/tsc", "-p", "packages/experiments/tsconfig.json", "-w", "--noEmit"], "problemMatcher": "$tsc", "group": { "kind": "build", "isDefault": true } }, + { + "label": "Typescript (example-app-base) watch", + "type": "process", + "command": "node", + "args": ["./scripts/node_modules/typescript/bin/tsc", "-p", "packages/example-app-base/tsconfig.json", "-w", "--noEmit"], + "problemMatcher": "$tsc", + "group": { + "kind": "build", + "isDefault": true + } + } ] -} \ No newline at end of file +} diff --git a/apps/fabric-website/src/pages/Controls/AvatarPage/AvatarPage.tsx b/apps/fabric-website/src/pages/Controls/AvatarPage/AvatarPage.tsx index 1825bc5285258..03bf1e75d5a0f 100644 --- a/apps/fabric-website/src/pages/Controls/AvatarPage/AvatarPage.tsx +++ b/apps/fabric-website/src/pages/Controls/AvatarPage/AvatarPage.tsx @@ -8,7 +8,14 @@ const baseUrl = 'https://github.com/OfficeDev/office-ui-fabric-react/tree/master export const AvatarPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ( + + ); }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Controls/ButtonPage/ButtonPage.tsx b/apps/fabric-website/src/pages/Controls/ButtonPage/ButtonPage.tsx index 8ae3b1f80e5a0..49f6bb53fed3d 100644 --- a/apps/fabric-website/src/pages/Controls/ButtonPage/ButtonPage.tsx +++ b/apps/fabric-website/src/pages/Controls/ButtonPage/ButtonPage.tsx @@ -53,7 +53,7 @@ export class ButtonPage extends React.Component< title="Button" {...buttonPageProps[this.props.platform]} exampleKnobs={this.renderKnobs()} - otherSections={this._otherSections(this.props.platform)} + otherSections={this._otherSections(this.props.platform) as IPageSectionProps[]} /> ); } diff --git a/apps/fabric-website/src/pages/Controls/CalendarPage/CalendarPage.tsx b/apps/fabric-website/src/pages/Controls/CalendarPage/CalendarPage.tsx index af1aec11c8532..94f8fdb4ecc7c 100644 --- a/apps/fabric-website/src/pages/Controls/CalendarPage/CalendarPage.tsx +++ b/apps/fabric-website/src/pages/Controls/CalendarPage/CalendarPage.tsx @@ -8,7 +8,14 @@ const baseUrl = 'https://github.com/OfficeDev/office-ui-fabric-react/tree/master export const CalendarPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ( + + ); }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Controls/ChipPage/ChipPage.tsx b/apps/fabric-website/src/pages/Controls/ChipPage/ChipPage.tsx index 9a9d17ec78817..1eded5faa8fd3 100644 --- a/apps/fabric-website/src/pages/Controls/ChipPage/ChipPage.tsx +++ b/apps/fabric-website/src/pages/Controls/ChipPage/ChipPage.tsx @@ -8,7 +8,7 @@ const baseUrl = 'https://github.com/OfficeDev/office-ui-fabric-react/tree/master export const ChipPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ; }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Controls/DatePickerPage/DatePickerPage.tsx b/apps/fabric-website/src/pages/Controls/DatePickerPage/DatePickerPage.tsx index aa07093f88ca9..3d9655f9073bd 100644 --- a/apps/fabric-website/src/pages/Controls/DatePickerPage/DatePickerPage.tsx +++ b/apps/fabric-website/src/pages/Controls/DatePickerPage/DatePickerPage.tsx @@ -8,7 +8,7 @@ const baseUrl = 'https://github.com/OfficeDev/office-ui-fabric-react/tree/master export const DatePickerPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ; }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Controls/DrawerPage/DrawerPage.tsx b/apps/fabric-website/src/pages/Controls/DrawerPage/DrawerPage.tsx index a7f42962cd892..4cf32c9de11a8 100644 --- a/apps/fabric-website/src/pages/Controls/DrawerPage/DrawerPage.tsx +++ b/apps/fabric-website/src/pages/Controls/DrawerPage/DrawerPage.tsx @@ -8,7 +8,7 @@ const baseUrl = 'https://github.com/OfficeDev/office-ui-fabric-react/tree/master export const DrawerPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ; }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Controls/ListCellsPage/ListCellsPage.tsx b/apps/fabric-website/src/pages/Controls/ListCellsPage/ListCellsPage.tsx index 14d44c8570e19..40d3406b8977b 100644 --- a/apps/fabric-website/src/pages/Controls/ListCellsPage/ListCellsPage.tsx +++ b/apps/fabric-website/src/pages/Controls/ListCellsPage/ListCellsPage.tsx @@ -8,7 +8,7 @@ const baseUrl = 'https://github.com/OfficeDev/office-ui-fabric-react/tree/master export const ListCellsPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ; }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Controls/PeoplePickerPage/PeoplePickerPage.tsx b/apps/fabric-website/src/pages/Controls/PeoplePickerPage/PeoplePickerPage.tsx index 6db9afec6db76..8b5873ad5afa7 100644 --- a/apps/fabric-website/src/pages/Controls/PeoplePickerPage/PeoplePickerPage.tsx +++ b/apps/fabric-website/src/pages/Controls/PeoplePickerPage/PeoplePickerPage.tsx @@ -9,7 +9,12 @@ const baseUrl = 'https://github.com/OfficeDev/office-ui-fabric-react/tree/master export const PeoplePickerPage: React.StatelessComponent = props => { const { platform } = props; return ( - + ); }; diff --git a/apps/fabric-website/src/pages/Controls/PersonaPage/PersonaPage.tsx b/apps/fabric-website/src/pages/Controls/PersonaPage/PersonaPage.tsx index 96420e9f8847f..31763431c3d5f 100644 --- a/apps/fabric-website/src/pages/Controls/PersonaPage/PersonaPage.tsx +++ b/apps/fabric-website/src/pages/Controls/PersonaPage/PersonaPage.tsx @@ -8,7 +8,14 @@ const baseUrl = 'https://github.com/OfficeDev/office-ui-fabric-react/tree/master export const PersonaPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ( + + ); }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Controls/PivotPage/PivotPage.tsx b/apps/fabric-website/src/pages/Controls/PivotPage/PivotPage.tsx index bd4ae490221bd..30e304b08f793 100644 --- a/apps/fabric-website/src/pages/Controls/PivotPage/PivotPage.tsx +++ b/apps/fabric-website/src/pages/Controls/PivotPage/PivotPage.tsx @@ -7,7 +7,13 @@ import { Platforms } from '../../../interfaces/Platforms'; const baseUrl = 'https://github.com/OfficeDev/office-ui-fabric-react/tree/master/apps/fabric-website/src/pages/Controls/PivotPage/'; export const PivotPage: React.StatelessComponent = props => { - return ; + return ( + + ); }; function _otherSections(platform?: Platforms): IPageSectionProps[] | undefined { diff --git a/apps/fabric-website/src/pages/Controls/PopupMenuPage/PopupMenuPage.tsx b/apps/fabric-website/src/pages/Controls/PopupMenuPage/PopupMenuPage.tsx index 630b423019f37..91a53b3c89213 100644 --- a/apps/fabric-website/src/pages/Controls/PopupMenuPage/PopupMenuPage.tsx +++ b/apps/fabric-website/src/pages/Controls/PopupMenuPage/PopupMenuPage.tsx @@ -8,7 +8,7 @@ const baseUrl = 'https://github.com/OfficeDev/office-ui-fabric-react/tree/master export const PopupMenuPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ; }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Controls/SnackbarPage/SnackbarPage.tsx b/apps/fabric-website/src/pages/Controls/SnackbarPage/SnackbarPage.tsx index 9e2e370f66c27..81d92976d0e8c 100644 --- a/apps/fabric-website/src/pages/Controls/SnackbarPage/SnackbarPage.tsx +++ b/apps/fabric-website/src/pages/Controls/SnackbarPage/SnackbarPage.tsx @@ -8,7 +8,7 @@ const baseUrl = 'https://github.com/OfficeDev/office-ui-fabric-react/tree/master export const SnackbarPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ; }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Controls/SpinnerPage/SpinnerPage.tsx b/apps/fabric-website/src/pages/Controls/SpinnerPage/SpinnerPage.tsx index ba504641febc7..b19ee5e6f1ae6 100644 --- a/apps/fabric-website/src/pages/Controls/SpinnerPage/SpinnerPage.tsx +++ b/apps/fabric-website/src/pages/Controls/SpinnerPage/SpinnerPage.tsx @@ -6,7 +6,14 @@ import { IPageSectionProps } from '@uifabric/example-app-base/lib/index2'; export const SpinnerPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ( + + ); }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Controls/TooltipPage/TooltipPage.tsx b/apps/fabric-website/src/pages/Controls/TooltipPage/TooltipPage.tsx index da217fa311847..02caac01eff97 100644 --- a/apps/fabric-website/src/pages/Controls/TooltipPage/TooltipPage.tsx +++ b/apps/fabric-website/src/pages/Controls/TooltipPage/TooltipPage.tsx @@ -7,7 +7,13 @@ import { Platforms } from '../../../interfaces/Platforms'; const baseUrl = 'https://github.com/OfficeDev/office-ui-fabric-react/tree/master/apps/fabric-website/src/pages/Controls/TooltipPage/'; export const TooltipPage: React.StatelessComponent = props => { - return ; + return ( + + ); }; function _otherSections(platform?: Platforms): IPageSectionProps[] | undefined { diff --git a/apps/fabric-website/src/pages/Overviews/ControlsPage/ControlsPage.tsx b/apps/fabric-website/src/pages/Overviews/ControlsPage/ControlsPage.tsx index d329f06ead848..b34af3fa784bd 100644 --- a/apps/fabric-website/src/pages/Overviews/ControlsPage/ControlsPage.tsx +++ b/apps/fabric-website/src/pages/Overviews/ControlsPage/ControlsPage.tsx @@ -15,7 +15,7 @@ const ControlsPageBase: React.StatelessComponent> = props title="Controls" platform={platform} subTitle={getSubTitle(platform)} - otherSections={_otherSections(platform)} + otherSections={_otherSections(platform) as IPageSectionProps[]} showSideRail={false} {...ControlsPageProps[platform]} /> diff --git a/apps/fabric-website/src/pages/Overviews/GetStartedPage/GetStartedPage.tsx b/apps/fabric-website/src/pages/Overviews/GetStartedPage/GetStartedPage.tsx index 850ac21a8c060..33b38decc6f90 100644 --- a/apps/fabric-website/src/pages/Overviews/GetStartedPage/GetStartedPage.tsx +++ b/apps/fabric-website/src/pages/Overviews/GetStartedPage/GetStartedPage.tsx @@ -18,7 +18,7 @@ const GetStartedPageBase: React.StatelessComponent = props subTitle={getSubTitle(platform)} {...props} {...GetStartedPageProps[platform]} - otherSections={_otherSections(platform)} + otherSections={_otherSections(platform) as IPageSectionProps[]} /> ); }; diff --git a/apps/fabric-website/src/pages/Overviews/StylesPage/StylesPage.tsx b/apps/fabric-website/src/pages/Overviews/StylesPage/StylesPage.tsx index ba21627fab04a..e4d507a6856ee 100644 --- a/apps/fabric-website/src/pages/Overviews/StylesPage/StylesPage.tsx +++ b/apps/fabric-website/src/pages/Overviews/StylesPage/StylesPage.tsx @@ -12,7 +12,7 @@ const StylesPageBase: React.StatelessComponent> = props => title="Styles" platform={platform} subTitle={getSubTitle(platform)} - otherSections={_otherSections(platform)} + otherSections={_otherSections(platform) as IPageSectionProps[]} showSideRail={false} sectionWrapperClassName={styles.cardWrapper} /> diff --git a/apps/fabric-website/src/pages/PageTemplates/TemplatePage/TemplatePage.tsx b/apps/fabric-website/src/pages/PageTemplates/TemplatePage/TemplatePage.tsx index 5e36376fa80ae..886fcd4158de9 100644 --- a/apps/fabric-website/src/pages/PageTemplates/TemplatePage/TemplatePage.tsx +++ b/apps/fabric-website/src/pages/PageTemplates/TemplatePage/TemplatePage.tsx @@ -31,7 +31,7 @@ const TemplatePageBase: React.StatelessComponent = props => // Use the getSubTitle helper function to get the page header subtitle from the active platform. subTitle={getSubTitle(platform)} // You can define custom sections using the `otherSections` prop. Here it is using a method that takes the platform as an argument to return the correct array of section props. - otherSections={_otherSections(platform)} + otherSections={_otherSections(platform) as IPageSectionProps[]} // You can hide the side rail by setting `showSideRail` to false. // showSideRail={false} diff --git a/apps/fabric-website/src/pages/Styles/Colors/MessagingPage.tsx b/apps/fabric-website/src/pages/Styles/Colors/MessagingPage.tsx index 2df5c7a06ed66..8543926eea871 100644 --- a/apps/fabric-website/src/pages/Styles/Colors/MessagingPage.tsx +++ b/apps/fabric-website/src/pages/Styles/Colors/MessagingPage.tsx @@ -8,7 +8,9 @@ const baseUrl = 'https://github.com/OfficeDev/office-ui-fabric-react/tree/master export const ColorsMessagingPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ( + + ); }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Styles/Colors/NeutralsPage.tsx b/apps/fabric-website/src/pages/Styles/Colors/NeutralsPage.tsx index cce23e7fdfbe0..9537bf2d653d0 100644 --- a/apps/fabric-website/src/pages/Styles/Colors/NeutralsPage.tsx +++ b/apps/fabric-website/src/pages/Styles/Colors/NeutralsPage.tsx @@ -9,7 +9,9 @@ const neutralColors = require('@uifabric/fabric-website/lib/data export const ColorsNeutralsPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ( + + ); }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Styles/Colors/PersonasPage.tsx b/apps/fabric-website/src/pages/Styles/Colors/PersonasPage.tsx index 2a5197b25440c..9c3fb267bf5c4 100644 --- a/apps/fabric-website/src/pages/Styles/Colors/PersonasPage.tsx +++ b/apps/fabric-website/src/pages/Styles/Colors/PersonasPage.tsx @@ -10,7 +10,9 @@ const personaGroupColors = require('@uifabric/fabric-website/lib export const ColorsPersonasPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ( + + ); }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Styles/Colors/PresencePage.tsx b/apps/fabric-website/src/pages/Styles/Colors/PresencePage.tsx index c96730ab53709..37e04fbf4216d 100644 --- a/apps/fabric-website/src/pages/Styles/Colors/PresencePage.tsx +++ b/apps/fabric-website/src/pages/Styles/Colors/PresencePage.tsx @@ -8,7 +8,9 @@ const baseUrl = 'https://github.com/OfficeDev/office-ui-fabric-react/tree/master export const ColorsPresencePage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ( + + ); }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Styles/Colors/SharedPage.tsx b/apps/fabric-website/src/pages/Styles/Colors/SharedPage.tsx index fa4117c1a277c..807633d3a0721 100644 --- a/apps/fabric-website/src/pages/Styles/Colors/SharedPage.tsx +++ b/apps/fabric-website/src/pages/Styles/Colors/SharedPage.tsx @@ -9,7 +9,7 @@ const sharedColors = require('@uifabric/fabric-website/lib/data/ export const ColorsSharedPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ; }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Styles/ElevationPage/ElevationPage.tsx b/apps/fabric-website/src/pages/Styles/ElevationPage/ElevationPage.tsx index a1aecbd578a03..c6c751c4ce477 100644 --- a/apps/fabric-website/src/pages/Styles/ElevationPage/ElevationPage.tsx +++ b/apps/fabric-website/src/pages/Styles/ElevationPage/ElevationPage.tsx @@ -10,7 +10,7 @@ const baseUrl = 'https://github.com/OfficeDev/office-ui-fabric-react/tree/master export const ElevationPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ; }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Styles/FabricIconsPage/FabricIconsPage.tsx b/apps/fabric-website/src/pages/Styles/FabricIconsPage/FabricIconsPage.tsx index 7d7b1a0c07f62..87fc981d501e4 100644 --- a/apps/fabric-website/src/pages/Styles/FabricIconsPage/FabricIconsPage.tsx +++ b/apps/fabric-website/src/pages/Styles/FabricIconsPage/FabricIconsPage.tsx @@ -13,7 +13,7 @@ const enDash = '–'; export const FabricIconsPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ; }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Styles/LayoutPage/LayoutPage.tsx b/apps/fabric-website/src/pages/Styles/LayoutPage/LayoutPage.tsx index f7a726a0022c8..f3faa2b993760 100644 --- a/apps/fabric-website/src/pages/Styles/LayoutPage/LayoutPage.tsx +++ b/apps/fabric-website/src/pages/Styles/LayoutPage/LayoutPage.tsx @@ -11,7 +11,7 @@ const breakpointsData = require('../../../data/responsive-breakpoints.json'); export const LayoutPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ; }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Styles/LocalizationPage/LocalizationPage.tsx b/apps/fabric-website/src/pages/Styles/LocalizationPage/LocalizationPage.tsx index 053765dd357a1..ee2a4bc941b41 100644 --- a/apps/fabric-website/src/pages/Styles/LocalizationPage/LocalizationPage.tsx +++ b/apps/fabric-website/src/pages/Styles/LocalizationPage/LocalizationPage.tsx @@ -14,7 +14,7 @@ const localizedFontsData = require('../../../data/localized-fonts.json'); export const LocalizationPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ; }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Styles/MotionPage/MotionPage.tsx b/apps/fabric-website/src/pages/Styles/MotionPage/MotionPage.tsx index 233404e33a71e..ff21b8d12b1a9 100644 --- a/apps/fabric-website/src/pages/Styles/MotionPage/MotionPage.tsx +++ b/apps/fabric-website/src/pages/Styles/MotionPage/MotionPage.tsx @@ -47,7 +47,7 @@ const PatternTable = ({ rows }) => ( export const MotionPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ; }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Styles/OfficeBrandIconsPage/OfficeBrandIconsPage.tsx b/apps/fabric-website/src/pages/Styles/OfficeBrandIconsPage/OfficeBrandIconsPage.tsx index f2e37ecc57e9f..f845db92dedf8 100644 --- a/apps/fabric-website/src/pages/Styles/OfficeBrandIconsPage/OfficeBrandIconsPage.tsx +++ b/apps/fabric-website/src/pages/Styles/OfficeBrandIconsPage/OfficeBrandIconsPage.tsx @@ -18,7 +18,9 @@ const monochromeIcons = require('@uifabric/fabric-website/lib/data/brand-icons-m export const OfficeBrandIconsPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ( + + ); }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/fabric-website/src/pages/Styles/TypographyPage/TypographyPage.tsx b/apps/fabric-website/src/pages/Styles/TypographyPage/TypographyPage.tsx index 309c5f31a742c..6f16438d9be21 100644 --- a/apps/fabric-website/src/pages/Styles/TypographyPage/TypographyPage.tsx +++ b/apps/fabric-website/src/pages/Styles/TypographyPage/TypographyPage.tsx @@ -13,7 +13,7 @@ const baseUrl = 'https://github.com/OfficeDev/office-ui-fabric-react/tree/master export const TypographyPage: React.StatelessComponent = props => { const { platform } = props; - return ; + return ; }; function _otherSections(platform: Platforms): IPageSectionProps[] { diff --git a/apps/theming-designer/package.json b/apps/theming-designer/package.json index 5035f698cd634..9c1cb29438d1b 100644 --- a/apps/theming-designer/package.json +++ b/apps/theming-designer/package.json @@ -32,7 +32,7 @@ "office-ui-fabric-react": ">=6.187.1 <7.0.0", "react": ">=16.8.0 <17.0.0", "react-dom": ">=16.8.0 <17.0.0", - "typescript": "3.3.3", + "typescript": "3.5.1", "tslib": "^1.7.1" } } diff --git a/apps/todo-app/package.json b/apps/todo-app/package.json index 83b12f03b7a79..d19959d0aa91d 100644 --- a/apps/todo-app/package.json +++ b/apps/todo-app/package.json @@ -27,7 +27,7 @@ "office-ui-fabric-react": "^6.187.1", "react": ">=16.8.0 <17.0.0", "react-dom": ">=16.8.0 <17.0.0", - "typescript": "3.3.3", + "typescript": "3.5.1", "tslib": "^1.7.1" } } diff --git a/apps/vr-tests/package.json b/apps/vr-tests/package.json index 1fec3b939a62f..1056eb6e9daa3 100644 --- a/apps/vr-tests/package.json +++ b/apps/vr-tests/package.json @@ -47,6 +47,6 @@ "react": ">=16.8.0 <17.0.0", "react-dom": ">=16.8.0 <17.0.0", "tslib": "^1.7.1", - "typescript": "3.3.3" + "typescript": "3.5.1" } } diff --git a/apps/vr-tests/src/stories/Checkbox.stories.tsx b/apps/vr-tests/src/stories/Checkbox.stories.tsx index 928efd8a0e101..a1b787bb32c03 100644 --- a/apps/vr-tests/src/stories/Checkbox.stories.tsx +++ b/apps/vr-tests/src/stories/Checkbox.stories.tsx @@ -29,7 +29,6 @@ storiesOf('Checkbox', module) // tslint:disable-next-line:max-line-length label="Dignissim vehicula pretium. Mauris sapien lorem. Ipsum metus tristique. Aliquam mauris ac purus id nunc. Erat aenean ut commodo integer litora amet rutrum mus maecenas quisque lectus eget fames massa. Pede proin metus sollicitudin donec purus. Sem at tempus morbi metus sit. Quam odio porta. Cras nulla sed. Aliquam mauris auctor. Adipiscing magna rutrum est sed porttitor. Duis rhoncus convallis. Nunc qui amet. Quo eros ac. Nec laboris pharetra erat nec hymenaeos phasellus urna neque rerum ut ac. In natoque morbi. Risus wisi maecenas eros magna pellentesque inceptos mi nec mattis lacus tortor volutpat lorem vivamus. Magna amet nam non in non. Semper sagittis purus et tincidunt justo. Magna fusce enim amet nulla neque. A vestibulum risus wisi temporibus consectetuer. Non sociis sed risus sagittis condimentum. Erat vel interdum quas libero erat elementum massa duis elementum malesuada lacinia. Scelerisque vivamus elit. Bibendum libero adipiscing. Curae quis lacus. At metus vestibulum. Diam natoque nullam posuere vestibulum aliquam suscipit quis posuere sed penatibus sit sed sapien eros con sodales hymenaeos. Nulla vestibulum ut. Aenean curabitur diam lorem commodo malesuada dui nascetur pulvinar." defaultChecked={true} - onChange={this._onCheckboxChange} /> )) .addStory('Custom render Checkbox', () => ( diff --git a/apps/vr-tests/src/stories/DetailsHeader.stories.tsx b/apps/vr-tests/src/stories/DetailsHeader.stories.tsx index 727921983bbf8..e26bab98a0a3c 100644 --- a/apps/vr-tests/src/stories/DetailsHeader.stories.tsx +++ b/apps/vr-tests/src/stories/DetailsHeader.stories.tsx @@ -110,8 +110,7 @@ _selection.setItems(_items); const _columnReorderProps = { frozenColumnCountFromStart: 1, - frozenColumnCountFromEnd: 1, - handleColumnReorder: this._dummyFunction + frozenColumnCountFromEnd: 1 }; storiesOf('DetailsHeader', module) diff --git a/common/config/rush/shrinkwrap.yaml b/common/config/rush/shrinkwrap.yaml index 09e0520af7e2b..afd1ce47a9d5c 100644 --- a/common/config/rush/shrinkwrap.yaml +++ b/common/config/rush/shrinkwrap.yaml @@ -179,7 +179,7 @@ dependencies: tslint-microsoft-contrib: 5.2.1 tslint-react: 3.6.0 ttest: 2.0.0 - typescript: 3.3.3 + typescript: 3.5.1 webpack: 4.29.5 webpack-bundle-analyzer: 3.3.2 webpack-cli: 3.2.3 @@ -6561,7 +6561,7 @@ packages: webpack: ^2.3.0 || ^3.0.0 || ^4.0.0 resolution: integrity: sha512-qNYuygh2GxXehBvQZ5rI5YlQFn+7ZV6kmkyD9Sgs33dWl73NZdUOB5aCp8v0EXJn176AhPrZP8YCMT3h01fs+g== - /fork-ts-checker-webpack-plugin/0.4.15/78ce9b782feca4d461107d32ff2f3536: + /fork-ts-checker-webpack-plugin/0.4.15/41adb244b4ff6610d6d6f34fa678a3bd: dependencies: babel-code-frame: 6.26.0 chalk: 2.4.2 @@ -6571,8 +6571,8 @@ packages: minimatch: 3.0.4 resolve: 1.10.1 tapable: 1.1.3 - tslint: /tslint/5.16.0/typescript@3.3.3 - typescript: 3.3.3 + tslint: /tslint/5.16.0/typescript@3.5.1 + typescript: 3.5.1 webpack: 4.29.5 dev: false engines: @@ -12985,10 +12985,10 @@ packages: typescript: '>=2.4.0' resolution: integrity: sha512-xOnjt8kyXOKCCzKtfp6yQRG4wbAF5VCIZMslY+W3KGhVwPQ2rTcYbvEFRIIginuSj6PvhXzwVcz+llO4ANk4Jw== - /riceburn/1.3.0/typescript@3.3.3: + /riceburn/1.3.0/typescript@3.5.1: dependencies: glob: 7.1.4 - typescript: 3.3.3 + typescript: 3.5.1 dev: false id: registry.npmjs.org/riceburn/1.3.0 peerDependencies: @@ -14593,11 +14593,11 @@ packages: typescript: ^2.1.0 || ^3.0.0 resolution: integrity: sha512-PDYjvpo0gN9IfMULwKk0KpVOPMhU6cNoT9VwCOLeDl/QS8v8W2yspRpFFuUS7/c5EIH/n8ApMi8TxJAz1tfFUA== - /tslint-microsoft-contrib/5.2.1/tslint@5.16.0+typescript@3.3.3: + /tslint-microsoft-contrib/5.2.1/tslint@5.16.0+typescript@3.5.1: dependencies: - tslint: /tslint/5.16.0/typescript@3.3.3 - tsutils: /tsutils/2.28.0/typescript@3.3.3 - typescript: 3.3.3 + tslint: /tslint/5.16.0/typescript@3.5.1 + tsutils: /tsutils/2.28.0/typescript@3.5.1 + typescript: 3.5.1 dev: false id: registry.npmjs.org/tslint-microsoft-contrib/5.2.1 peerDependencies: @@ -14637,7 +14637,7 @@ packages: typescript: '>=2.1.0 || >=2.1.0-dev || >=2.2.0-dev || >=2.3.0-dev || >=2.4.0-dev || >=2.5.0-dev || >=2.6.0-dev || >=2.7.0-dev || >=2.8.0-dev || >=2.9.0-dev || >=3.0.0-dev || >= 3.1.0-dev || >= 3.2.0-dev' resolution: integrity: sha512-UxG2yNxJ5pgGwmMzPMYh/CCnCnh0HfPgtlVRDs1ykZklufFBL1ZoTlWFRz2NQjcoEiDoRp+JyT0lhBbbH/obyA== - /tslint/5.16.0/typescript@3.3.3: + /tslint/5.16.0/typescript@3.5.1: dependencies: '@babel/code-frame': 7.0.0 builtin-modules: 1.1.1 @@ -14651,8 +14651,8 @@ packages: resolve: 1.10.1 semver: 5.7.0 tslib: 1.9.3 - tsutils: /tsutils/2.29.0/typescript@3.3.3 - typescript: 3.3.3 + tsutils: /tsutils/2.29.0/typescript@3.5.1 + typescript: 3.5.1 dev: false engines: node: '>=4.8.0' @@ -14670,10 +14670,10 @@ packages: typescript: '>=2.1.0 || >=2.1.0-dev || >=2.2.0-dev || >=2.3.0-dev || >=2.4.0-dev || >=2.5.0-dev || >=2.6.0-dev || >=2.7.0-dev || >=2.8.0-dev || >=2.9.0-dev || >= 3.0.0-dev || >= 3.1.0-dev' resolution: integrity: sha512-bh5nAtW0tuhvOJnx1GLRn5ScraRLICGyJV5wJhtRWOLsxW70Kk5tZtpK3O/hW6LDnqKS9mlUMPZj9fEMJ0gxqA== - /tsutils/2.28.0/typescript@3.3.3: + /tsutils/2.28.0/typescript@3.5.1: dependencies: tslib: 1.9.3 - typescript: 3.3.3 + typescript: 3.5.1 dev: false id: registry.npmjs.org/tsutils/2.28.0 peerDependencies: @@ -14688,10 +14688,10 @@ packages: typescript: '>=2.1.0 || >=2.1.0-dev || >=2.2.0-dev || >=2.3.0-dev || >=2.4.0-dev || >=2.5.0-dev || >=2.6.0-dev || >=2.7.0-dev || >=2.8.0-dev || >=2.9.0-dev || >= 3.0.0-dev || >= 3.1.0-dev' resolution: integrity: sha512-g5JVHCIJwzfISaXpXE1qvNalca5Jwob6FjI4AoPlqMusJ6ftFE7IkkFoMhVLRgK+4Kx3gkzb8UZK5t5yTTvEmA== - /tsutils/2.29.0/typescript@3.3.3: + /tsutils/2.29.0/typescript@3.5.1: dependencies: tslib: 1.9.3 - typescript: 3.3.3 + typescript: 3.5.1 dev: false id: registry.npmjs.org/tsutils/2.29.0 peerDependencies: @@ -14760,6 +14760,13 @@ packages: hasBin: true resolution: integrity: sha512-Y21Xqe54TBVp+VDSNbuDYdGw0BpoR/Q6wo/+35M8PAU0vipahnyduJWirxxdxjsAkS7hue53x2zp8gz7F05u0A== + /typescript/3.5.1: + dev: false + engines: + node: '>=4.2.0' + hasBin: true + resolution: + integrity: sha512-64HkdiRv1yYZsSe4xC1WVgamNigVYjlssIoaH2HcZF0+ijsk5YK2g0G34w9wJkze8+5ow4STd22AynfO6ZYYLw== /typical/2.6.1: dev: false resolution: @@ -15845,7 +15852,7 @@ packages: dev: false name: '@rush-temp/a11y-tests' resolution: - integrity: sha512-/f/SIjbdft5fspOtZn6Asb8AT+nAv6PHIsN98Dz324z1t2JRzGQvrp/kDEelvmZbUXt0eSdBp6BP04cuTe0MgA== + integrity: sha512-73AnUyM8yvhU6eth8QmamOnXAD9mdkn2jWKxnxRgFDEhKl2aJxr000+PH+tDM/R3xpTaNgoNKvHtjR0LAjMQrg== tarball: 'file:projects/a11y-tests.tgz' version: 0.0.0 'file:projects/api-docs.tgz': @@ -15858,7 +15865,7 @@ packages: dev: false name: '@rush-temp/api-docs' resolution: - integrity: sha512-tQiiD/ljtHUsF5DVqwJv9d92CGG6JaO+JdlBNC8VUH39XVFpzDy88DqIUPcFu34vxBtaAijN5bm7jfa4tNJDJA== + integrity: sha512-QnUZX/xUSB/0RRVpJNgyjKZItP3kjsSTqcO25Bj0KpTR72H1ju6ybZtAIC73u29vryiPRsfsa0pkZexLKAuAZg== tarball: 'file:projects/api-docs.tgz' version: 0.0.0 'file:projects/azure-themes.tgz': @@ -15868,7 +15875,7 @@ packages: dev: false name: '@rush-temp/azure-themes' resolution: - integrity: sha512-Th/r0x0UkCR74+CRdMhQP0fIQZy0+h2EO1+YpmVV6U7nats+WP2s79qtGNg9KELxlwJNQj2ZMU3VBC1Jbije4g== + integrity: sha512-ewQrxlui0dxQ6XT+gkX2wV16xlGOjlBWeAISiHhqzeEh4ZpN6GFq/2ZTe7OjOLSAN+2ullkRDEIGw0lQWinDww== tarball: 'file:projects/azure-themes.tgz' version: 0.0.0 'file:projects/build.tgz': @@ -15886,7 +15893,7 @@ packages: cpx: 1.5.0 css-loader: 0.28.11 find-free-port: 2.0.0 - fork-ts-checker-webpack-plugin: /fork-ts-checker-webpack-plugin/0.4.15/78ce9b782feca4d461107d32ff2f3536 + fork-ts-checker-webpack-plugin: /fork-ts-checker-webpack-plugin/0.4.15/41adb244b4ff6610d6d6f34fa678a3bd fs-extra: 7.0.1 github: 7.3.2 glob: 7.1.3 @@ -15919,10 +15926,10 @@ packages: style-loader: 0.21.0 ts-jest: /ts-jest/24.0.1/jest@24.1.0 ts-loader: 4.5.0 - tslint: /tslint/5.16.0/typescript@3.3.3 - tslint-microsoft-contrib: /tslint-microsoft-contrib/5.2.1/tslint@5.16.0+typescript@3.3.3 + tslint: /tslint/5.16.0/typescript@3.5.1 + tslint-microsoft-contrib: /tslint-microsoft-contrib/5.2.1/tslint@5.16.0+typescript@3.5.1 ttest: 2.0.0 - typescript: 3.3.3 + typescript: 3.5.1 webpack: 4.29.5 webpack-bundle-analyzer: 3.3.2 webpack-cli: /webpack-cli/3.2.3/webpack@4.29.5 @@ -15932,7 +15939,7 @@ packages: dev: false name: '@rush-temp/build' resolution: - integrity: sha512-HOvDC5PyfU6UzlSug2Mw2PV5RPNErE4XgZ7UZ3vDKSvwVsKRwB6a/O09DEtwxj8L42fPKhIk8dSBQk9i/Mjj2w== + integrity: sha512-0+KyOEdI7c7TNiD5zEBSXzlFkJg9Y4fgTIQRs8tRiQAlG81avtbdeYlKirdDTsI/fpp6YFtD7diXE3QCBsXR4A== tarball: 'file:projects/build.tgz' version: 0.0.0 'file:projects/charting.tgz': @@ -15975,7 +15982,7 @@ packages: dev: false name: '@rush-temp/charting' resolution: - integrity: sha512-QBoN5XQ7vOHtGhNv7sy4RIVgbqAk5RS9nHySgJGh8H7S5rZI6seTMRaiMQOADmoWO160LXXfiIgka12nGZSPQQ== + integrity: sha512-Xr7tXHDR4s3DHKv85lPL8R/7kXITIVyc4w+yncCU/cANMdUkDf7WqYskbi0611ZmFIWfmBme/JXlxPrKT5vK5Q== tarball: 'file:projects/charting.tgz' version: 0.0.0 'file:projects/codepen-loader.tgz': @@ -15997,7 +16004,7 @@ packages: dev: false name: '@rush-temp/codepen-loader' resolution: - integrity: sha512-gTqTmfUq/S0p45Xk2XxLSDhBU0IVwvntl3Ep2vRo6fEQNOswuQgR+VO0Af/RYUYUDv7yvyYFxxB9h5HqI0iUsA== + integrity: sha512-RAZKV0LDuJs9arXoqfLrGtR4rIJbHJhInsOY4oaWVhqGE+S3cBb2i1bXPSO/QHG29SbJsQvwF0f0nLa9sI0p3w== tarball: 'file:projects/codepen-loader.tgz' version: 0.0.0 'file:projects/date-time.tgz': @@ -16022,7 +16029,7 @@ packages: dev: false name: '@rush-temp/date-time' resolution: - integrity: sha512-3ozUNOgQ0PQBtEuG/8y493vjchsBrEYazDZyRp1VzWhfMemnw5degxX57XJPZjBkRZKNl7AlpRHEWackhvEEJQ== + integrity: sha512-hXXaS+ZWpXNyybM1LI62uOb2IRux7TPi1Y23Y7NpopUvXMvEx/LuK1Mq+OaJXMqBd8oywVXlx2/tC/DgleE8FQ== tarball: 'file:projects/date-time.tgz' version: 0.0.0 'file:projects/dom-tests.tgz': @@ -16047,7 +16054,7 @@ packages: dev: false name: '@rush-temp/dom-tests' resolution: - integrity: sha512-tqryCujzlCoKcjf+3A9sM2ZhysMHgqjvVNxKnnuUQlVJz7EW221XcyHGrjVpt3UA9CN+ANYq6gmeErB/Bh7ChA== + integrity: sha512-X9+kznqXhV0FFk9cMRAUjR/sm2Z6XPvYv21M2G4nsLZgxhfEDyI920FbOC8KA1MdplFyt14VT9qij9y5yQD4sw== tarball: 'file:projects/dom-tests.tgz' version: 0.0.0 'file:projects/example-app-base.tgz': @@ -16078,7 +16085,7 @@ packages: dev: false name: '@rush-temp/example-app-base' resolution: - integrity: sha512-6295Q16rJV777HqJ1loltH8YfTkBsw7iMN6N2FoJyp9f7VJgClBq3UWBxnoMZiNw308HK5uQLO32iOS4x+390w== + integrity: sha512-cGOLpUPFfWH7XBR/w84p5h1p1/VFz/RyKpoeXDEENm7Z4Xxnvb8jQoyk66ytHo72Cl6qDvtXbas7ttMoUV2pZw== tarball: 'file:projects/example-app-base.tgz' version: 0.0.0 'file:projects/experiments.tgz': @@ -16112,7 +16119,7 @@ packages: dev: false name: '@rush-temp/experiments' resolution: - integrity: sha512-b3FmJWZCZYV23pTPsDewY8JzqTtwMZOoHHUwu8HstrXlMVBwSlF+uzrRcIiUeqAgSzwJZ4nkXA2groC4cYSZ3Q== + integrity: sha512-4jsezxaDHiLsfDodkbLrdhWCoFZE9sJ1j1Bkc2CTNrWNLrwetZfiRMb6tMnTzdI3Qhv0j/QOQx1psuDnI7Xikg== tarball: 'file:projects/experiments.tgz' version: 0.0.0 'file:projects/fabric-website-resources.tgz': @@ -16154,7 +16161,7 @@ packages: dev: false name: '@rush-temp/fabric-website-resources' resolution: - integrity: sha512-rh1W5qCdUFFRiZl6pFjkBWEtbT3O0bWVkbGI4NvMGZEE969iSnGbPD1nFsqW4377E2/Tbj32PWRBVsXG6GD4LA== + integrity: sha512-cdJarQueFJJsUEd1woulRqQ6jVzCQps6UujJ8u3XkFHKAtasjI2M7kGbWTpY6O/r6X+aN+EYVUaHGTnHLnw/Xw== tarball: 'file:projects/fabric-website-resources.tgz' version: 0.0.0 'file:projects/fabric-website.tgz': @@ -16182,7 +16189,7 @@ packages: dev: false name: '@rush-temp/fabric-website' resolution: - integrity: sha512-6S9EppCh53cSJkogCklofSpzHL3j4/JCFD2tCq2M2JheREWK4hTXpv3+glnUjmP8UeXnbgeBrSgrGRko8rrtAQ== + integrity: sha512-KNZUfeULkHtbRdBOX0YAlEdnU9RuCPdXNqC4BUdJeIQlnO4ly+21vwSy9ZGi1rtde9hyXctnLkBhn7E9ejLr6A== tarball: 'file:projects/fabric-website.tgz' version: 0.0.0 'file:projects/file-type-icons.tgz': @@ -16196,7 +16203,7 @@ packages: dev: false name: '@rush-temp/file-type-icons' resolution: - integrity: sha512-oZ9QpTAR7AbZ8x3n83heJ0AErewl1huzWkfDyC/7Az7RdtfZBczV+VOF8IlDeep0AqQEMb75BT6uJ1fPpRG6fw== + integrity: sha512-pIGAtGr/MITOGtswQkxVVevMe5jcpv0z2uhErsZ2of/LA/hTg+zia00jed+hmQ0VxPMlcsbqucVHPG8CVtAJzA== tarball: 'file:projects/file-type-icons.tgz' version: 0.0.0 'file:projects/fluent-theme.tgz': @@ -16206,7 +16213,7 @@ packages: dev: false name: '@rush-temp/fluent-theme' resolution: - integrity: sha512-BXAC9YFo9yu3qX0Fa7tRnGgNXoCErN7nyRWOPZejrq3F6x6/BKu0fNgyUkc655QQrTEhZUC9QT4X7XyWCKyP+Q== + integrity: sha512-KBcen1Y4pnOyM5F4m2152AGw3Ywb6kmiiGkAQygfhNzcZBHyvErbUS3IT8/lxfGeEq3o5qLfflEiTXYeYV9Cog== tarball: 'file:projects/fluent-theme.tgz' version: 0.0.0 'file:projects/foundation-scenarios.tgz': @@ -16230,7 +16237,7 @@ packages: dev: false name: '@rush-temp/foundation-scenarios' resolution: - integrity: sha512-AO1lZXIgapjwSAHFw1dwFsfsE/KiGspAi8poVEuKZgbPUeAzg+7hvDeWxmBK4d413XdgZzQGHfuv+5HmD0QMYw== + integrity: sha512-R0mDuPazbU2UOx0Ax2IxErGarbCkdcOXETD/7nF7PwOm8pk6mkiJ/W1GJ7g6blQkljjkNebt+FjcTmXCE2moHg== tarball: 'file:projects/foundation-scenarios.tgz' version: 0.0.0 'file:projects/foundation.tgz': @@ -16253,7 +16260,7 @@ packages: dev: false name: '@rush-temp/foundation' resolution: - integrity: sha512-V+/EAFbxCbwUJyXl3OHidWSHaIiMj9pWkssPuA28+WlfXs9kxD23M7mZATEx9h6C8weV5TFTgs+bb1TnbSfqNg== + integrity: sha512-wwjf4wb50d7TZzSP4wKvbzUcT49TqfT6RF5p4adBetCu8ER9K3q/YOjwPweg8V+eNZrDMYkRcBqtYRvu4xfHvw== tarball: 'file:projects/foundation.tgz' version: 0.0.0 'file:projects/icons.tgz': @@ -16262,7 +16269,7 @@ packages: dev: false name: '@rush-temp/icons' resolution: - integrity: sha512-foxTlOAF1IITQcW03HnlGXbdwIlNLDfROvF++z31uWu5XXcIW490MZqLYRcl+kn8ZEK9M60vffiDG/BRq0r1OA== + integrity: sha512-HzDzBtBeNTCsWfx3dozZ7+V+S0JjZPKEdYpQ4rJDPnOuBlZAF5Z6SOuxBBwQznhAReeAq3CvGhpWg2+U35PaVQ== tarball: 'file:projects/icons.tgz' version: 0.0.0 'file:projects/jest-serializer-merge-styles.tgz': @@ -16277,7 +16284,7 @@ packages: dev: false name: '@rush-temp/jest-serializer-merge-styles' resolution: - integrity: sha512-Yv8ogSGs0IcFUgQJdBtlUtktX0LJT7YhoccrptLzggtJoJrlFhqcHsv8VNEtnqI3vBpULWumRKDnmto2lkQ1yw== + integrity: sha512-xJdHdj/CW7NH7oIvugVSIoclo3NbgysSY+MevvnR9Hr2KwZ0uocmeyGgWE9ZS6Exzy1BqTEkfH8NUHQkp4ceYg== tarball: 'file:projects/jest-serializer-merge-styles.tgz' version: 0.0.0 'file:projects/lists.tgz': @@ -16301,7 +16308,7 @@ packages: dev: false name: '@rush-temp/lists' resolution: - integrity: sha512-79Jl9n/zAxyN3QtvI58OdbDi6x9pC6GK+RIlMMS1JVIkQEF0ZLNLctELnkfKGEPYrvnM3A/ofTgu+pYtfBzoxA== + integrity: sha512-/t9xx0OCZYN8+4ez8updPn4ZkLE0gwkM3XIs2zizm+foWzxXrr4MS5sgcU842Kw4hjGeq/mfW2NiBOcsQmbzWQ== tarball: 'file:projects/lists.tgz' version: 0.0.0 'file:projects/merge-styles.tgz': @@ -16311,7 +16318,7 @@ packages: dev: false name: '@rush-temp/merge-styles' resolution: - integrity: sha512-P7xNNzgmD4xQX+5VBAs04lOgkoNcEtzuctCbHAmfKHTRsSrQjCl/48E9Wk3Cp3XLJFzNVSszNaY+YgCQqvzjtQ== + integrity: sha512-Xh5Pt3EUltlbrnf2Klnmss4IAwHxqLdePrcRFDe0guX0AIlilpy4DhRePxwZkQBqjnnUkNl3NOHxP/jZ4RDE9Q== tarball: 'file:projects/merge-styles.tgz' version: 0.0.0 'file:projects/migration.tgz': @@ -16323,14 +16330,14 @@ packages: '@types/semver': 5.5.0 glob: 7.1.3 mock-fs: 4.10.0 - riceburn: /riceburn/1.3.0/typescript@3.3.3 + riceburn: /riceburn/1.3.0/typescript@3.5.1 semver: 5.7.0 tslib: 1.9.3 - typescript: 3.3.3 + typescript: 3.5.1 dev: false name: '@rush-temp/migration' resolution: - integrity: sha512-WwgDhBbdD/VeiqXLaXFJySDTRpZqRm9iKyAslFfhRpTITr/e2cfKuoEiibUR8A3/9BN9bMHrhzAuVXC48jVbeA== + integrity: sha512-t+vTdvgSeeUDIsoHIEx4DbwW1oKu0fJ10upZ2IETkdsmdo4TQZp9RdQyQDqA/bYr0TwXko7xqXyStt8egE24Ow== tarball: 'file:projects/migration.tgz' version: 0.0.0 'file:projects/office-ui-fabric-react.tgz': @@ -16370,7 +16377,7 @@ packages: dev: false name: '@rush-temp/office-ui-fabric-react' resolution: - integrity: sha512-OQ6S0ucOWzrI+u08YbbpfiU3qf/39+EZ3w9yNFY4I9qy6fLkdnSMYu+9My/EOxI88OawYwWKZOo4CnZwV66niA== + integrity: sha512-hbWWhIbcSP24BV9czbH2ykaC7hUdF2OE1FAkUZ2R+9x4mUWWEg2+W7dNoVVG7aqInD6nQcalmj+0B9L9xMymFw== tarball: 'file:projects/office-ui-fabric-react.tgz' version: 0.0.0 'file:projects/perf-test.tgz': @@ -16388,21 +16395,21 @@ packages: dev: false name: '@rush-temp/perf-test' resolution: - integrity: sha512-QZDwdSZT1VqzQJ7O8clQOE9jDnjmTnl0MY6/q9yLhvxzksFQTL3qTxlfdK7x0zD5zE3598jZsLZjT0wKuhfX1w== + integrity: sha512-i/crTZhDH51mrs0Dk3ekdiVTpULubBCYxxj+4JgJHkBcvUqFAyFVH3MTgRBhbo7gsIhieoWCQwMKrWWkW6EHQQ== tarball: 'file:projects/perf-test.tgz' version: 0.0.0 'file:projects/pr-deploy-site.tgz': dev: false name: '@rush-temp/pr-deploy-site' resolution: - integrity: sha512-3fiulU/9KpV0TOkegQAfUZYnlH7pxzmwfccrjmzsjQgduIuabnbaAYZNC/o+4syAIbiCGCKzjbvuXf4+7A3XYw== + integrity: sha512-qLCVNCh0LiGT4MHBJabMRlgDKO/h0OBhftrLU62LN8UGET5WJ4aInzt21GbyUzAekYR7MyG1S0Kglot/rLNFVg== tarball: 'file:projects/pr-deploy-site.tgz' version: 0.0.0 'file:projects/prettier-rules.tgz': dev: false name: '@rush-temp/prettier-rules' resolution: - integrity: sha512-7r4uNiMS8+omI76CKiVw7nJn2G0vs6Cd+CEAmTGmXDRT/FaMbDSIlsOpg+jzuO/fzg/zDB5GT7kwYff1IQWMiw== + integrity: sha512-jWWVmeywKZJiB8xv4ZdJ77AkTUoIgzr9ZNB2lGWp57zq/NqAGn6JVhkrf8Kp4GUPUyszGKn2NIVPx510n1eT7Q== tarball: 'file:projects/prettier-rules.tgz' version: 0.0.0 'file:projects/react-cards.tgz': @@ -16427,7 +16434,7 @@ packages: dev: false name: '@rush-temp/react-cards' resolution: - integrity: sha512-QzABo5rX79vlMHwXXRUJMf5eQ5yB+IV2sL7C+YmHvNzHK0PYnwtZjSGysGJmyGmjAes+9bZ+MoAdeBInenUpog== + integrity: sha512-SEgZThbKPrEBwB0dwLhkEFcqH+dHGA1B62hwHVnUhyEP5SkoOCxAxDynAZbFBwuXmvrAgsSdBV4hhSLRINiQpA== tarball: 'file:projects/react-cards.tgz' version: 0.0.0 'file:projects/server-rendered-app.tgz': @@ -16446,7 +16453,7 @@ packages: dev: false name: '@rush-temp/server-rendered-app' resolution: - integrity: sha512-DxWheryMGJ5naKlKiqFfUzzORnVG4RY2rrbmgkdZjSfmFPHUjsRJw1kMVRPp/pWk0fcGHe9rv+UiBaNbzNFLRw== + integrity: sha512-c8gvZ1oNbUUriY7GqNT5fbG+WPK+nqcbsqwDloJpBSe4u1ZuFWFLpH3zF/vOvF2qJlkH32xGfYbXYPl/CEu3Uw== tarball: 'file:projects/server-rendered-app.tgz' version: 0.0.0 'file:projects/set-version.tgz': @@ -16456,7 +16463,7 @@ packages: dev: false name: '@rush-temp/set-version' resolution: - integrity: sha512-E0H3UsbpteNSFjexchy9m6XTl5/OqiKztbDwYk6GQV8qLB966an3IaPBvHsLWNrCkD1xKKYNU6s1Xhgs/RKzqw== + integrity: sha512-T4evegLu3m93/qgYO6yC8odBzT8Zdx8DjVLnUbdZ9AhHrHGdIZMWSCivLkBalkBa9Covl6DR6gnvVS9hjvokCg== tarball: 'file:projects/set-version.tgz' version: 0.0.0 'file:projects/ssr-tests.tgz': @@ -16475,7 +16482,7 @@ packages: dev: false name: '@rush-temp/ssr-tests' resolution: - integrity: sha512-k7pGNF3vfTe/gstwPMJCa48mlJUguQLu9SUMdg58EeFN6+ka/VR8iD2GYPhVC6D6lDBrPLIlMNjclmCR/rQXSg== + integrity: sha512-UQgJOJfMSAsBvDZgtyDgEYmlsRsQZcZQQdFVXY6yxocpLXah5cYY6+JkBq9zfFQdZwXs3Zti5EKHINe0QVaZHw== tarball: 'file:projects/ssr-tests.tgz' version: 0.0.0 'file:projects/styling.tgz': @@ -16492,7 +16499,7 @@ packages: dev: false name: '@rush-temp/styling' resolution: - integrity: sha512-r2qFR6v9mb5SQrDf06WrbXrped1gjwBTSXuzUJxkUCVHbEXbTVIbvsrMPE/CbvnGW4NjzOXXs0miYKhXPCjkCw== + integrity: sha512-xBvLH2PnpiPgy6tKD3iO4+brOvPYdw2lXHuF1Htl9KzXUqQKr39dentNoy/zE4CR/7VIdgOVRZcbf6GdmC58/Q== tarball: 'file:projects/styling.tgz' version: 0.0.0 'file:projects/test-bundles.tgz': @@ -16506,7 +16513,7 @@ packages: dev: false name: '@rush-temp/test-bundles' resolution: - integrity: sha512-15AWsECsR479nB4ZR2R5dp62S798gRfiMUetcdKSINhPvHR0BWgaUUbDhS+Wi0lGtsryPbb0RjpTPbY+TmrH3A== + integrity: sha512-qJLPb0yog55o2/Ek3YPHwqAkZqirPvSxPLfKUeZ5VcxwivYenChNztSEQLomXYxHxr7VKjdfkmyqMBQlfdc9vA== tarball: 'file:projects/test-bundles.tgz' version: 0.0.0 'file:projects/test-utilities.tgz': @@ -16528,7 +16535,7 @@ packages: dev: false name: '@rush-temp/test-utilities' resolution: - integrity: sha512-PGpqHuXxPo2fMIogk+BCSel6my9G2T3rYecK/6bDtwLv03n7fH5c+4/y9kmxONdP8MJzfP1jUQ1bEuKcGp5ogA== + integrity: sha512-09dJKCg+er+8cnLqGBBaqAdn1aFclLjsFyfM8IeczwMSScJ7hWGjzPhSnEUVI0jqVJtxvu1xJV6eXDRqVxoQfA== tarball: 'file:projects/test-utilities.tgz' version: 0.0.0 'file:projects/theme-samples.tgz': @@ -16538,7 +16545,7 @@ packages: dev: false name: '@rush-temp/theme-samples' resolution: - integrity: sha512-ZT+wouXvhn0wf1BkoQYD14UUvlBluyP/5Hf/quKllIQpi6aD/krcUGLGPzQXDMlQEdhfTYSg/mYC52r3LnKQSA== + integrity: sha512-iCCX2hGBC6IQeya41OuZJJndiOkYs/pkR7xKdlWU2UCmtGnpeyUP9X/CEJvaXn5mdI4nwOT3CD4Ar3p4fBLZIw== tarball: 'file:projects/theme-samples.tgz' version: 0.0.0 'file:projects/theming-designer.tgz': @@ -16554,11 +16561,11 @@ packages: react: 16.8.6 react-dom: /react-dom/16.8.6/react@16.8.6 tslib: 1.9.3 - typescript: 3.3.3 + typescript: 3.5.1 dev: false name: '@rush-temp/theming-designer' resolution: - integrity: sha512-7OO5f/OCe44yq6ZRoXgRa+2Y+17Z7KHeHiaZ/l4wz+95YgiO1h0xSrA+oa9LhvWxC9GQ5VIHZiQkjS5yAfJxOA== + integrity: sha512-yDRFgSZ1L/uqiO97NF1AzHwntnyyW72l7GVLSfD/AbOSMoYlCjbDDbNEgC3jGX8ucVp+GN8B8pnre7+prcz4rQ== tarball: 'file:projects/theming-designer.tgz' version: 0.0.0 'file:projects/todo-app.tgz': @@ -16573,11 +16580,11 @@ packages: react: 16.8.6 react-dom: /react-dom/16.8.6/react@16.8.6 tslib: 1.9.3 - typescript: 3.3.3 + typescript: 3.5.1 dev: false name: '@rush-temp/todo-app' resolution: - integrity: sha512-v8sAPlrMhPi0wG2zB0cYpA2aJ7XEjMjOfdStQfmalRo5xzDBb8940Q7vbATdyH7K000PtglE74IhJ2r6gayT8w== + integrity: sha512-wV0MT2cw2aX/VENgZmuSszl0EfGiaqY52KIQhNwjmfscQPcRc7Ffz7evOJxpJf2ub/uZPLrWVpuPdlykqe6lag== tarball: 'file:projects/todo-app.tgz' version: 0.0.0 'file:projects/tslint-rules.tgz': @@ -16586,7 +16593,7 @@ packages: dev: false name: '@rush-temp/tslint-rules' resolution: - integrity: sha512-8wuVU4w1Bpvf5I7a7X1ya/Zs+YNi1TSkdRkop+RX+2sXVi/hCAjrYQ6RU2TQc28Qe/GotjxSWszya1kkjKkz0Q== + integrity: sha512-sJZbDeOptA/9QAmZZ3a6+4v9HYsKFgmDIOZOF8LLfYxAvzSlbLnvsrOZzxKjwPpqEuRm6+cYYBy38/+UFpoXZQ== tarball: 'file:projects/tslint-rules.tgz' version: 0.0.0 'file:projects/utilities.tgz': @@ -16611,7 +16618,7 @@ packages: dev: false name: '@rush-temp/utilities' resolution: - integrity: sha512-jfqrLLbQZjsP0cr3EMZgr+7ZuetY75/FsxAWrAyDWT40Ra1D1zm5Dd9QYjpxyI67P7TTpFHFOvJ+uXneRp9/ug== + integrity: sha512-bM8d1/M17Yid9Ha3sxFOBQEaFzZSG9WcpwaroR/EMlrZJzBTaV7KeP5+EteIupwUu3SR4PIfnZBaOu9KGD/zyg== tarball: 'file:projects/utilities.tgz' version: 0.0.0 'file:projects/variants.tgz': @@ -16621,7 +16628,7 @@ packages: dev: false name: '@rush-temp/variants' resolution: - integrity: sha512-/uAstgRtLVVNLnHNE7Sti8DUE9a9K9kRx6Xph2+j5MlMrg220Dgxnpc+pcci+WY0R37KRZNJLzTOqlrbyYurAw== + integrity: sha512-IdU1Y4eDw2yOXhTX4BIFm7mz8a7SexOQ+KoDCOsHJI8Vp3Kirl/1+6ljpF1I9Psr/jzrxe8VkbE+4flDwllvKA== tarball: 'file:projects/variants.tgz' version: 0.0.0 'file:projects/vr-tests.tgz': @@ -16649,11 +16656,11 @@ packages: storybook-readme: 3.3.0 style-loader: 0.21.0 tslib: 1.9.3 - typescript: 3.3.3 + typescript: 3.5.1 dev: false name: '@rush-temp/vr-tests' resolution: - integrity: sha512-iHm6aRTsTLbLGDq8yPoYZvZy8ykZpJCA3/yhWFwbK0t1X0Q59nrivxJsRDI1VgRMGdd5vW+JlDHUGyZNnTw9FA== + integrity: sha512-NkFK0FIIJBYVTCujI9eBbi4qsJ3SmFv8ai/zIzmodw08Od2x/ySpqTFkMGHZBUStdYDWMs0z/alUAZNM6HnkCQ== tarball: 'file:projects/vr-tests.tgz' version: 0.0.0 'file:projects/webpack-utils.tgz': @@ -16668,7 +16675,7 @@ packages: dev: false name: '@rush-temp/webpack-utils' resolution: - integrity: sha512-Kjy++hHMxbRBiN7Md1bFeyMmD/Zq0gF2UBWlfTbwa7HSzvTrNlk0S0u+GWtmZrsrHvSHZ1nO4vqz845UTSQKIQ== + integrity: sha512-chU7ccaSTCbNdoI3jAdk7W21iADEiwwz9qTfTOcb7rsvG9JAs14QGGoVFwat+FHEiljRHSBgI1Hilsnu8+1dLw== tarball: 'file:projects/webpack-utils.tgz' version: 0.0.0 registry: 'https://registry.npmjs.org/' @@ -16855,7 +16862,7 @@ specifiers: tslint-microsoft-contrib: ^5.0.1 tslint-react: ^3.2.0 ttest: 2.0.0 - typescript: 3.3.3 + typescript: 3.5.1 webpack: 4.29.5 webpack-bundle-analyzer: ^3.0.4 webpack-cli: 3.2.3 diff --git a/packages/charting/src/components/PieChart/Pie/Pie.tsx b/packages/charting/src/components/PieChart/Pie/Pie.tsx index 830d311871100..6f128999c3766 100644 --- a/packages/charting/src/components/PieChart/Pie/Pie.tsx +++ b/packages/charting/src/components/PieChart/Pie/Pie.tsx @@ -15,7 +15,7 @@ export class Pie extends React.Component { return d.y; }) }; - private colors: scale.ScaleOrdinal; + private colors: scale.ScaleOrdinal; constructor(props: IPieProps) { super(props); diff --git a/packages/date-time/src/components/DatePicker/DatePicker.base.tsx b/packages/date-time/src/components/DatePicker/DatePicker.base.tsx index a84e76eaf63ef..5945e0832b19a 100644 --- a/packages/date-time/src/components/DatePicker/DatePicker.base.tsx +++ b/packages/date-time/src/components/DatePicker/DatePicker.base.tsx @@ -179,7 +179,7 @@ export class DatePickerBase extends BaseComponent>(this.props, divProperties, ['value']); const iconProps = textFieldProps && textFieldProps.iconProps; return ( diff --git a/packages/example-app-base/src/components/MarkdownTable/MarkdownTable.types.ts b/packages/example-app-base/src/components/MarkdownTable/MarkdownTable.types.ts index 04736b8a659be..94d3961e321f9 100644 --- a/packages/example-app-base/src/components/MarkdownTable/MarkdownTable.types.ts +++ b/packages/example-app-base/src/components/MarkdownTable/MarkdownTable.types.ts @@ -15,7 +15,8 @@ export interface IMarkdownTableCellProps extends IMarkdownTableProps { * Render the table cell as a th or td. * @default 'td' */ - as: 'th' | 'td'; + // TODO: doc says default is 'td', where is it set? if it has a default, why is 'as' required? making optional for now. + as?: 'th' | 'td'; } export type IMarkdownTableStyleProps = Required> & Pick; diff --git a/packages/example-app-base/src/components/Page/Page.tsx b/packages/example-app-base/src/components/Page/Page.tsx index 3c544ac12ec29..6ee0b84900753 100644 --- a/packages/example-app-base/src/components/Page/Page.tsx +++ b/packages/example-app-base/src/components/Page/Page.tsx @@ -28,6 +28,15 @@ export interface IPageState { isMountedOffset?: boolean; } +// TODO: I think this component should be templated to forward the TPlatform type to props. +// It can then be used in JSX like this: +// {...props} /> +// https://mariusschulz.com/blog/typescript-2-9-passing-generics-to-jsx-elements +// This change will expose a domino effect where other page components in this package should use +// IPageSection props with a templated arg rather than just defaulting to string. These +// issues could probably be more easily found by removing the default TPlatform generic type. +// To work around this issue for now, a bunch of "as IPageSectionProps[]" casts were added to fabric-website package. +// export class Page extends React.Component, IPageState> { export class Page extends React.Component { public static defaultProps: Partial = { showSideRail: true diff --git a/packages/example-app-base/src/components/Page/Page.types.ts b/packages/example-app-base/src/components/Page/Page.types.ts index 6e7dad2896c13..8ea50b5a2edf0 100644 --- a/packages/example-app-base/src/components/Page/Page.types.ts +++ b/packages/example-app-base/src/components/Page/Page.types.ts @@ -1,5 +1,5 @@ import * as React from 'react'; -import { IComponentAs, Omit } from 'office-ui-fabric-react'; +import { IComponentAs } from 'office-ui-fabric-react'; import { IExampleCardProps } from '../ExampleCard/index'; import { ISideRailLink } from '../SideRail/index'; import { IPageJson } from 'office-ui-fabric-react/lib/common/DocPage.types'; @@ -88,7 +88,9 @@ export interface IPageProps { hideImplementationTitle?: boolean; /** (8) Array of custom sections. */ + // TODO: TPlatforms generic should be forwarded to otherSections. Requires resolving TODO in Page.tsx. otherSections?: IPageSectionProps[]; + // otherSections?: IPageSectionProps[]; /** (9) If true, render the feedback section with GitHub issues. **/ isFeedbackVisible?: boolean; @@ -161,6 +163,11 @@ export interface IPageSectionProps } /** Version of IPageSectionProps where `sectionName` is required. */ -export type IPageSectionPropsWithSectionName = Required> & Omit; +// TODO: I'm not sure the best way to fix this, and the TS watch issue is making it harder to iterate and try fixes. +// Equating types with a slight loss in type safety for now. +export type IPageSectionPropsWithSectionName = IPageSectionProps; +// export type IPageSectionPropsWithSectionName = +// Required, 'sectionName'>> & Omit, 'sectionName'>; +// export type IPageSectionPropsWithSectionName = Required> & Omit; export type TPlatformPageProps = { [platform in TPlatforms]?: IPageProps }; diff --git a/packages/example-app-base/src/components/Page/sections/ExamplesSection.tsx b/packages/example-app-base/src/components/Page/sections/ExamplesSection.tsx index d790450b7c899..2ecb798cf562b 100644 --- a/packages/example-app-base/src/components/Page/sections/ExamplesSection.tsx +++ b/packages/example-app-base/src/components/Page/sections/ExamplesSection.tsx @@ -5,7 +5,9 @@ import * as styles from '../Page.module.scss'; export interface IExamplesSectionProps extends IPageSectionPropsWithSectionName { exampleKnobs?: React.ReactNode; - examples: IExample[]; + // TODO: There seems to be a disparity between this type and IPageSectionProps as used in Page.tsx. + // Making optional for now to workaround. + examples?: IExample[]; } export const ExamplesSection: React.StatelessComponent = props => { @@ -20,14 +22,15 @@ export const ExamplesSection: React.StatelessComponent =
{exampleKnobs &&
{exampleKnobs}
} - {examples.map((example: IExample) => { - const { view, ...exampleProps } = example; - return ( -
- {view} -
- ); - })} + {examples && + examples.map((example: IExample) => { + const { view, ...exampleProps } = example; + return ( +
+ {view} +
+ ); + })}
); diff --git a/packages/example-app-base/src/utilities/PlatformContext.tsx b/packages/example-app-base/src/utilities/PlatformContext.tsx index 853ae95601f5a..ee8c76d7cc148 100644 --- a/packages/example-app-base/src/utilities/PlatformContext.tsx +++ b/packages/example-app-base/src/utilities/PlatformContext.tsx @@ -10,7 +10,7 @@ export function withPlatform< TPlatforms extends string = string, TProps extends IWithPlatformProps = IWithPlatformProps >(Component: React.ComponentType): React.StatelessComponent { - const ComponentWithPlatform: React.StatelessComponent = (props: TProps & { children?: React.ReactNode }) => ( + const ComponentWithPlatform: React.FunctionComponent = (props: TProps) => ( {(platform: string) => } ); // tslint:disable no-any diff --git a/packages/experiments/src/components/CollapsibleSection/CollapsibleSectionTitle.view.tsx b/packages/experiments/src/components/CollapsibleSection/CollapsibleSectionTitle.view.tsx index 728cb511e3ba4..81f1336524283 100644 --- a/packages/experiments/src/components/CollapsibleSection/CollapsibleSectionTitle.view.tsx +++ b/packages/experiments/src/components/CollapsibleSection/CollapsibleSectionTitle.view.tsx @@ -15,7 +15,7 @@ export const CollapsibleSectionTitleView: ICollapsibleSectionTitleComponent['vie text: Text }); - const buttonProps = getNativeProps(props, buttonProperties); + const buttonProps = getNativeProps>(props, buttonProperties); return ( diff --git a/packages/experiments/src/components/FloatingSuggestions/Suggestions/SuggestionsCore.tsx b/packages/experiments/src/components/FloatingSuggestions/Suggestions/SuggestionsCore.tsx index ca19dbe128145..9068320180f23 100644 --- a/packages/experiments/src/components/FloatingSuggestions/Suggestions/SuggestionsCore.tsx +++ b/packages/experiments/src/components/FloatingSuggestions/Suggestions/SuggestionsCore.tsx @@ -12,7 +12,7 @@ const styles: any = stylesImport; * (e.g. is a valid react key). */ function hasKey(i: T): i is T & { key: string | number } { - if (!(i instanceof Object) || !i.hasOwnProperty('key')) { + if (!(i instanceof Object) || !(i as Object).hasOwnProperty('key')) { return false; } const keyType = typeof (i as T & { key: any }).key; diff --git a/packages/experiments/src/components/FloatingSuggestions/Suggestions/SuggestionsItem.tsx b/packages/experiments/src/components/FloatingSuggestions/Suggestions/SuggestionsItem.tsx index 4b8f6ec35cba2..660a5d27d7861 100644 --- a/packages/experiments/src/components/FloatingSuggestions/Suggestions/SuggestionsItem.tsx +++ b/packages/experiments/src/components/FloatingSuggestions/Suggestions/SuggestionsItem.tsx @@ -51,5 +51,8 @@ export const SuggestionsItemInner: (props: ISuggestionItemProps, ISuggestionsItemStyleProps, ISuggestionsItemStyles>( + SuggestionsItemInner, + getStyles +); export type SuggestionsItem = React.ComponentType>; diff --git a/packages/experiments/src/components/LayoutGroup/LayoutGroup.tsx b/packages/experiments/src/components/LayoutGroup/LayoutGroup.tsx index a4062a4ebe406..0f80d8eb9fdc5 100644 --- a/packages/experiments/src/components/LayoutGroup/LayoutGroup.tsx +++ b/packages/experiments/src/components/LayoutGroup/LayoutGroup.tsx @@ -13,7 +13,7 @@ export class LayoutGroup extends React.Component { public render(): JSX.Element | null { const { children, direction, layoutGap, justify } = this.props; - const divProps = getNativeProps(this.props, divProperties); + const divProps = getNativeProps>(this.props, divProperties); const numberOfChildren = React.Children.count(children); diff --git a/packages/experiments/src/components/PersonaCoin/PersonaCoin.types.ts b/packages/experiments/src/components/PersonaCoin/PersonaCoin.types.ts index 02a54890a2fda..8cea5025c77e2 100644 --- a/packages/experiments/src/components/PersonaCoin/PersonaCoin.types.ts +++ b/packages/experiments/src/components/PersonaCoin/PersonaCoin.types.ts @@ -3,6 +3,7 @@ import { IComponentStyles, IHTMLSlot, ISlotProp, IComponent, IStyleableComponent import { IPersonaPresenceSlot } from '../../utilities/factoryComponents.types'; import { IPersonaCoinImageSlot } from './PersonaCoinImage/PersonaCoinImage.types'; import { IPersonaCoinSize10Slot } from './PersonaCoinSize10/PersonaCoinSize10'; +import { IPersonaCoinInitialsSlot } from './PersonaCoinInitials/PersonaCoinInitials'; export type IPersonaCoinComponent = IComponent; @@ -29,7 +30,7 @@ export interface IPersonaCoinSlots { /** * Slot for the initials element */ - initials?: IPersonaCoinSlot; + initials?: IPersonaCoinInitialsSlot; /** * Slot for the presence element diff --git a/packages/experiments/src/components/PersonaCoin/PersonaCoinInitials/PersonaCoinInitials.tsx b/packages/experiments/src/components/PersonaCoin/PersonaCoinInitials/PersonaCoinInitials.tsx index 10eb0cfa0e4c8..3d7f0f1cf4746 100644 --- a/packages/experiments/src/components/PersonaCoin/PersonaCoinInitials/PersonaCoinInitials.tsx +++ b/packages/experiments/src/components/PersonaCoin/PersonaCoinInitials/PersonaCoinInitials.tsx @@ -1,13 +1,19 @@ import * as React from 'react'; import { Icon, Text } from 'office-ui-fabric-react'; +import { ISlotProp } from '../../../Foundation'; import { IPersonaCoinProps } from '../PersonaCoin.types'; import { getInitials, getRTL } from '../../../Utilities'; +export type IPersonaCoinInitialsSlot = ISlotProp; + +// TODO: Have Markus verify... className props was required, but I'm not sure if it should be. +// If it is truly required, it seems the parent component should be ensuring that default values are +// provided and not assume the consumer of the slot will provide them. export interface IPersonaCoinInitialsProps { initials: IPersonaCoinProps['initials']; text: IPersonaCoinProps['text']; allowPhoneInitials: IPersonaCoinProps['allowPhoneInitials']; - className: string; + className?: string; } export const PersonaCoinInitials: React.StatelessComponent = props => { diff --git a/packages/experiments/src/components/SelectedItemsList/Items/subcomponents/DefaultEditingItem.tsx b/packages/experiments/src/components/SelectedItemsList/Items/subcomponents/DefaultEditingItem.tsx index cdbb180b5b9a1..395c116ec308c 100644 --- a/packages/experiments/src/components/SelectedItemsList/Items/subcomponents/DefaultEditingItem.tsx +++ b/packages/experiments/src/components/SelectedItemsList/Items/subcomponents/DefaultEditingItem.tsx @@ -70,7 +70,7 @@ export class DefaultEditingItemInner extends React.PureComponent>(this.props, inputProperties); return ( , ISelectedPersonaStyleProps, ISelectedPersonaStyles>( + SelectedPersonaInner, + getStyles, + undefined, + { + scope: 'SelectedPersona' + } +) as typeof SelectedPersonaInner; diff --git a/packages/experiments/src/slots/examples/Slots.Content.Example.tsx b/packages/experiments/src/slots/examples/Slots.Content.Example.tsx index 421c61ef811b1..1a7f1325558b8 100644 --- a/packages/experiments/src/slots/examples/Slots.Content.Example.tsx +++ b/packages/experiments/src/slots/examples/Slots.Content.Example.tsx @@ -14,7 +14,7 @@ export class SlotsContentExample extends React.Component<{}, {}> {

Content: Integer

diff --git a/packages/foundation/src/slots.tsx b/packages/foundation/src/slots.tsx index df49a38d719de..9e04800eec4fd 100644 --- a/packages/foundation/src/slots.tsx +++ b/packages/foundation/src/slots.tsx @@ -217,7 +217,8 @@ function _renderSlot< if (ComponentType.create !== undefined) { return ComponentType.create(componentProps, userProps, slotOptions, defaultStyles); } else { - return (defaultFactory(ComponentType) as ISlotFactory)( + // TODO: need to resolve typing / generic issues passing through memoizeFunction. for now, cast to 'unknown' + return ((defaultFactory(ComponentType) as unknown) as ISlotFactory)( componentProps, userProps, slotOptions, diff --git a/packages/merge-styles/etc/merge-styles.api.md b/packages/merge-styles/etc/merge-styles.api.md index 6af4d110665cc..3c00366d972d5 100644 --- a/packages/merge-styles/etc/merge-styles.api.md +++ b/packages/merge-styles/etc/merge-styles.api.md @@ -73,7 +73,7 @@ export type IProcessedStyleSet> = { [P in keyof Omit]: string; } & { subComponentStyles: { - [P in keyof TStyleSet['subComponentStyles']]: __MapToFunctionType; + [P in keyof TStyleSet['subComponentStyles']]: __MapToFunctionType; }; }; diff --git a/packages/merge-styles/src/IStyleSet.ts b/packages/merge-styles/src/IStyleSet.ts index 246b7fd1f0759..44c4dedfe2a9e 100644 --- a/packages/merge-styles/src/IStyleSet.ts +++ b/packages/merge-styles/src/IStyleSet.ts @@ -37,5 +37,9 @@ export type IConcatenatedStyleSet> = { * into a class name. Additionally, all subComponentStyles are style functions. */ export type IProcessedStyleSet> = { [P in keyof Omit]: string } & { - subComponentStyles: { [P in keyof TStyleSet['subComponentStyles']]: __MapToFunctionType }; + subComponentStyles: { + [P in keyof TStyleSet['subComponentStyles']]: __MapToFunctionType< + TStyleSet['subComponentStyles'] extends infer J ? (P extends keyof J ? J[P] : never) : never + > + }; }; diff --git a/packages/migration/package.json b/packages/migration/package.json index b2465f296633e..4fe3815ecc6c2 100644 --- a/packages/migration/package.json +++ b/packages/migration/package.json @@ -37,6 +37,6 @@ "semver": "^5.6.0", "tslib": "^1.7.1", "riceburn": "^1.3.0", - "typescript": "3.3.3" + "typescript": "3.5.1" } } diff --git a/packages/office-ui-fabric-react/etc/office-ui-fabric-react.api.md b/packages/office-ui-fabric-react/etc/office-ui-fabric-react.api.md index 0a23b732cc50f..375e42f8ee476 100644 --- a/packages/office-ui-fabric-react/etc/office-ui-fabric-react.api.md +++ b/packages/office-ui-fabric-react/etc/office-ui-fabric-react.api.md @@ -7229,7 +7229,7 @@ export interface ISuggestionsProps extends React.Props { searchingText?: string; showForceResolve?: () => boolean; showRemoveButtons?: boolean; - styles?: IStyleFunctionOrObject<{}, {}>; + styles?: IStyleFunctionOrObject; suggestions: ISuggestionModel[]; suggestionsAvailableAlertText?: string; suggestionsClassName?: string; diff --git a/packages/office-ui-fabric-react/src/components/Autofill/Autofill.tsx b/packages/office-ui-fabric-react/src/components/Autofill/Autofill.tsx index e64091a2c072d..962217e922570 100644 --- a/packages/office-ui-fabric-react/src/components/Autofill/Autofill.tsx +++ b/packages/office-ui-fabric-react/src/components/Autofill/Autofill.tsx @@ -111,7 +111,7 @@ export class Autofill extends BaseComponent impl public render(): JSX.Element { const { displayValue } = this.state; - const nativeProps = getNativeProps(this.props, inputProperties); + const nativeProps = getNativeProps>(this.props, inputProperties); return ( { ); } - const nativeProps = getNativeProps(this.props, htmlElementProperties, ['className']); + const nativeProps = getNativeProps>(this.props, htmlElementProperties, ['className']); return (
diff --git a/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx b/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx index 01635b055ae41..a480a911b9945 100644 --- a/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx +++ b/packages/office-ui-fabric-react/src/components/Button/BaseButton.tsx @@ -495,7 +495,7 @@ export class BaseButton extends BaseComponent>(buttonProps, [], ['disabled']); const SplitButton = (keytipAttributes?: any): JSX.Element => (
{ didClick = false; }); - function buildRenderButtonWithMenu(callbackMock?: jest.Mock<{}>, persistMenu?: boolean): HTMLElement { + function buildRenderButtonWithMenu(callbackMock?: jest.Mock, persistMenu?: boolean): HTMLElement { const renderedDOM: HTMLElement = renderIntoDocument( impl yearPickerHidden, today } = this.props; - const nativeProps = getNativeProps(this.props, divProperties, ['value']); + const nativeProps = getNativeProps>(this.props, divProperties, ['value']); const { selectedDate, navigatedDayDate, navigatedMonthDate, isMonthPickerVisible, isDayPickerVisible } = this.state; const onHeaderSelect = showMonthPickerAsOverlay ? this._onHeaderSelect : undefined; diff --git a/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx b/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx index 65c11cdd24f34..9f488957e1c96 100644 --- a/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx +++ b/packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx @@ -85,7 +85,7 @@ export class ChoiceGroupBase extends React.Component>(this.props, divProperties, ['onChange', 'className', 'required']); const classNames = getClassNames(styles!, { theme: theme!, diff --git a/packages/office-ui-fabric-react/src/components/ComboBox/ComboBox.tsx b/packages/office-ui-fabric-react/src/components/ComboBox/ComboBox.tsx index eed48b154ab07..849c680a5d9ca 100644 --- a/packages/office-ui-fabric-react/src/components/ComboBox/ComboBox.tsx +++ b/packages/office-ui-fabric-react/src/components/ComboBox/ComboBox.tsx @@ -332,7 +332,7 @@ export class ComboBox extends BaseComponent { const { isOpen, focused, suggestedDisplayValue } = this.state; this._currentVisibleValue = this._getVisibleValue(); - const divProps = getNativeProps(this.props, divProperties, ['onChange', 'value']); + const divProps = getNativeProps>(this.props, divProperties, ['onChange', 'value']); const hasErrorMessage = errorMessage && errorMessage.length > 0 ? true : false; diff --git a/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.base.tsx b/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.base.tsx index cb44836421526..b55035a1e65fc 100644 --- a/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.base.tsx +++ b/packages/office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.base.tsx @@ -610,7 +610,7 @@ export class ContextualMenuBase extends BaseComponent>(itemProps, divProperties); return (
>(this.props, divProperties, ['value']); const iconProps = textFieldProps && textFieldProps.iconProps; return ( diff --git a/packages/office-ui-fabric-react/src/components/DetailsList/DetailsHeader.test.tsx b/packages/office-ui-fabric-react/src/components/DetailsList/DetailsHeader.test.tsx index d37d03f388c54..fea1bf3a6a807 100644 --- a/packages/office-ui-fabric-react/src/components/DetailsList/DetailsHeader.test.tsx +++ b/packages/office-ui-fabric-react/src/components/DetailsList/DetailsHeader.test.tsx @@ -214,14 +214,12 @@ const columns1: IColumn[] = [ ]; const _columnReorderProps = { - frozenColumnCountFromStart: 1, - handleColumnReorder: this._dummyFunction + frozenColumnCountFromStart: 1 }; const _columnReorderProps2 = { frozenColumnCountFromStart: 1, - frozenColumnCountFromEnd: 1, - handleColumnReorder: this._dummyFunction + frozenColumnCountFromEnd: 1 }; _selection.setItems(_items); diff --git a/packages/office-ui-fabric-react/src/components/DocumentCard/DocumentCard.base.tsx b/packages/office-ui-fabric-react/src/components/DocumentCard/DocumentCard.base.tsx index 132b2b6592150..d0f988e0b73c9 100644 --- a/packages/office-ui-fabric-react/src/components/DocumentCard/DocumentCard.base.tsx +++ b/packages/office-ui-fabric-react/src/components/DocumentCard/DocumentCard.base.tsx @@ -26,7 +26,12 @@ export class DocumentCardBase extends BaseComponent imp public render(): JSX.Element { const { onClick, onClickHref, children, type, accentColor, styles, theme, className } = this.props; - const nativeProps = getNativeProps(this.props, divProperties, ['className', 'onClick', 'type', 'role']); + const nativeProps = getNativeProps>(this.props, divProperties, [ + 'className', + 'onClick', + 'type', + 'role' + ]); const actionable = onClick || onClickHref ? true : false; this._classNames = getClassNames(styles!, { diff --git a/packages/office-ui-fabric-react/src/components/Fabric/Fabric.base.tsx b/packages/office-ui-fabric-react/src/components/Fabric/Fabric.base.tsx index ca7996d02214a..fd887ddbdd393 100644 --- a/packages/office-ui-fabric-react/src/components/Fabric/Fabric.base.tsx +++ b/packages/office-ui-fabric-react/src/components/Fabric/Fabric.base.tsx @@ -10,7 +10,7 @@ export class FabricBase extends React.Component< { isFocusVisible: boolean; } -> { + > { private _rootElement = React.createRef(); private _disposables: (() => void)[] = []; @@ -24,7 +24,7 @@ export class FabricBase extends React.Component< ...(this.props as IFabricStyleProps), ...this.state }); - const divProps = getNativeProps(this.props, divProperties); + const divProps = getNativeProps>(this.props, divProperties); return
; } diff --git a/packages/office-ui-fabric-react/src/components/FocusTrapZone/FocusTrapZone.tsx b/packages/office-ui-fabric-react/src/components/FocusTrapZone/FocusTrapZone.tsx index 5ff5b485e9df5..c6d327809dffe 100644 --- a/packages/office-ui-fabric-react/src/components/FocusTrapZone/FocusTrapZone.tsx +++ b/packages/office-ui-fabric-react/src/components/FocusTrapZone/FocusTrapZone.tsx @@ -74,7 +74,7 @@ export class FocusTrapZone extends React.Component impl public render(): JSX.Element { const { className, disabled = false, ariaLabelledBy } = this.props; - const divProps = getNativeProps(this.props, divProperties); + const divProps = getNativeProps>(this.props, divProperties); const bumperProps = { style: { diff --git a/packages/office-ui-fabric-react/src/components/HoverCard/HoverCard.base.tsx b/packages/office-ui-fabric-react/src/components/HoverCard/HoverCard.base.tsx index 106a036eefd3d..a873dd1cd2e1a 100644 --- a/packages/office-ui-fabric-react/src/components/HoverCard/HoverCard.base.tsx +++ b/packages/office-ui-fabric-react/src/components/HoverCard/HoverCard.base.tsx @@ -120,7 +120,7 @@ export class HoverCardBase extends BaseComponent>(this.props, divProperties), id: hoverCardId, trapFocus: !!trapFocus, firstFocus: setInitialFocus || openMode === OpenCardMode.hotKey, diff --git a/packages/office-ui-fabric-react/src/components/Icon/Icon.base.tsx b/packages/office-ui-fabric-react/src/components/Icon/Icon.base.tsx index c1806c6568ec6..1801b747ddfdb 100644 --- a/packages/office-ui-fabric-react/src/components/Icon/Icon.base.tsx +++ b/packages/office-ui-fabric-react/src/components/Icon/Icon.base.tsx @@ -43,7 +43,7 @@ export class IconBase extends React.Component { }; const RootType = isImage ? 'div' : 'i'; - const nativeProps = getNativeProps(this.props, htmlElementProperties); + const nativeProps = getNativeProps>(this.props, htmlElementProperties); const { imageLoadError } = this.state; const imageProps = { ...this.props.imageProps, diff --git a/packages/office-ui-fabric-react/src/components/Image/Image.base.tsx b/packages/office-ui-fabric-react/src/components/Image/Image.base.tsx index 0bca5ae38b81f..59ab888f69382 100644 --- a/packages/office-ui-fabric-react/src/components/Image/Image.base.tsx +++ b/packages/office-ui-fabric-react/src/components/Image/Image.base.tsx @@ -50,7 +50,7 @@ export class ImageBase extends React.Component { } public render(): JSX.Element { - const imageProps = getNativeProps(this.props, imageProperties, ['width', 'height']); + const imageProps = getNativeProps>(this.props, imageProperties, ['width', 'height']); const { src, alt, diff --git a/packages/office-ui-fabric-react/src/components/List/List.tsx b/packages/office-ui-fabric-react/src/components/List/List.tsx index c7fc52c103785..91aae73e86a46 100644 --- a/packages/office-ui-fabric-react/src/components/List/List.tsx +++ b/packages/office-ui-fabric-react/src/components/List/List.tsx @@ -362,7 +362,7 @@ export class List extends BaseComponent, IListState> i const { className, role = 'list' } = this.props; const { pages = [] } = this.state; const pageElements: JSX.Element[] = []; - const divProps = getNativeProps(this.props, divProperties); + const divProps = getNativeProps>(this.props, divProperties); for (const page of pages) { pageElements.push(this._renderPage(page)); diff --git a/packages/office-ui-fabric-react/src/components/MarqueeSelection/MarqueeSelection.tsx b/packages/office-ui-fabric-react/src/components/MarqueeSelection/MarqueeSelection.tsx index 9e330ee2471c3..7dca40ea4abdd 100644 --- a/packages/office-ui-fabric-react/src/components/MarqueeSelection/MarqueeSelection.tsx +++ b/packages/office-ui-fabric-react/src/components/MarqueeSelection/MarqueeSelection.tsx @@ -1,8 +1,11 @@ import { styled } from '../../Utilities'; import { MarqueeSelectionBase } from './MarqueeSelection.base'; import { getStyles } from './MarqueeSelection.styles'; -import { IMarqueeSelectionProps } from './MarqueeSelection.types'; +import { IMarqueeSelectionProps, IMarqueeSelectionStyleProps, IMarqueeSelectionStyles } from './MarqueeSelection.types'; -export const MarqueeSelection: React.StatelessComponent = styled(MarqueeSelectionBase, getStyles, undefined, { - scope: 'MarqueeSelection' -}); +export const MarqueeSelection: React.StatelessComponent = + // TODO: MarqueeSelectionBase defaultProps are not lining up with IMarqueeSelectionProps, so we have to be explicit with styled here. + // defaultProps.rootTagName doesn't appear to be used anywhere and defaultProps.rootProps is not in IMarqueeSelectionProps. + styled(MarqueeSelectionBase, getStyles, undefined, { + scope: 'MarqueeSelection' + }); diff --git a/packages/office-ui-fabric-react/src/components/MessageBar/MessageBar.base.tsx b/packages/office-ui-fabric-react/src/components/MessageBar/MessageBar.base.tsx index 0e81b1af51472..0406c648c30f3 100644 --- a/packages/office-ui-fabric-react/src/components/MessageBar/MessageBar.base.tsx +++ b/packages/office-ui-fabric-react/src/components/MessageBar/MessageBar.base.tsx @@ -139,7 +139,7 @@ export class MessageBarBase extends BaseComponent>(this.props, htmlElementProperties, ['className']); return (
diff --git a/packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.base.tsx b/packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.base.tsx index 1c447dc4a9f86..f4e0a3ee68355 100644 --- a/packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.base.tsx +++ b/packages/office-ui-fabric-react/src/components/OverflowSet/OverflowSet.base.tsx @@ -42,13 +42,13 @@ export class OverflowSetBase extends BaseComponent implem if (doNotContainWithinFocusZone) { Tag = 'div'; uniqueComponentProps = { - ...getNativeProps(this.props, divProperties), + ...getNativeProps>(this.props, divProperties), ref: this._divContainer }; } else { Tag = FocusZone; uniqueComponentProps = { - ...getNativeProps(this.props, divProperties), + ...getNativeProps>(this.props, divProperties), ...focusZoneProps, componentRef: this._focusZone, direction: vertical ? FocusZoneDirection.vertical : FocusZoneDirection.horizontal diff --git a/packages/office-ui-fabric-react/src/components/Overlay/Overlay.base.tsx b/packages/office-ui-fabric-react/src/components/Overlay/Overlay.base.tsx index 4e35b2f7883c5..5c809c6f321e0 100644 --- a/packages/office-ui-fabric-react/src/components/Overlay/Overlay.base.tsx +++ b/packages/office-ui-fabric-react/src/components/Overlay/Overlay.base.tsx @@ -16,7 +16,7 @@ export class OverlayBase extends BaseComponent { public render(): JSX.Element { const { isDarkThemed: isDark, className, theme, styles } = this.props; - const divProps = getNativeProps(this.props, divProperties); + const divProps = getNativeProps>(this.props, divProperties); const classNames = getClassNames(styles!, { theme: theme!, diff --git a/packages/office-ui-fabric-react/src/components/Panel/Panel.base.tsx b/packages/office-ui-fabric-react/src/components/Panel/Panel.base.tsx index d6ac275799b52..c3afcb7edd9b0 100644 --- a/packages/office-ui-fabric-react/src/components/Panel/Panel.base.tsx +++ b/packages/office-ui-fabric-react/src/components/Panel/Panel.base.tsx @@ -139,7 +139,7 @@ export class PanelBase extends BaseComponent implement const isOnRightSide = isRTL ? isLeft : !isLeft; const headerTextId = headerText && id + '-headerText'; const customWidthStyles = type === PanelType.custom || type === PanelType.customNear ? { width: customWidth } : {}; - const nativeProps = getNativeProps(this.props, divProperties); + const nativeProps = getNativeProps>(this.props, divProperties); const isOpen = this.isActive; const isAnimating = visibility === PanelVisibilityState.animatingClosed || visibility === PanelVisibilityState.animatingOpen; diff --git a/packages/office-ui-fabric-react/src/components/Panel/examples/Panel.HandleDismissTarget.Example.tsx b/packages/office-ui-fabric-react/src/components/Panel/examples/Panel.HandleDismissTarget.Example.tsx index bc8a75e9e4b0e..47cbec0ee23f2 100644 --- a/packages/office-ui-fabric-react/src/components/Panel/examples/Panel.HandleDismissTarget.Example.tsx +++ b/packages/office-ui-fabric-react/src/components/Panel/examples/Panel.HandleDismissTarget.Example.tsx @@ -52,10 +52,10 @@ export class PanelHandleDismissTargetExample extends React.Component<{}, IPanelH } console.log('Close button clicked or light dismissed.'); - if (ev.nativeEvent.srcElement && ev.nativeEvent.srcElement.className.indexOf('ms-Button-icon') !== -1) { + if (ev.nativeEvent.srcElement && (ev.nativeEvent.srcElement as Element).className.indexOf('ms-Button-icon') !== -1) { console.log('Close button clicked.'); } - if (ev.nativeEvent.srcElement && ev.nativeEvent.srcElement.className.indexOf('ms-Overlay') !== -1) { + if (ev.nativeEvent.srcElement && (ev.nativeEvent.srcElement as Element).className.indexOf('ms-Overlay') !== -1) { console.log('Light dismissed.'); } this._hidePanel(); diff --git a/packages/office-ui-fabric-react/src/components/Persona/Persona.base.tsx b/packages/office-ui-fabric-react/src/components/Persona/Persona.base.tsx index 43d50d3af549c..ac0b441f90c03 100644 --- a/packages/office-ui-fabric-react/src/components/Persona/Persona.base.tsx +++ b/packages/office-ui-fabric-react/src/components/Persona/Persona.base.tsx @@ -97,7 +97,7 @@ export class PersonaBase extends BaseComponent { size }); - const divProps = getNativeProps(this.props, divProperties); + const divProps = getNativeProps>(this.props, divProperties); const personaDetails = (
{this._renderElement(classNames.primaryText, onRenderPrimaryText, _onRenderPrimaryText)} diff --git a/packages/office-ui-fabric-react/src/components/Persona/PersonaCoin/PersonaCoin.base.tsx b/packages/office-ui-fabric-react/src/components/Persona/PersonaCoin/PersonaCoin.base.tsx index 8979a9fd253cd..4b189dabf0c02 100644 --- a/packages/office-ui-fabric-react/src/components/Persona/PersonaCoin/PersonaCoin.base.tsx +++ b/packages/office-ui-fabric-react/src/components/Persona/PersonaCoin/PersonaCoin.base.tsx @@ -69,8 +69,8 @@ export class PersonaCoinBase extends BaseComponent>(this.props, divProperties); + const divCoinProps = getNativeProps>(coinProps || {}, divProperties); const coinSizeStyle = coinSize ? { width: coinSize, height: coinSize } : undefined; const hideImage = showUnknownPersonaCoin; diff --git a/packages/office-ui-fabric-react/src/components/Pivot/Pivot.base.tsx b/packages/office-ui-fabric-react/src/components/Pivot/Pivot.base.tsx index c8733260543f3..d6bb81c62088e 100644 --- a/packages/office-ui-fabric-react/src/components/Pivot/Pivot.base.tsx +++ b/packages/office-ui-fabric-react/src/components/Pivot/Pivot.base.tsx @@ -84,7 +84,7 @@ export class PivotBase extends BaseComponent { const linkCollection = this._getPivotLinks(this.props); const selectedKey = this._getSelectedKey(linkCollection); - const divProps = getNativeProps(this.props, divProperties); + const divProps = getNativeProps>(this.props, divProperties); this._classNames = this._getClassNames(this.props); diff --git a/packages/office-ui-fabric-react/src/components/ResizeGroup/ResizeGroup.base.tsx b/packages/office-ui-fabric-react/src/components/ResizeGroup/ResizeGroup.base.tsx index c050ca54692a9..1724326a91279 100644 --- a/packages/office-ui-fabric-react/src/components/ResizeGroup/ResizeGroup.base.tsx +++ b/packages/office-ui-fabric-react/src/components/ResizeGroup/ResizeGroup.base.tsx @@ -326,7 +326,7 @@ export class ResizeGroupBase extends BaseComponent>(this.props, divProperties, ['data']); const dataNeedsMeasuring = this._nextResizeGroupStateProvider.shouldRenderDataForMeasurement(dataToMeasure); diff --git a/packages/office-ui-fabric-react/src/components/SearchBox/SearchBox.base.tsx b/packages/office-ui-fabric-react/src/components/SearchBox/SearchBox.base.tsx index c574fbecafeb1..3e844d4b3713c 100644 --- a/packages/office-ui-fabric-react/src/components/SearchBox/SearchBox.base.tsx +++ b/packages/office-ui-fabric-react/src/components/SearchBox/SearchBox.base.tsx @@ -78,7 +78,14 @@ export class SearchBoxBase extends BaseComponent>(this.props, inputProperties, [ + 'id', + 'className', + 'placeholder', + 'onFocus', + 'onBlur', + 'value' + ]); return (
diff --git a/packages/office-ui-fabric-react/src/components/SelectedItemsList/SelectedPeopleList/Items/EditingItem.tsx b/packages/office-ui-fabric-react/src/components/SelectedItemsList/SelectedPeopleList/Items/EditingItem.tsx index 3e1c7eaf556fb..2e3a3a81051ea 100644 --- a/packages/office-ui-fabric-react/src/components/SelectedItemsList/SelectedPeopleList/Items/EditingItem.tsx +++ b/packages/office-ui-fabric-react/src/components/SelectedItemsList/SelectedPeopleList/Items/EditingItem.tsx @@ -41,7 +41,7 @@ export class EditingItem extends BaseComponent>(this.props, inputProperties); return (
{ shimmerWaveColor: shimmerColors && shimmerColors.shimmerWave }); - const divProps = getNativeProps(this.props, divProperties); + const divProps = getNativeProps>(this.props, divProperties); return (
diff --git a/packages/office-ui-fabric-react/src/components/Slider/Slider.base.tsx b/packages/office-ui-fabric-react/src/components/Slider/Slider.base.tsx index e24da430cca1a..052e2f0022870 100644 --- a/packages/office-ui-fabric-react/src/components/Slider/Slider.base.tsx +++ b/packages/office-ui-fabric-react/src/components/Slider/Slider.base.tsx @@ -75,7 +75,7 @@ export class SliderBase extends BaseComponent implem showValue, theme: theme! }); - const divButtonProps = buttonProps ? getNativeProps(buttonProps, divProperties) : undefined; + const divButtonProps = buttonProps ? getNativeProps>(buttonProps, divProperties) : undefined; return (
diff --git a/packages/office-ui-fabric-react/src/components/Spinner/Spinner.base.tsx b/packages/office-ui-fabric-react/src/components/Spinner/Spinner.base.tsx index 1c9fa578d19a2..5d4e13f538dd0 100644 --- a/packages/office-ui-fabric-react/src/components/Spinner/Spinner.base.tsx +++ b/packages/office-ui-fabric-react/src/components/Spinner/Spinner.base.tsx @@ -14,7 +14,7 @@ export class SpinnerBase extends BaseComponent { public render() { const { type, size, ariaLabel, ariaLive, styles, label, theme, className, labelPosition } = this.props; const statusMessage = ariaLabel; - const nativeProps = getNativeProps(this.props, divProperties, ['size']); + const nativeProps = getNativeProps>(this.props, divProperties, ['size']); // SpinnerType is deprecated. If someone is still using this property, rather than putting the SpinnerType into the ISpinnerStyleProps, // we'll map SpinnerType to its equivalent SpinnerSize and pass that in. Once SpinnerType finally goes away we should delete this. diff --git a/packages/office-ui-fabric-react/src/components/Stack/Stack.tsx b/packages/office-ui-fabric-react/src/components/Stack/Stack.tsx index 6d787e6138280..72ae4c28fbac4 100644 --- a/packages/office-ui-fabric-react/src/components/Stack/Stack.tsx +++ b/packages/office-ui-fabric-react/src/components/Stack/Stack.tsx @@ -41,7 +41,7 @@ const StackView: IStackComponent['view'] = props => { } ); - const nativeProps = getNativeProps(rest, htmlElementProperties); + const nativeProps = getNativeProps>(rest, htmlElementProperties); const Slots = getSlots(props, { root: RootType, diff --git a/packages/office-ui-fabric-react/src/components/TextField/TextField.base.tsx b/packages/office-ui-fabric-react/src/components/TextField/TextField.base.tsx index 179ce7b175c78..3c6970b97615a 100644 --- a/packages/office-ui-fabric-react/src/components/TextField/TextField.base.tsx +++ b/packages/office-ui-fabric-react/src/components/TextField/TextField.base.tsx @@ -436,7 +436,9 @@ export class TextFieldBase extends React.Component> { - const textAreaProps = getNativeProps(this.props, textAreaProperties, ['defaultValue']); + const textAreaProps = getNativeProps>(this.props, textAreaProperties, [ + 'defaultValue' + ]); return (