Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Coverage - Implement HELLO #346

Closed
mattholy opened this issue Apr 30, 2024 · 0 comments · Fixed by #398
Closed

API Coverage - Implement HELLO #346

mattholy opened this issue Apr 30, 2024 · 0 comments · Fixed by #398
Assignees
Labels

Comments

@mattholy
Copy link

Feature request type

sample request

Is your feature request related to a problem? Please describe

When using example from https://microsoft.github.io/garnet/docs/welcome/releases

redis-cli
127.0.0.1:6379> set key value
OK
127.0.0.1:6379> get key
"value"
127.0.0.1:6379> hello
(error) ERR unknown command

But for a actual redis:

127.0.0.1:6379> hello
[
    "server",
    "redis",
    "version",
    "7.2.4",
    "proto",
    2,
    "id",
    8,
    "mode",
    "standalone",
    "role",
    "master",
    "modules",
    []
]

It matters because some python frameworks like Celery are using hello. It's a pity if they can not use such a k-v database.

Describe the solution you'd like

Implement https://redis.io/docs/latest/commands/hello/

Describe alternatives you've considered

No response

Additional context

https://github.com/celery/celery/blob/90ff2e1290ef058e8dc59dc1d86ff38f668abc50/celery/app/control.py#L388-L389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants