Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeResetStyles should not override makeStyles #526

Closed
NotWoods opened this issue Mar 27, 2024 · 2 comments
Closed

makeResetStyles should not override makeStyles #526

NotWoods opened this issue Mar 27, 2024 · 2 comments
Labels
❎ duplicate This issue or pull request already exists

Comments

@NotWoods
Copy link
Member

In Loop, we have separate JavaScript bundles for our app code (outer UI frame with sidebar) and page code (reusable components that can be embedded in other Microsoft apps). Both bundles load Griffel.

This results in two copies of Griffel on the page, and they don't collaborate very well. Notably, the second copy's makeResetStyles CSS are inserted after the first copy's makeStyles CSS. This results in overriding a ton of CSS in the app where we customize Fluent UI controls, such as removing the min-width of a Fluent UI button.

Ideally makeResetStyles should always insert at the top of the head, rather than at the bottom. Webpack Extraction might affect this.

@layershifter
Copy link
Member

There is a separate feature to support this properly, #453. We will work on it next quarter.

@layershifter
Copy link
Member

Closing in favor of #453.

@layershifter layershifter added the ❎ duplicate This issue or pull request already exists label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❎ duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants