Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/kiota-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.7
Choose a base ref
...
head repository: microsoft/kiota-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.1.8
Choose a head ref
  • 7 commits
  • 6 files changed
  • 5 contributors

Commits on Apr 24, 2024

  1. Bump dependabot/fetch-metadata from 2.0.0 to 2.1.0

    Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 2.0.0 to 2.1.0.
    - [Release notes](https://github.com/dependabot/fetch-metadata/releases)
    - [Commits](dependabot/fetch-metadata@v2.0.0...v2.1.0)
    
    ---
    updated-dependencies:
    - dependency-name: dependabot/fetch-metadata
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Apr 24, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    1e5206a View commit details

Commits on Apr 25, 2024

  1. Merge pull request #1237 from microsoft/dependabot/github_actions/dep…

    …endabot/fetch-metadata-2.1.0
    
    Bump dependabot/fetch-metadata from 2.0.0 to 2.1.0
    github-actions[bot] authored Apr 25, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    39a3659 View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    8fa919e View commit details
  3. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    56a0146 View commit details
  4. - bumps patch version

    Signed-off-by: Vincent Biret <vibiret@microsoft.com>
    baywet committed Apr 25, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    df72fe9 View commit details
  5. - fixes formatting

    baywet committed Apr 25, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    1f8553f View commit details
  6. Merge pull request #1240 from m-moris/bugfix/change_mutable_list

    Changed the initialization method of the options field in BaseRequestConfiguration
    baywet authored Apr 25, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    dd7c7fa View commit details
2 changes: 1 addition & 1 deletion .github/workflows/auto-merge-dependabot.yml
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@ jobs:
steps:
- name: Dependabot metadata
id: metadata
uses: dependabot/fetch-metadata@v2.0.0
uses: dependabot/fetch-metadata@v2.1.0
with:
github-token: "${{ secrets.GITHUB_TOKEN }}"

6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [1.1.8] - 2024-04-25

### Changed

- Fixed a bug where options could not be added to request information. [#1238](https://github.com/microsoft/kiota-java/issues/1238)

## [1.1.7] - 2024-04-23

### Changed
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@

import jakarta.annotation.Nonnull;

import java.util.Collections;
import java.util.ArrayList;
import java.util.List;

/**
@@ -24,5 +24,5 @@ public BaseRequestConfiguration() {
/**
* Request options
*/
@Nonnull public List<RequestOption> options = Collections.emptyList();
@Nonnull public List<RequestOption> options = new ArrayList<RequestOption>();
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
package com.microsoft.kiota;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;

import org.junit.jupiter.api.Test;

public class BaseRequestConfigurationTest {

public static class TestRequestConfiguration extends BaseRequestConfiguration {
public TestRequestConfiguration() {
super();
}
}

@Test
void testOptions() {
TestRequestConfiguration requestConfiguration = new TestRequestConfiguration();
assertNotNull(requestConfiguration.options);

RequestOption requestOption =
new RequestOption() {
@Override
public <T extends RequestOption> Class<T> getType() {
return null;
}
};
// options should be mutable list
requestConfiguration.options.add(requestOption);
assertEquals(1, requestConfiguration.options.size());
assertEquals(requestOption, requestConfiguration.options.get(0));
}
}
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@ public UserAgentHandlerOption() {}

private boolean enabled = true;
@Nonnull private String productName = "kiota-java";
@Nonnull private String productVersion = "1.1.1";
@Nonnull private String productVersion = "1.1.8";

/**
* Gets the product name to be used in the user agent header
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ org.gradle.caching=true
mavenGroupId = com.microsoft.kiota
mavenMajorVersion = 1
mavenMinorVersion = 1
mavenPatchVersion = 7
mavenPatchVersion = 8
mavenArtifactSuffix =

#These values are used to run functional tests