Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Update monaco-editor-webpack-plugin to support monaco-editor 0.17.0 #66

Closed
wilsonwang881 opened this issue May 25, 2019 · 7 comments
Closed
Assignees
Milestone

Comments

@wilsonwang881
Copy link

Hello there!

The current version of the monaco-editor-webpack-plugin supports monaco-editor of version 0.15.1. However, the latest version of the monaco editor is 0.17.0.

Could you please update the monaco-editor-webpack-plugin to support the latest version monaco editor?

Thank you very much!

@blackshadev
Copy link

Hi into what kind of errors did you run?
I updated monaco-editor to version 0.17.1 and it worked fine for me.

@7rulnik
Copy link

7rulnik commented Sep 1, 2019

@blackshadev I think the main problem here is wrong peerDependencies. Some people have checks in CI for this thing.

@blackshadev
Copy link

@7rulnik , that makes sense, thanks for the explanation.
I see two pull requests open for version bumps (one for 0.16 and one for 0,17) , but no response from someone who can make the merge happen. such a shame.
See #67

@7rulnik
Copy link

7rulnik commented Sep 2, 2019

@alexandrudima maybe you can help with this issue?

@bitjson
Copy link

bitjson commented Nov 7, 2019

The latest version of monaco-editor is now ^0.18 – any chance the peer dependency requirement could be bumped? Currently seeing monaco-editor-webpack-plugin@1.7.0" has incorrect peer dependency "monaco-editor@^0.15.1". every install.

As far as I can tell, I've had no issues with using the latest version.

@codebryo
Copy link

@bitjson if you still get errors and they block you in CI, the resolutions field in the package.json can do the trick.
When verified it's all working as you want, just add the following:

"resolutions": {
    "monaco-editor" : "0.18.1"
}

That will make yarn check pass and turn the error into a warning.

@alexdima alexdima added this to the December 2019 milestone Dec 19, 2019
@alexdima alexdima self-assigned this Dec 19, 2019
@alexdima
Copy link
Member

This has been done on master now.

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants