This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Add support for plugin-specific public path #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Override the public path from which files generated by this plugin will be served. This wins out over Webpack's dynamic runtime path and can be useful to avoid attempting to load workers cross-origin when using a CDN for other static resources.
|
|
jimmydief
commented
Nov 15, 2019
| // 2. Dynamic runtime public path. | ||
| // 3. Compilation public path. | ||
| const pathPrefix = Boolean(pluginPublicPath) | ||
| ? JSON.stringify(pluginPublicPath) |
There was a problem hiding this comment.
Plugin public path wins out over dynamic public path if specified.
| const pathPrefix = Boolean(pluginPublicPath) | ||
| ? JSON.stringify(pluginPublicPath) | ||
| : `typeof __webpack_public_path__ === 'string' ` + | ||
| `? __webpack_public_path__ ` + |
|
Thank you! ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override the public path from which files generated by this plugin will be served. This wins out over Webpack's dynamic runtime path and can be useful to avoid attempting to load workers cross-origin when using a CDN for other static resources.
Not sure what the testing strategy here should be.
Fixes #80.