Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add await helper support #1620

Closed
ErkoKnoll opened this issue Oct 7, 2019 · 3 comments
Closed

Add await helper support #1620

ErkoKnoll opened this issue Oct 7, 2019 · 3 comments
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities open for PR Chances are high we accept a PR for this issue (even if it got closed). typescript
Milestone

Comments

@ErkoKnoll
Copy link

With the new TS 3.6 release TS is now able to notify if the user has forgotten to use await keyword as following: Did you forget to use 'await'?, including appropriate quick fix.

After I upgraded to 18.1 I cannot see that help being available on Monaco the same way as it is available in VS Code.

Is there a property that needs enabling to get it working?

@spahnke
Copy link
Contributor

spahnke commented Oct 7, 2019

Support for quickfixes in general was added recently with microsoft/monaco-typescript#40. I guess this will be included in the next release.

@spahnke
Copy link
Contributor

spahnke commented Oct 7, 2019

Based on your issue I also created microsoft/monaco-typescript#48 so that the related information will be shown in the error message. Quickfixes are available regardless, this PR only adds the additional text to the error message.

@alexdima alexdima added typescript feature-request Request for new features or functionality labels Dec 10, 2019
@alexdima alexdima added this to the On Deck milestone Dec 10, 2019
@hediet
Copy link
Member

hediet commented Feb 24, 2023

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@hediet hediet closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2023
@hediet hediet added help wanted Issues identified as good community contribution opportunities open for PR Chances are high we accept a PR for this issue (even if it got closed). labels Feb 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities open for PR Chances are high we accept a PR for this issue (even if it got closed). typescript
Projects
None yet
Development

No branches or pull requests

4 participants