Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monaco-editor-core@0.19.0: broken typescript types #1729

Closed
AviVahl opened this issue Dec 22, 2019 · 1 comment
Closed

monaco-editor-core@0.19.0: broken typescript types #1729

AviVahl opened this issue Dec 22, 2019 · 1 comment
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Milestone
December 2019

Comments

@AviVahl
Copy link

AviVahl commented Dec 22, 2019 •
edited

New release of monaco-editor-core (0.19.0) has broken typescript types.
monaco-editor package appears to be fine.

Steps to reproduce:

mkdir monaco-test
cd monaco-test
yarn init -yp
yarn add typescript monaco-editor-core
yarn tsc --init
echo "import 'monaco-editor-core';" > a.ts
yarn tsc --noEmit
# see type errors

monaco-editor-core version: 0.19.0
Browser: irrelevant
OS: irrelevant
@rebornix
Copy link
Member

rebornix commented Jan 1, 2020

Didn't see any error with 0.18.x

@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Jan 6, 2020
@alexdima alexdima added this to the December 2019 milestone Jan 6, 2020
alexdima added a commit that referenced this issue Jan 6, 2020
@alexdima
Fixes #1729: Fix running the build on Windows (files with \r\n)
38b4e2e
alexdima added a commit to microsoft/vscode that referenced this issue Jan 6, 2020
@alexdima
Fixes microsoft/monaco-editor#1729: Fix running the build on Windows …
6e8c7d2 
…(files with \r\n)
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Milestone
December 2019
Development

No branches or pull requests
3 participants
@rebornix @alexdima @AviVahl