Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wordBasedSuggestions is gone in 0.19.0 #1746

Closed
rcjsuen opened this issue Jan 3, 2020 · 2 comments
Closed

wordBasedSuggestions is gone in 0.19.0 #1746

rcjsuen opened this issue Jan 3, 2020 · 2 comments
Assignees
Labels
debt editor-api important Issue identified as high-priority
Milestone

Comments

@rcjsuen
Copy link
Contributor

rcjsuen commented Jan 3, 2020

Is this intentional? The content can be found here in the 0.18.1 version of monaco.d.ts.

wordBasedSuggestions can no longer be found here in 0.19.0.

@rcjsuen
Copy link
Contributor Author

rcjsuen commented Jan 3, 2020

I'm assuming this isn't intentional but if it is please add an entry to the CHANGELOG.md so we can all be made aware of this.

@alexdima
Copy link
Member

alexdima commented Jan 6, 2020

There are a bunch of settings that are "global" and are being read directly from the configuration service by various pieces of code. Those settings do not make it through the same code paths as the internal editor options and cannot be customized per editor. In other words, wordBasedSuggestions was in IEditorOptions, but that was somewhat of an oversight since it does not function like any of the other editor options.

Here are the "global" settings which are not editor options per se, although calling editor.updateOptions with them works as expected due to some trickery done via the SimpleConfigurationService. Those settings are currently not properly typed anywhere.

TL;DR: Effectively, updateOptions({ wordBasedSuggestions: false }), or other code patterns work, but this isn't typed properly anymore... Just like the other "global" settings.

@alexdima alexdima modified the milestones: On Deck, December 2019 Jan 6, 2020
@alexdima alexdima added the important Issue identified as high-priority label Jan 6, 2020
alexdima added a commit to microsoft/vscode that referenced this issue Jan 6, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt editor-api important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

2 participants