Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ESM Version is missing extensions in one file. #4175

Open
2 tasks done
jogibear9988 opened this issue Sep 13, 2023 · 2 comments
Open
2 tasks done

[Bug] ESM Version is missing extensions in one file. #4175

jogibear9988 opened this issue Sep 13, 2023 · 2 comments
Labels
ESM ECMAScript modules help wanted Issues identified as good community contribution opportunities

Comments

@jogibear9988
Copy link

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Monaco Editor Playground Link

No response

Monaco Editor Playground Code

No response

Reproduction Steps

Look at https://cdn.jsdelivr.net/npm/monaco-editor@0.43.0/esm/vs/editor/editor.main.js, this file is missing .js extensions. This breaks importing via importmaps.

If this is fixed, the Editor could be used directly without a bundler

Actual (Problematic) Behavior

https://cdn.jsdelivr.net/npm/monaco-editor@0.43.0/esm/vs/editor/editor.main.js is missing .js extensions in im and exports

Expected Behavior

the files should contain extensions

Additional Context

No response

@hediet hediet added ESM ECMAScript modules help wanted Issues identified as good community contribution opportunities labels Oct 5, 2023
@jogibear9988
Copy link
Author

@hediet isn't this something that could be fixed easily?
I would look for it, if there is a description how to build monaco editor component locally.

jogibear9988 added a commit to jogibear9988/monaco-editor that referenced this issue Feb 26, 2024
@jogibear9988
Copy link
Author

fixed in #4399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ESM ECMAScript modules help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

No branches or pull requests

2 participants