Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] There is always a focus-border around editor when editor background is transparent #4455

Open
1 task done
KurtGokhan opened this issue Apr 2, 2024 · 1 comment · May be fixed by microsoft/vscode#209368
Open
1 task done

Comments

@KurtGokhan
Copy link

KurtGokhan commented Apr 2, 2024

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Monaco Editor Playground Link

Playground link

Monaco Editor Playground Code

monaco.editor.defineTheme("myCustomTheme", {
	base: "vs",
	inherit: true,
	rules: [],
	colors: {
		"editor.background": "#00000000",
                "focusBorder": '#ff0000',
	},
});

const value = `function hello() {
	alert('Hello world!');
}`;

const myEditor = monaco.editor.create(document.getElementById("container"), {
	value,
	language: "javascript",
	theme: 'myCustomTheme',
});

Reproduction Steps

Set the editor.background to a transparent value and you should be able to see the border around the editor.

Actual (Problematic) Behavior

There is always a focus border around the editor

Expected Behavior

There shouldn't be a focus border around the editor

Additional Context

The issue was first introduced in v0.46.0. Specifically this commit seems to be the culprit.

@CGNonofr
Copy link
Contributor

CGNonofr commented Apr 26, 2024

It also happens when zooming out
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants