Fix focus border around editors with transparent background #209368
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KurtGokhan
changed the title
CGNonofr
reviewed
Apr 26, 2024
| .monaco-diff-editor input[type=search]:focus, | ||
| .monaco-diff-editor input[type=text]:focus, | ||
| .monaco-diff-editor select:focus, | ||
| .monaco-diff-editor textarea:focus { |
There was a problem hiding this comment.
Why are you ignoring the non-diff editors? shouldn't it be something like
.monaco-editor .synthetic-focus, .monaco-diff-editor .synthetic-focus,
.monaco-editor [tabindex="0"]:focus,, .monaco-diff-editor [tabindex="0"]:focus,
.monaco-editor [tabindex="-1"]:focus, .monaco-diff-editor [tabindex="-1"]:focus,
...?
There was a problem hiding this comment.
I don't know the initial intention behind the change. So can't tell for sure. @hediet can you chime in?
There was a problem hiding this comment.
I have the feeling what was attempted was (.monaco-editor, .monaco-diff-editor) .synthetic-focus, which unfortunately doesn't exist in css
There was a problem hiding this comment.
The issue that was fixed was about the diff editor. That is why I think .monaco-editor isn't relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/monaco-editor#4455