.eslintrc-with-ts-config.js

@@ -0,0 +1,15 @@
+module.exports = {
+  extends: "./.eslintrc.js",
+  parserOptions: {
+    ecmaVersion: 9,
+    sourceType: "module",
+    project: "./tsconfig.json",
+  },
+  rules: {
+    "@typescript-eslint/no-base-to-string": "error",
+    "@typescript-eslint/no-unnecessary-boolean-literal-compare": 2,
+  },
+  parserOptions: {
+    project: "./tsconfig.json"
+  },
+};

.eslintrc.js

@@ -4,7 +4,6 @@ module.exports = {
     parserOptions: {
       ecmaVersion: 9,
       sourceType: "module",
-      project: "./tsconfig.json",
     },
     extends: [
       "plugin:react-hooks/recommended"
@@ -49,6 +48,7 @@ module.exports = {
         "arrow-parens": [2, "as-needed"],
         "prefer-const": 2,
         "quote-props": [2, "consistent"],
+        "nonblock-statement-body-position": [2, "below"],
 
         // anti-patterns
         "no-var": 2,

.github/actions/download-artifact/action.yml

@@ -4,12 +4,10 @@ inputs:
   namePrefix:
     description: 'Name prefix of the artifacts to download'
     required: true
-    type: string
     default: 'blob-report'
   path:
     description: 'Directory with downloaded artifacts'
     required: true
-    type: string
     default: '.'
 runs:
   using: "composite"

.github/actions/download-blob-report-from-azure/action.yml

@@ -4,16 +4,13 @@ inputs:
   blob_prefix:
     description: 'Name of the Azure blob storage directory containing blob report'
     required: true
-    type: string
   output_dir:
     description: 'Output directory where downloaded blobs will be stored'
     required: true
-    type: string
     default: 'blob-report'
   connection_string:
     description: 'Azure connection string'
     required: true
-    type: string
 runs:
   using: "composite"
   steps:

.github/actions/upload-blob-report/action.yml

@@ -4,29 +4,30 @@ inputs:
   report_dir:
     description: 'Directory containing blob report'
     required: true
-    type: string
     default: 'test-results/blob-report'
   job_name:
     description: 'Unique job name'
     required: true
-    type: string
     default: ''
 runs:
   using: "composite"
   steps:
+    - name: Integrity check
+      shell: bash
+      run: find "${{ inputs.report_dir }}" -name "*.zip" -exec unzip -t {} \;
     - name: Upload blob report to GitHub
-      if: always() && github.event_name == 'pull_request'
+      if: ${{ !cancelled() && github.event_name == 'pull_request' }}
       uses: actions/upload-artifact@v4
       with:
         name: blob-report-${{ inputs.job_name }}
         path: ${{ inputs.report_dir }}/**
         retention-days: 7
     - name: Write triggering pull request number in a file
-      if: always() && github.event_name == 'pull_request'
+      if: ${{ !cancelled() && github.event_name == 'pull_request' }}
       shell: bash
       run: echo '${{ github.event.number }}' > pull_request_number.txt;
     - name: Upload artifact with the pull request number
-      if: always() && github.event_name == 'pull_request'
+      if: ${{ !cancelled() && github.event_name == 'pull_request' }}
       uses: actions/upload-artifact@v4
       with:
         name: pull-request-${{ inputs.job_name }}

.github/workflows/cherry_pick_into_release_branch.yml

@@ -12,6 +12,9 @@ on:
         description: Comma-separated list of commit hashes to cherry-pick
         required: true
 
+permissions:
+  contents: write
+
 jobs:
   roll:
     runs-on: ubuntu-22.04

.github/workflows/publish_release_npm.yml

@@ -25,10 +25,10 @@ jobs:
     - run: npm run build
     - run: npx playwright install-deps
     - run: utils/publish_all_packages.sh --release-candidate
-      if: "github.event.release.prerelease"
+      if: ${{ github.event.release.prerelease }}
       env:
         NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
     - run: utils/publish_all_packages.sh --release
-      if: "!github.event.release.prerelease"
+      if: ${{ !github.event.release.prerelease }}
       env:
         NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

.github/workflows/tests_electron.yml

@@ -42,7 +42,7 @@ jobs:
     - run: npm run etest
       if: matrix.os != 'ubuntu-latest'
     - run: node tests/config/checkCoverage.js electron
-      if: always() && matrix.os == 'ubuntu-latest'
+      if: ${{ !cancelled() && matrix.os == 'ubuntu-latest' }}
     - run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json
-      if: always()
+      if: ${{ !cancelled() }}
       shell: bash

.github/workflows/tests_primary.yml

@@ -55,13 +55,13 @@ jobs:
         PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
     - run: npm run build
     - run: npx playwright install --with-deps ${{ matrix.browser }} chromium
-    - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run test -- --project=${{ matrix.browser }}
+    - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run test -- --project=${{ matrix.browser }}-*
     - run: node tests/config/checkCoverage.js ${{ matrix.browser }}
     - run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json
-      if: always()
+      if: ${{ !cancelled() }}
       shell: bash
     - name: Upload blob report
-      if: always()
+      if: ${{ !cancelled() }}
       uses: ./.github/actions/upload-blob-report
       with:
         report_dir: blob-report
@@ -87,15 +87,15 @@ jobs:
         PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
     - run: npm run build
     - run: npx playwright install --with-deps chromium-tip-of-tree
-    - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run test -- --project=chromium
+    - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run test -- --project=chromium-*
       env:
         PWTEST_CHANNEL: chromium-tip-of-tree
         PWTEST_BOT_NAME: "${{ matrix.os }}-chromium-tip-of-tree"
     - run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json
-      if: always()
+      if: ${{ !cancelled() }}
       shell: bash
     - name: Upload blob report
-      if: always()
+      if: ${{ !cancelled() }}
       uses: ./.github/actions/upload-blob-report
       with:
         report_dir: blob-report
@@ -145,10 +145,10 @@ jobs:
     - run: xvfb-run npm run ttest --  --shard ${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
       if: matrix.os == 'ubuntu-latest'
     - run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json
-      if: always()
+      if: ${{ !cancelled() }}
       shell: bash
     - name: Upload blob report
-      if: always()
+      if: ${{ !cancelled() }}
       uses: ./.github/actions/upload-blob-report
       with:
         report_dir: blob-report
@@ -172,18 +172,18 @@ jobs:
       env:
         PWTEST_BOT_NAME: "web-components-html-reporter"
     - name: Upload blob report
-      if: always()
+      if: ${{ !cancelled() }}
       uses: ./.github/actions/upload-blob-report
       with:
         report_dir: packages/html-reporter/blob-report
         job_name: "web-components-html-reporter"
 
     - run: npm run test-web
-      if: always()
+      if: ${{ !cancelled() }}
       env:
         PWTEST_BOT_NAME: "web-components-web"
     - name: Upload blob report
-      if: always()
+      if: ${{ !cancelled() }}
       uses: ./.github/actions/upload-blob-report
       with:
         report_dir: packages/web/blob-report
@@ -219,7 +219,7 @@ jobs:
       run: npm run test -- --workers=1
       working-directory: ./playwright-vscode
     - name: Upload blob report
-      if: always()
+      if: ${{ !cancelled() }}
       uses: ./.github/actions/upload-blob-report
       with:
         report_dir: playwright-vscode/blob-report
@@ -255,10 +255,10 @@ jobs:
     - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run itest
       if: matrix.os == 'ubuntu-latest'
     - run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json
-      if: always()
+      if: ${{ !cancelled() }}
       shell: bash
     - name: Upload blob report
-      if: always()
+      if: ${{ !cancelled() }}
       uses: ./.github/actions/upload-blob-report
       with:
         report_dir: blob-report