Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] trace viewer crashes when trace contains an invalid selector #21894

Closed
1 task done
DetachHead opened this issue Mar 23, 2023 · 2 comments
Closed
1 task done

[BUG] trace viewer crashes when trace contains an invalid selector #21894

DetachHead opened this issue Mar 23, 2023 · 2 comments

Comments

@DetachHead
Copy link
Contributor

System info

  • Playwright Version: 1.30.0
  • Operating System: windows 10
  • Browser: firefox, chromium

Source code

  • I provided exact source code that allows reproducing the issue locally.

Config file

// playwright.config.ts
import type { PlaywrightTestConfig } from '@playwright/test'

const config: PlaywrightTestConfig = {
    use: {
        trace: 'on'
    },
}

export default config

Test file (self-contained)

import { test } from '@playwright/test'

test('page loads', async ({ page }) => {
    await page.goto('https://google.com')
    await page.waitForSelector('/')
})

Steps

  • run test
  • run playwright show-trace with the path to the trace file or upload it to trace.playwright.dev

Expected

trace file loads, with some sort of handling on the step with the invalid selector

Actual

blank screen with errors in the console:
image

Uncaught (in promise) Error: Unexpected token "/" while parsing selector "/"
@Nav-2d
Copy link
Contributor

Nav-2d commented Mar 23, 2023

Maybe related: #21832

@DetachHead
Copy link
Contributor Author

looks like the same issue, closing this as a duplicate

@DetachHead DetachHead closed this as not planned Won't fix, can't repro, duplicate, stale Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants