New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Regarding CDP Session. #2484
Comments
^^ @JoelEinbinder a ts types bug? |
|
@JoelEinbinder yep thanks I wrote
and it works but can you let me know why it requires page argument when it is already given Thanks :) |
The page parameter is strange indeed, as is the requirement to cast to Edit: I stand corrected, this is not true. See #2484 (comment) |
@Niek Yea casting and additional page argument is not ergonomic . And the api to launch persistent and non persistent is so different i was so shocked :( |
@Niek this is not actually the case.
|
Apologies @aslushnikov, I assumed Playwright (just like Puppeteer) used CDP for FF now that it's built-in (and enabled in at least the nightly builds). But reading #1765 (comment) that's not the case until the CDP support in FF is more mature. |
I am converting all my puppeteer code which used to look like this.
https://github.com/shirshak55/scrapper-tools/blob/master/src/fastPage/index.ts#L113
So we went to docs and saw this
But now i am seeing error on typescript like this
Property newCDPSession doesn't exists on type BrowserContext
The text was updated successfully, but these errors were encountered: