Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(windows): don't spawn separate process for autolink-windows #1964

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix(windows): don't spawn separate process for autolink-windows #1964

merged 1 commit into from
Apr 15, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Apr 11, 2024 •
edited

Description

Don't spawn separate process for autolink-windows

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

cd example
yarn install-windows-test-app --use-nuget
yarn windows

Screenshots

image

@github-actions github-actions bot added platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: Windows This affects Windows platform: visionOS labels Apr 11, 2024
@tido64 tido64 force-pushed the tido/windows/invoke-autolink-directly branch 7 times, most recently from c0d4b72 to aefa4cd Compare April 11, 2024 13:34
Base automatically changed from tido/refactor-init to trunk April 11, 2024 15:08
@tido64 tido64 force-pushed the tido/windows/invoke-autolink-directly branch 6 times, most recently from 66e15e1 to 03b3673 Compare April 12, 2024 11:51
@tido64 tido64 force-pushed the tido/windows/invoke-autolink-directly branch from 03b3673 to 1e1646e Compare April 12, 2024 12:01
@tido64 tido64 marked this pull request as ready for review April 12, 2024 12:02
@tido64 tido64 merged commit bb7e43d into trunk Apr 15, 2024
30 checks passed
@tido64 tido64 deleted the tido/windows/invoke-autolink-directly branch April 15, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acoates-ms acoates-ms acoates-ms approved these changes

@kelset kelset Awaiting requested review from kelset kelset is a code owner

Assignees
No one assigned
Labels
platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: visionOS platform: Windows This affects Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tido64 @acoates-ms