Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align-deps: remove stale dependencies when upgrading react-native #1299

Open
tido64 opened this issue Mar 21, 2022 · 3 comments
Open

align-deps: remove stale dependencies when upgrading react-native #1299

tido64 opened this issue Mar 21, 2022 · 3 comments
Labels
enhancement New feature or request feature: align-deps This is related to align-deps Help Wanted :octocat: Issues ideal for external contributors.

Comments

@tido64
Copy link
Member

tido64 commented Mar 21, 2022 •
edited

align-deps should remove stale dependencies when upgrading react-native.

For instance, @react-native-community/async-storage was renamed to @react-native-async-storage/async-storage some time ago. When people are upgrading from 0.63 to 0.64, we resolve the storage capability to @react-native-async-storage/async-storage, but do not remove @react-native-community/async-storage.
@tido64 tido64 added enhancement New feature or request feature: align-deps This is related to align-deps labels Mar 21, 2022
@tido64 tido64 mentioned this issue Mar 21, 2022
Closed
@afoxman afoxman added needs triage 🔍 bug Something isn't working and removed enhancement New feature or request needs triage 🔍 labels May 31, 2022
@afoxman
Copy link
Contributor

afoxman commented May 31, 2022

When doing this, consider making a list of "known deprecated" dependencies that should be removed and storing that per profile. Each profile successively builds on the previous profile's list. That way, if you've left 0.63 and 0.64 behind a long time ago, and you upgrade to 0.68, you still get the cleanup which removes the now-defunct @react-native-community/aync-storage.

@rohanprasadofficial
Copy link

@afoxman @tido64 , Is someone already investigating it ? if not , can I take this up and investigate on it.

@tido64 tido64 assigned rohanprasadofficial and unassigned tido64 Aug 23, 2022
@tido64
Copy link
Member Author

tido64 commented Aug 23, 2022

It's all yours 😄

@tido64 tido64 changed the title dep-check: remove stale dependencies when upgrading react-native align-deps: remove stale dependencies when upgrading react-native Nov 11, 2022
@tido64 tido64 added enhancement New feature or request and removed bug Something isn't working labels Jan 12, 2023
@kelset kelset added the Help Wanted :octocat: Issues ideal for external contributors. label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature: align-deps This is related to align-deps Help Wanted :octocat: Issues ideal for external contributors.
Projects
rnx-kit
Status: 🌳 Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tido64 @afoxman @kelset @rohanprasadofficial