Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Allow custom commands with pass-through parameters #4492

Open
Faithfinder opened this issue Jan 24, 2024 · 5 comments
Open

[rush] Allow custom commands with pass-through parameters #4492

Faithfinder opened this issue Jan 24, 2024 · 5 comments
Labels
effort: easy Probably a quick fix. Want to contribute? :-) help wanted If you're looking to contribute, this issue is a good place to start!

Comments

@Faithfinder
Copy link
Contributor

I'm trying to integrate knip in our rush repo, and while it's mostly going fine, the custom command I'm using to invoke it is just knip. I would like to be able to pass in any of knip's CLI arguments to it when I invoke, and listing them manually seems like a crazy exercise.

@iclanton
Copy link
Member

It'd be possible to add an option in command-line.json to allow "remainder" parameters to be passed to a bulk process. ts-command-line supports this, but it isn't exposed in Rush.

Would you be interested in adding this feature?

@iclanton iclanton added help wanted If you're looking to contribute, this issue is a good place to start! effort: easy Probably a quick fix. Want to contribute? :-) labels Jan 31, 2024
@Faithfinder
Copy link
Contributor Author

Meh, maybe. I have very little time/energy to spend on open source, but inspiration could struck and this sounds like it wouldn't take more than an hour. Can you point to a good file to start with for me or whoever takes this?

@Faithfinder
Copy link
Contributor Author

(BTW, the command is global, not bulk, but I imagine it can be implemented and useful for both)

@cubabit
Copy link

cubabit commented May 7, 2024

@Faithfinder can you please share your config setup to integrate knip with rush? Did you use a rush command? Did you have a single knip config file?

@Faithfinder
Copy link
Contributor Author

@Faithfinder can you please share your config setup to integrate knip with rush? Did you use a rush command? Did you have a single knip config file?

Single file, yes, but I can't share the config as I'm not in that job anymore. Wasn't anything tricky, just ignore rush's config folders and expand entry files in individual projects as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: easy Probably a quick fix. Want to contribute? :-) help wanted If you're looking to contribute, this issue is a good place to start!
Projects
Status: Low priority
Development

No branches or pull requests

3 participants