Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake Tools Language Services - Colorization #3559

Open
gcampbell-msft opened this issue Feb 1, 2024 · 4 comments
Open

CMake Tools Language Services - Colorization #3559

gcampbell-msft opened this issue Feb 1, 2024 · 4 comments
Assignees
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: language services
Milestone

Comments

@gcampbell-msft
Copy link
Collaborator

Brief Issue Summary

Add support for a textmate grammar to add colorization for CMakeLists.txt and other relevant, applicable files.

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

No response

@gcampbell-msft gcampbell-msft self-assigned this Feb 1, 2024
@github-actions github-actions bot added the triage label Feb 1, 2024
@gcampbell-msft gcampbell-msft added this to the 1.18 milestone Feb 1, 2024
@gcampbell-msft gcampbell-msft added enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: language services and removed triage labels Feb 1, 2024
@gcampbell-msft
Copy link
Collaborator Author

Overrarching topic issues: #534 #93

@calebnwokocha
Copy link

calebnwokocha commented Apr 8, 2024

{ "scopeName": "source.cmake", "fileTypes": ["CMakeLists.txt"], "patterns": [ { "name": "comment.line.number-sign.cmake", "match": "#.*$" }, { "name": "keyword.control.cmake", "match": "\\b(if|else|endif|foreach|endforeach|while|function)\\b" }, { "name": "keyword.other.cmake", "match": "\\b(add_executable|add_library|target_link_libraries|include_directories|link_directories)\\b" }, { "name": "constant.numeric.cmake", "match": "\\b[0-9]+\\b" }, { "name": "string.quoted.double.cmake", "begin": "\"", "end": "\"", "patterns": [ { "name": "constant.character.escape.cmake", "match": "\\\\." } ] } ] }
This JSON snippet defines a simple TextMate grammar for CMakeLists.txt files. It includes basic patterns for comments, keywords, numeric constants, and double-quoted strings.

@gcampbell-msft
Copy link
Collaborator Author

@calebnwokocha Thanks. We are in the midst of working on bringing cmake tools colorization into CMake Tools, we have a partial implementation for our language services targeting 1.18 here: #3679

@gcampbell-msft gcampbell-msft added the fixed (release pending) fixed in pre-release and is pending official release label Apr 18, 2024
@gcampbell-msft
Copy link
Collaborator Author

All, I removed the fixed (release pending) tag. This is due to the fact that we were not able to implement quick info in time for the 1.18 release and we don't want a drop in functionality from previous releases. We hope to merge these changes back into pre-release when available.

@gcampbell-msft gcampbell-msft removed the fixed (release pending) fixed in pre-release and is pending official release label May 10, 2024
@gcampbell-msft gcampbell-msft modified the milestones: 1.18, On Deck May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: language services
Projects
Status: Completed
Development

No branches or pull requests

2 participants