Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide all non-error messages when quiet mode is enabled #1804

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Hide all non-error messages when quiet mode is enabled #1804

wants to merge 1 commit into from

Conversation

Woodz
Copy link

@Woodz Woodz commented Mar 11, 2024

Change logic to hide all non-error messages instead of only hiding warn level messages (which missed info level messages)

Resolve #1803

@Woodz
Hide all non-error messages when quiet mode is enabled
159cf85 
Change logic to hide all non-error messages instead of only hiding warn level messages (which missed info level messages)
@dbaeumer
Copy link
Member

Thanks for the PR. We should update the settings message as well here:

vscode-eslint/package.json

Line 158 in 4b16b71

"description": "Turns on quiet mode, which ignores warnings."
to make the clear in the doc.

dbaeumer
dbaeumer requested changes Mar 12, 2024
View reviewed changes
Copy link
Member

@dbaeumer dbaeumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See latest comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaeumer dbaeumer dbaeumer requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eslint.quiet should hide info level eslint rules as well
2 participants
@Woodz @dbaeumer