Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: show notification when ESLint fails to load #1807

Open
OliverJAsh opened this issue Mar 13, 2024 · 5 comments
Open

Feature request: show notification when ESLint fails to load #1807

OliverJAsh opened this issue Mar 13, 2024 · 5 comments
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities
Milestone

Comments

@OliverJAsh
Copy link

OliverJAsh commented Mar 13, 2024

The status of ESLint is indicated in the status bar by the tiny x symbol:

image

This is very difficult to spot. I want to be alerted as soon as there's an issue. Could we send a notification when ESLint fails to load?

For context, I encounter these errors quite frequently because my ESLint config depends on custom rules that need to be built prior to ESLint running. A notification would serve as a useful reminder that I need to build my custom lint rules.

@dbaeumer
Copy link
Member

We had notifications in the past and move to language status since notifications are annoying if you open workspaces where you can't fix this. So if we bring notifications back it has to go behind a setting.

@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Mar 14, 2024
@dbaeumer dbaeumer added this to the Backlog milestone Mar 14, 2024
@dbaeumer dbaeumer added the help wanted Issues identified as good community contribution opportunities label Mar 14, 2024
@U-4-E-A
Copy link

U-4-E-A commented Mar 31, 2024

We had notifications in the past and move to language status since notifications are annoying if you open workspaces where you can't fix this. So if we bring notifications back it has to go behind a setting.

In terms of notifying, I find the way prettier does it more than suffices to draw the person's attention to the fact there is an issue, which can then be debugged in output.

image

@dbaeumer
Copy link
Member

dbaeumer commented Apr 2, 2024

VS Code's recommendation for something like this is to use a language status.

Image

If every extension has its own status indicator this will look very crowded.

@U-4-E-A
Copy link

U-4-E-A commented Apr 8, 2024

The user can select which indicators they wish to see? I would also consider eslint - along with prettier - to be perhaps the 2 most import for a developer to be able to monitor while working.

Also a split between soft errors (current file not included) and hard errors (eslint crashing/failing to configure) would very helpful.

@dbaeumer
Copy link
Member

dbaeumer commented Apr 8, 2024

Yes, the user can ping the ESLint indicator to the status line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

No branches or pull requests

3 participants