-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression after switching to pre-release - Eslint no longer loading against project files. #1839
Comments
I noticed the same behavior on the current release where Although eslint does attach to the file, there are simply no messages/diagnostics reported from the eslint server. |
@jludwiggreenaction do you have a repository I can clone that demos that. |
Sorry to make life difficult, @dbaeumer . For reference, below is a procedure to check out a commit to a named branch. It would have been easier if I provided you with a branch name alias already pushed rather than just the commit hash. git clone git@github.com:cefn/watchable.git
cd watchable
git checkout -b eslint-failure # for convenience
git fetch origin 03844d8468c9e88e6d6ef93a0e5e773ea4a69d60
git reset --hard 03844d8468c9e88e6d6ef93a0e5e773ea4a69d60 ...gets you to... commit 03844d8468c9e88e6d6ef93a0e5e773ea4a69d60 (HEAD -> eslint-failure)
Author: Cefn Hoile <github.com@cefn.com>
Date: Sun Apr 28 12:37:37 2024 +0100
Fix promise array typing. Update typescript, eslint For now I've pushed that commit to https://github.com/cefn/watchable/tree/eslint-failure so it's easier to check it out. |
@cefn still not able to reproduce. Here is what I see on branch |
Eslint was loaded and the files were successfully linted inline by the release version on the project using 8.57.0 and flat configs, if project paths were explicitly listed in the workspace
settings.json
.I upgraded to the pre-release version to try and get better support for eslint flat configs in the hope that
{mode:"auto"}
could be made to work. Unfortunately, the pre-release version fails to load Eslint or to show linting errors against files even with projects explicitly listed. The previously working workspacesettings.json
is below.I noted the requirement to switch from
"eslint.experimental.useFlatConfig": true
to"eslint.useFlatConfig": true
. Neither works to bring back eslint integration for the pre-release version of the eslint extension.The requirement to create configs with explicit paths is an unnecessary failure mode and is a productivity issue. On both release and pre-release the use of
[{mode:"auto"}]
to list the project paths was non-functional, in spite of all workspace globs being explicitly declared in the top-level package.json.You could prove eslint was previously loading against the files by clicking on the
{}
control at the bottom right of the VSCode editor, which showed eslint as one of the integrations, and also it was previously redlining linting errors in the source files of the explicitly-listed projects.My monorepo commit which recreates the failure is https://github.com/cefn/watchable/tree/03844d8468c9e88e6d6ef93a0e5e773ea4a69d60
The text was updated successfully, but these errors were encountered: