Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not linting markdown files #912

Closed
arvigeus opened this issue Mar 10, 2020 · 5 comments
Closed

Not linting markdown files #912

arvigeus opened this issue Mar 10, 2020 · 5 comments
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@arvigeus
Copy link

vscode-eslint version: 2.1.1
eslint version: 6.8.0
vscode version: 1.42.1

settings:

{
  "editor.codeActionsOnSave": {
    "source.fixAll": true
  },
  "javascript.validate.enable": false,
  "typescript.validate.enable": false,
  "eslint.lintTask.enable": true,
  "eslint.probe": [
    "javascript",
    "javascriptreact",
    "typescript",
    "typescriptreact",
    "html",
    "vue",
    "markdown",
    "md"
  ]
}

file.md (note: there is a zero-width whitespace in this code sample to "escape" the backticks)

​```js
let x;
if ((x = 0)) { }
​```

Running eslint (with markdown plugin installed) correctly displays warnings, but editor shows nothing.

@dbaeumer
Copy link
Member

@arvigeus can you please provide me with a GitHub repository I can clone that demos what you are experiencing.

@dbaeumer dbaeumer added the info-needed Issue requires more information from poster label Mar 10, 2020
@arvigeus
Copy link
Author

arvigeus commented Mar 11, 2020

https://github.com/arvigeus/eslint-markdown-issue

npm run lint works as expected. The errors are not shown in the editor when file.md is open. eslint.probe is set to markdown and md

@dbaeumer
Copy link
Member

Actually, probing for markdown is not working correctly right now. You can force markdown linting using

  "eslint.validate": [
    "markdown",
    "md"
  ]

@dbaeumer dbaeumer added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Mar 12, 2020
@dbaeumer dbaeumer added this to the 2.2.0 milestone Mar 12, 2020
@arvigeus
Copy link
Author

You can deprecate probe in the future: eslint/eslint#10828

@dbaeumer
Copy link
Member

I don't think so. What I want to avoid is that I load eslint extension and server for files that can definitely not be linted by ESLint (for example java).

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants