Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please improve setup instructions regarding peer dependencies #159

Closed
jayu opened this issue Jul 1, 2023 · 2 comments
Closed

Please improve setup instructions regarding peer dependencies #159

jayu opened this issue Jul 1, 2023 · 2 comments

Comments

@jayu
Copy link

jayu commented Jul 1, 2023

I've tried to setup version 0.8.0, then 0.7.7 and then 0.6.2 and encountered a problem with two dependencies.

I bundle my extension with Webpack, and these two deps were missing after installing @vscode/extension-telemetry

  • applicationinsights-native-metrics (peer dep of @vscode/extension-telemetry)
  • @azure/functions-core (dep of applicationinsights)

I've disabled resolving those deps in webpack config and I've managed to make the integration with Azure Applications Insights work.

But now I'm not sure

  • Can I release my extension and don't worry about those missing packages breaking something
  • Why the reporting works without those packages
@lramos15
Copy link
Member

lramos15 commented Jul 5, 2023

Similar to #150

@jayu
Copy link
Author

jayu commented Jul 5, 2023

Ah this is a duplicate, I didn't search for similar issue. I will close this one

@jayu jayu closed this as not planned Won't fix, can't repro, duplicate, stale Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lramos15 @jayu