Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional optOut key #54

Open
aeisenberg opened this issue Oct 7, 2020 · 1 comment
Open

Add additional optOut key #54

aeisenberg opened this issue Oct 7, 2020 · 1 comment
Labels
good first issue Issues that are easily implemented for newcomers to the project help wanted Issues identified as good community contribution opportunities

Comments

@aeisenberg
Copy link
Contributor

This is a feature request to add an additional, optional optOut key. My understanding is that the recommended way to use this extension is to ensure two configuration options are enabled before sending any telemetry. The first one is the global telemetry.telemetryEnabled option and the second one is specific to your extension. This enables someone to opt out of your telemetry while still opting in to vscode's global telemetry.

My proposal is to add an extra optional string parameter to the TelemetryReporter constructor. This parameter points to a config option that must also be enabled in order for telemetry to be sent.

The change is fairly straight forward and I'm happy to submit a PR if you think this is a reasonable direction to go.

@lramos15
Copy link
Member

This does sound interesting but I'm not sure if optOut is the best word since we have telemetryEnabled where true is enabled and false isn't. Where optOut makes it sound like true is disabled and false isn't. How do extensions go about deciding which way their switch goes?

@lramos15 lramos15 added help wanted Issues identified as good community contribution opportunities good first issue Issues that are easily implemented for newcomers to the project labels Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that are easily implemented for newcomers to the project help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

No branches or pull requests

2 participants