Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR files should be sorted "naturally", like VS Code file explorer #5835

Open
jakebailey opened this issue Mar 14, 2024 · 2 comments
Open

PR files should be sorted "naturally", like VS Code file explorer #5835

jakebailey opened this issue Mar 14, 2024 · 2 comments
Assignees
@alexr00
Labels
feature-request Request for new features or functionality polish
Milestone
June 2024

Comments

@jakebailey
Copy link
Member

Steps to Reproduce:

  1. Open a PR containing files with numbers in them
  2. Observe the file list.

The PR viewer says:

image

But VS Code says:

image

Which is nicer.
@alexr00 alexr00 added feature-request Request for new features or functionality polish labels Mar 26, 2024
@alexr00 alexr00 added this to the April 2024 milestone Mar 26, 2024
@alexr00 alexr00 self-assigned this Mar 26, 2024
@alexr00
Copy link
Member

alexr00 commented Apr 22, 2024

@lramos15 could you point me to how the explorer sorts files?

@alexr00 alexr00 modified the milestones: April 2024, May 2024 Apr 22, 2024
@lramos15
Copy link
Member

It's a bit complex as a lot of settings back it

https://github.com/microsoft/vscode/blob/5b6444d082b6ab25a7c301e55a26d4701722d783/src/vs/workbench/contrib/files/browser/views/explorerViewer.ts#L937-L1062

@alexr00 alexr00 modified the milestones: May 2024, June 2024 May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
feature-request Request for new features or functionality polish
Projects
None yet
Milestone
June 2024
Development

No branches or pull requests
3 participants
@lramos15 @jakebailey @alexr00