Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python_files/testing_tools/unittest_discovery.py has a Tornado hack w/ no reference to an issue to replace the hack #23050

Open
brettcannon opened this issue Mar 11, 2024 · 1 comment
Assignees
Labels
triage-needed Needs assignment to the proper sub-team

Comments

@brettcannon
Copy link
Member

def get_sourceline(obj):
try:
s, n = inspect.getsourcelines(obj)
except:
try:
# this handles `tornado` case we need a better
# way to get to the wrapped function.
# This is a temporary solution
s, n = inspect.getsourcelines(obj.orig_method)
except:
return "*"

Those bare except statements are also extremely broad.

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Mar 11, 2024
@brettcannon brettcannon changed the title python_files/testing_tools/unittest_discovery.py has a Tornado hack w/ no reference to a file python_files/testing_tools/unittest_discovery.py has a Tornado hack w/ no reference to an issue to replace the hack Mar 12, 2024
@eleanorjboyd
Copy link
Member

this code will no longer be used once the test rewrite is finished and the old code is deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage-needed Needs assignment to the proper sub-team
Projects
None yet
Development

No branches or pull requests

2 participants