Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have CI coverage require other tests passing #23052

Open
brettcannon opened this issue Mar 12, 2024 · 0 comments
Open

Have CI coverage require other tests passing #23052

brettcannon opened this issue Mar 12, 2024 · 0 comments
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue needs PR Ready to be worked on

Comments

@brettcannon
Copy link
Member

There's no needs clause on coverage in PR CI, which means if the tests are definitely going to fail then they will fail twice: once for the normal test run and then again when run under coverage. Either coverage should be the way to run those tests so they aren't run twice or coverage should probably not run if the test suite failed.
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Mar 12, 2024
@karthiknadig karthiknadig added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on good first issue area-internal Label for non-user facing issues and removed triage-needed Needs assignment to the proper sub-team labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue needs PR Ready to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettcannon @karthiknadig