Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOOGLE_API_KEY no longer needs to be excluded from the environment #112683

Closed
matttilton opened this issue Dec 16, 2020 · 2 comments
Closed

GOOGLE_API_KEY no longer needs to be excluded from the environment #112683

matttilton opened this issue Dec 16, 2020 · 2 comments
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@matttilton
Copy link

The environment variable GOOGLE_API_KEY was added to the blocklist 3 years ago in order to fix #32213. At the time electron provided a default value for this environment variable Electron 1.7.6 Documentation and this caused unexpected behavior. Since then, electron has stopped providing a default value and now expects users to supply their own key Electron 11.1.0 Documentation. This is a minor annoyance that forces me to either run my code outside of the integrated terminal or rename my environment variable.

Inside integrated terminal
image

Outside
image

@deepak1556
Copy link
Contributor

Yeah electron no longer sets a default electron/electron#15478 , we can remove it from the blocklist

/^GOOGLE_API_KEY$/,

@meganrogge meganrogge added this to the January 2021 milestone Dec 17, 2020
@meganrogge meganrogge added the author-verification-requested Issues potentially verifiable by issue author label Dec 17, 2020
@github-actions
Copy link

This bug has been fixed in to the latest release of VS Code Insiders!

@matttilton, you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text /verified to let us know. If not, please ensure you're on version c8aaeb7 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author-verification-requested Issues potentially verifiable by issue author insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

No branches or pull requests

4 participants
@deepak1556 @matttilton @meganrogge and others