Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major ergonomics issues with RxJS v7 and VS Code auto imports #119007

Closed
benlesh opened this issue Mar 15, 2021 · 1 comment
Closed

Major ergonomics issues with RxJS v7 and VS Code auto imports #119007

benlesh opened this issue Mar 15, 2021 · 1 comment
Assignees
@mjbvz
Labels
*duplicate Issue identified as a duplicate of another issue(s) typescript Typescript support issues upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@benlesh
Copy link

benlesh commented Mar 15, 2021

  • VS Code Version: any
  • OS Version: any

Steps to Reproduce:

  1. Create a project and install npm rxjs@7.0.0-beta.13 or rxjs@next.
  2. Type something like mergeMap and let auto-import do it's thing.
  3. Observe that the added import is not from rxjs/operators, rather from rxjs/dist/types/operators, which is really incorrect.

Does this issue occur when all extensions are disabled?: Yes

There is additional discussion of the problem here: ReactiveX/rxjs#6067

We're uncertain what we can do about it, but it's definitely a bad UX we want to fix as soon as we can.
@mjbvz
Copy link
Contributor

mjbvz commented Mar 15, 2021

Duplicate of microsoft/TypeScript#43034

@mjbvz mjbvz marked this as a duplicate of microsoft/TypeScript#43034 Mar 15, 2021
@mjbvz mjbvz closed this as completed Mar 15, 2021
@mjbvz mjbvz added *duplicate Issue identified as a duplicate of another issue(s) typescript Typescript support issues upstream-issue-linked This is an upstream issue that has been reported upstream labels Mar 15, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
*duplicate Issue identified as a duplicate of another issue(s) typescript Typescript support issues upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benlesh @mjbvz