Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop recommending Vetur for Vue v3+ #143531

Closed
zigomir opened this issue Feb 18, 2022 · 5 comments
Closed

Stop recommending Vetur for Vue v3+ #143531

zigomir opened this issue Feb 18, 2022 · 5 comments
Assignees
@isidorn
Labels
extension-recommendations Extension recommendations issues under-discussion Issue is under discussion for relevance, priority, approach
Milestone
April 2022

Comments

@zigomir
Copy link

zigomir commented Feb 18, 2022

Since Vue.js version 3, new recommended extension has been Volar.

It would be great if VSCode could take this into account and stop recommending Vetur in Vue 3 projects.
@zigomir zigomir mentioned this issue Feb 18, 2022
Closed
1 task
@isidorn isidorn transferred this issue from microsoft/vsmarketplace Feb 21, 2022
@isidorn isidorn added extension-recommendations Extension recommendations issues under-discussion Issue is under discussion for relevance, priority, approach and removed feedback labels Feb 21, 2022
@isidorn isidorn added this to the March 2022 milestone Feb 21, 2022
@isidorn
Copy link
Contributor

isidorn commented Feb 21, 2022

@zigomir thanks for filling this!
Currently we recommend based on .vue file type. So we do not really know what vue.js version is used.
Do you have some info how wide is version 3 adopted?
Would it be ok to recommend Volar extension for all Vue users?

Sorry but I do not use vue thus all the questions....

fyi @sandy081 @octref @hediet

@zigomir
Copy link
Author

zigomir commented Feb 21, 2022

I see. I don't have the info, but if I had to guess, v2 is still used more than v3.

About recommending Volar for Vue 2 (great question), it doesn't seem to be working out of the box based on the docs (look for Setup for Vue 2 details). I never used Volar and Vue 2 so am not best person to say. /cc @johnsoncodehk

I guess I hoped VSC knows what version of Vue is being used, but if not, then maybe it's too soon to change this 🤷‍♂️ and am sorry to waste anyone's time 😊

@isidorn
Copy link
Contributor

isidorn commented Mar 2, 2022

Then I suggest that we only update this recommendation in the future once v3 becomes more popular than v2.
Currently it would be weird for users using v2 to get an extension recommendation which does not work.

I am open for suggestions from the community here.

@isidorn isidorn modified the milestones: March 2022, Backlog Mar 2, 2022
@isidorn isidorn modified the milestones: Backlog, April 2022 Mar 11, 2022
@isidorn
Copy link
Contributor

isidorn commented Mar 11, 2022

We have decided to start recommending Volar instead of Vetur starting in April for insiders. Which means May for VS Code stable.
That should hopefully give more time for the vue community to transition to v3.

fyi @octref @johnsoncodehk

@isidorn
Copy link
Contributor

isidorn commented Mar 29, 2022 •
edited

This has been done, and you can try it out with VS Code insiders from Thursday. Let's see how it goes.
Created a follow up issue for @johnsoncodehk vuejs/language-tools#1124

@isidorn isidorn closed this as completed Mar 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
extension-recommendations Extension recommendations issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
April 2022
Development

No branches or pull requests
2 participants
@zigomir @isidorn