Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A white line at the top of the window on macOS Monterey #144389

Open
Eureka-0 opened this issue Mar 4, 2022 · 11 comments
Open

A white line at the top of the window on macOS Monterey #144389

Eureka-0 opened this issue Mar 4, 2022 · 11 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member macos Issues with VS Code on MAC/OS X polish Cleanup and polish issue titlebar VS Code main title bar issues
Milestone

Comments

@Eureka-0
Copy link

Eureka-0 commented Mar 4, 2022

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version:版本:
    1.65.0
    提交: b5205cc
    日期: 2022-03-02T11:13:50.741Z
    Electron: 13.5.2
    Chromium: 91.0.4472.164
    Node.js: 14.16.0
    V8: 9.1.269.39-electron.0
    OS: Darwin arm64 21.3.0

  • OS Version: macOS 12.2.1 (21D62)

Steps to Reproduce:

iShot2022-03-04 19 53 44

As long as the system is in light mode and vscode is in a dark theme, a white line will appear on the top of the vscode window. When the system switches to dark mode, it will disappear. This white line is really distracting. Hope you can fix this.

@bpasero
Copy link
Member

bpasero commented Mar 8, 2022

Not sure whether this may be from our custom title or a general Electron / OS issue.

@bpasero bpasero added the titlebar VS Code main title bar issues label Mar 8, 2022
@rzhao271 rzhao271 added the macos Issues with VS Code on MAC/OS X label Mar 10, 2022
@rzhao271
Copy link
Contributor

rzhao271 commented Mar 10, 2022

The issue reproduces in Big Sur on the Insiders and Exploration builds, as well as on Electron Fiddle, but not Microsoft Edge.

@deepak1556
Copy link
Contributor

@rzhao271 can you try with vscode PWA application.

@deepak1556 deepak1556 added the info-needed Issue requires more information from poster label Mar 14, 2022
@Eureka-0
Copy link
Author

image

@rzhao271 can you try with vscode PWA application.

I installed vscode PWA application from chrome, and there seems to be no white line.

@rzhao271
Copy link
Contributor

I have confirmed the issue has been in Electron since version 9.

@rzhao271 rzhao271 added confirmed Issue has been confirmed by VS Code Team member bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue and removed info-needed Issue requires more information from poster labels Mar 17, 2022
@meadowsys
Copy link

Can confirm. Also a few screenshots of how the borders look in light/dark mode, hoping they help (I think you can just about see the side borders):

image

image

I noticed that in dark mode, it becomes more of a uniform border along the edge of the whole window, whereas in light mode, the borders on the side and bottom are almost gone, and the border on the top (wrapping around the rounded corners a little) are significantly brighter

@sbatten sbatten removed their assignment Jul 12, 2022
@rzhao271 rzhao271 added this to the Backlog milestone Dec 6, 2022
@deepak1556 deepak1556 removed their assignment Dec 13, 2022
@hologerry
Copy link

Upvote for solving this issue.

@jhaemin
Copy link

jhaemin commented Jun 28, 2023

It's so annoying and catches my eyes every time I see the VSCode windows.

Maybe the issue is related to Electron and I think there are solutions for this.


Here are some Electron apps that resolve the white top border. They have light (no white) border surrounding the window, or even without border.

Here are some Electron apps that can toggle light/dark mode manually. And in dark mode (macOS light mode), they have light (no white) border surrounding the window which looks more natural.

Just like these apps, VSCode may fix this issue by applying dark mode border when using dark theme.

Cron (dark mode)

cron

Slack (dark mode)

slack

MongoDB Compass (dark mode)

compass

I'm not sure Figma is built on Electron, but they may resolve the issue by just removing the border like native apps. e.g.) Final Cut Pro, iTerm (screenshots below)

Figma

figma

I'm not sure Figma is built on Electron


Here are some Electron apps that also suffer from white top border like VSCode.

VSCode

vscode

Slack (light mode)

slack_light

GitKraken

gitkraken

Trello

trello

Notion

notion

Spark

spark

And lastly here are macOS native apps.

Clock

clock

Final Cut Pro

final_cut_pro

iTerm

iterm

KakaoTalk

kakaotalk

@bpasero
Copy link
Member

bpasero commented Jun 28, 2023

I am trying to reproduce the behaviour but for me VS Code (1.79.x) seems to show the same border color, irrespective if my macOS theme is set to dark or light?

Here are my results in both OS themes:

Screenshot 2023-06-28 at 12 59 02
Screenshot 2023-06-28 at 12 59 19

This is with macOS ventura 13.4.1 (22F82)

@jhaemin
Copy link

jhaemin commented Jun 28, 2023

That's weird. Here are what it looks like on my machine (27-inch, 4K). Are you using retina display? It looks like your screenshots are low resolutions. Maybe the antialiasing on your display makes the results look similar.

Light Mode

light

Dark Mode

dark

@bpasero
Copy link
Member

bpasero commented Jun 28, 2023

I am on a Dell U2515H with a resolution of 2560x1440.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member macos Issues with VS Code on MAC/OS X polish Cleanup and polish issue titlebar VS Code main title bar issues
Projects
None yet
Development

No branches or pull requests

10 participants