Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Can't always resize window #146060

Closed
joaomoreno opened this issue Mar 25, 2022 · 11 comments
Closed

Windows: Can't always resize window #146060

joaomoreno opened this issue Mar 25, 2022 · 11 comments
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author electron Issues and items related to Electron titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed verified Verification succeeded windows VS Code on Windows issues
Milestone

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Mar 25, 2022

Issue Type: Bug

Occasionally, when attempting to resize the window using the mouse, the window stays locked.

Recording 2022-03-25 at 16 06 37 (1)

VS Code version: Code - Insiders 1.66.0-insider (616cad0, 2022-03-25T08:25:04.070Z)
OS version: Windows_NT x64 10.0.22581
Restricted Mode: No

System Info
Item Value
CPUs AMD Ryzen 7 3700X 8-Core Processor (16 x 3593)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.92GB (22.71GB free)
Process Argv --crash-reporter-id 1bc8cd37-ce05-4987-927f-0e71eded00eb
Screen Reader no
VM 0%
Extensions (17)
Extension Author (truncated) Version
tsl-problem-matcher amo 0.5.0
better-toml bun 0.3.2
vscode-eslint dba 2.2.2
prettier-vscode esb 9.4.0
vscode-pull-request-github Git 0.39.2022032409
terraform has 2.21.0
javascript-notebooks joa 0.0.2
vscode-pyodide joy 0.0.11
remote-containers ms- 0.229.0
remote-ssh ms- 0.76.1
remote-ssh-edit ms- 0.76.1
azure-account ms- 0.10.1
vscode-github-issue-notebooks ms- 0.0.115
vscode-selfhost-test-provider ms- 0.3.9
vscode-typescript-tslint-plugin ms- 1.3.3
vscode-conventional-commits viv 1.24.0
gitblame wad 8.1.0

(1 theme extensions excluded)

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30422396
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscod805cf:30301675
pythonvspyt200:30323110
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30404738
wslgetstarted:30449409
vsclayoutctrt:30405800
pythonvspyt640:30438691
vscscmwlcmt:30428973
vscgsvid1:30433757
pynewfile477:30451556

@bpasero
Copy link
Member

bpasero commented Mar 25, 2022

Do I need new glasses, or is your title bar height increasing from left to right 🤔

@IllusionMH
Copy link
Contributor

OMG 🤯 That's nasty background and title bar content (sorry for offtopic)
image

@bpasero
Copy link
Member

bpasero commented Mar 25, 2022

Wow! I accept a PR to fix it ;)

@sbatten
Copy link
Member

sbatten commented Mar 25, 2022

It happens every two attempts to resize for me in OSS

@Spongman
Copy link

what's weird is that when it doesn't work it constrains the mouse cursor to within the bounds of the window.

@atom0s
Copy link

atom0s commented Mar 26, 2022

Have this issue on Windows 10 as well. Can't resize the window at all now since the latest update to the Insider build.

Double-clicking the window title does not work. Resizing attempts on any part of the window for me just lock the mouse to the windows current bounds. The minimize/maximize buttons still work though.

@deepak1556 deepak1556 added upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues electron Issues and items related to Electron titlebar VS Code main title bar issues upstream-issue-fixed The underlying upstream issue has been fixed labels Mar 26, 2022
@deepak1556 deepak1556 added this to the March 2022 milestone Mar 26, 2022
@deepak1556
Copy link
Contributor

Fixed with electron/electron#33438

deepak1556 added a commit that referenced this issue Mar 28, 2022
deepak1556 added a commit that referenced this issue Mar 28, 2022
@deepak1556
Copy link
Contributor

/closedWith 4599966

@deepak1556 deepak1556 added the author-verification-requested Issues potentially verifiable by issue author label Mar 28, 2022
@joaomoreno joaomoreno added the verified Verification succeeded label Mar 28, 2022
@hediet
Copy link
Member

hediet commented Mar 29, 2022

I can still reproduce with:

Version: 1.66.0
Commit: Unknown
Date: Unknown
Electron: 17.2.0
Chromium: 98.0.4758.109
Node.js: 16.13.0
V8: 9.8.177.11-electron.0
OS: Windows_NT x64 10.0.22000

Especially when resizing very slowly.

@hediet hediet reopened this Mar 29, 2022
@deepak1556
Copy link
Contributor

@hediet is this with OSS or insiders ? Please note, the issue is only addressed in our product builds and not OSS. Issue will be addressed in OSS once we update to 17.3.0 in main branch which is currently pending builds.

@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author electron Issues and items related to Electron titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

9 participants