[BUG] Window focus does not follow on command line code invocation

[jnooree]

Issue Type: Bug

Steps to reproduce

1. Open a workspace (let this A).
2. Open another workspace or directory (let this B) via code command line executable. For example, run as following command:

code --folder-uri /foo/bar

3. Visual studio code is focused as expected, but at the first workspace (A). It should instead "follow" focus and display workspace B, the newly opened one.

Additional context

• This bug still exists on Insiders build.
• This bug introduced in April 2022 version.

System information

VS Code version: Code 1.67.0 (57fd6d0, 2022-05-04T12:10:15.217Z)
OS version: Darwin arm64 21.4.0
Restricted Mode: No

System Info

Item	Value
CPUs	Apple M1 (8 x 24)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Load (avg)	5, 4, 3
Memory (System)	16.00GB (0.08GB free)
Process Argv	--crash-reporter-id 178a0318-7573-4c12-a505-f83a27d91f0f
Screen Reader	no
VM	0%

A/B Experiments

vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30443607
pythontb:30283811
pythonvspyt551:30345470
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
pythonvsnew555:30457759
vscscmwlcmt:30465135
cppdebug:30475216

[bpasero]

@jnooree are you possibly having the one window in fullscreen? Does it reproduce always?

[jnooree]

are you possibly having the one window in fullscreen?

No windows were in fullscreen mode.

Does it reproduce always?

Yes, it is not a transient (nor random) problem and still exists in v1.67.2.

[bpasero]

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

[jnooree]

I've found two points after some experiments:

• Both versions do not have problems in a freshly installed state, or even after extensions were installed.
• After updating my user settings, both versions reproduced the bug.

(Sorry for my mistake, this was edited.)

[bpasero]

Are you able to share your settings then with me?

[jnooree]

I'll figure out which setting is problematic and share it here in an hour.

[bpasero]

Cool thanks for doing that!

[jnooree]

Found it! It is related to this setting:

{
    "window.newWindowDimensions": "maximized"
}

It looks like vscode is trying to maximize the existing view again, after a new view is opened.

[jnooree]

FYI, I'm sure this bug is introduced between v1.66.2 - v1.67.0.

[bpasero]

Thanks, I believe I know what this is.

[bpasero]

/duplicate #149394

[VSCodeTriageBot]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!