1.67 regressed process creation with cwd, ENOENT error

[jeremie-stripe]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version:
  Version: 1.67.1 (Universal)
  Commit: da15b6f
  Date: 2022-05-06T12:37:16.526Z (1 wk ago)
  Electron: 17.4.1
  Chromium: 98.0.4758.141
  Node.js: 16.13.0
  V8: 9.8.177.13-electron.0
• OS Version:
  OS: Darwin x64 21.4.0

Steps to Reproduce:

The issue is reminiscent of #118267 which until 1.67 had not reappeared. The problem is similar to what is described in that original bug report with the same end result that trying to start a process with a command that's a relative path and setting a cwd on that process causes the syscall to return ENOENT.

Looking at recent changes that went into libuv/electron, I saw mention of a similar issue and related fix: libuv/libuv#3597 (comment)

[VSCodeTriageBot]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.67.1. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

[jeremie-stripe]

Testing with the current Insiders version this issue doesn't seem to appear:

Version: 1.68.0-insider (Universal)
Commit: 5f3e9c1
Date: 2022-05-17T05:18:39.842Z
Electron: 17.4.3
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Darwin x64 21.4.0

[jeremie-stripe]

cc @deepak1556 on the above, thanks!

[deepak1556]

Sorry for the breakage with stable release, upstream fix electron/electron#33870 landed in Electron 17.4.2 and insiders is currently on 17.4.3. Fix will be available with the 1.68 stable release.

/closedWith 624bbc4