Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different colored area on macOS #152816

Closed
lramos15 opened this issue Jun 22, 2022 · 34 comments
Closed

Different colored area on macOS #152816

lramos15 opened this issue Jun 22, 2022 · 34 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron electron-18-update macos Issues with VS Code on MAC/OS X upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@lramos15
Copy link
Member

Fired up vscode on my personal m1 mac for the first time in awhile.

Seeing discoloration in the rendering surrounding the area. I cannot see anything in the DOM that would explain this different colored section. I do not see this on my intel macbook which is settings synced to my M1 machine such that all extensions and settings are the same.

black box 1

black box 2

@deepak1556 I assigned you because I figured this might be an electron thing with rendering feel free to reassign or let me know how I may help debug.

@MitchLenton
Copy link

This happens to me with an intel mac as well. It was fixed by setting "disable-hardware-acceleration": true in the .vscode/argv.json file.

Specs
Intel MacBook Pro
macOS 12.2.1

@tillig
Copy link

tillig commented Jul 7, 2022

Issue #154387 was marked as a duplicate of this one, however, I do see the issue on an Intel MacBook. --disable-gpu stops the weird rendering from occurring.

@lramos15 lramos15 changed the title Different colored area on M1 Mac Different colored area on macOS Jul 7, 2022
@lramos15
Copy link
Member Author

lramos15 commented Jul 7, 2022

Issue #154387 was marked as a duplicate of this one, however, I do see the issue on an Intel MacBook. --disable-gpu stops the weird rendering from occurring.

I've renamed the issue to discuss both versions of macOS. The reason I named it M1 mac at first is I cannot repro this on my intel mac but can on my M1 machine

@A-Yaskevich
Copy link

Issue #154387 was marked as a duplicate of this one, however, I do see the issue on an Intel MacBook. --disable-gpu stops the weird rendering from occurring.

I've renamed the issue to discuss both versions of macOS. The reason I named it M1 mac at first is I cannot repro this on my intel mac but can on my M1 machine

I have Intel MAC, but facing the same problem

@deepak1556 deepak1556 added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) macos Issues with VS Code on MAC/OS X electron-18-update labels Jul 8, 2022
@deepak1556 deepak1556 pinned this issue Jul 8, 2022
@deepak1556
Copy link
Contributor

Very likely a regression in the disable color correct rendering patch maintained by electron. Confirmation pending.

@Kyngo
Copy link

Kyngo commented Jul 8, 2022

This happens to me with an intel mac as well. It was fixed by setting "disable-hardware-acceleration": true in the .vscode/argv.json file.

Specs Intel MacBook Pro macOS 12.2.1

I had this enabled and still can see this glitch. M1 Mac Mini here. Can confirm that running code --disable-gpu on terminal opens the editor without this glitch.

@hua03
Copy link

hua03 commented Jul 8, 2022

This happens to me with an intel mac as well. It was fixed by setting "disable-hardware-acceleration": true in the .vscode/argv.json file.
Specs Intel MacBook Pro macOS 12.2.1

I had this enabled and still can see this glitch. M1 Mac Mini here. Can confirm that running code --disable-gpu on terminal opens the editor without this glitch.

code --disable-gpu also works for me. I'm intel chip and macOS 10.15.6.

@jeremyn
Copy link

jeremyn commented Jul 8, 2022

Since upgrading to 1.69 I've also had problems with color, particularly blocks of color flickering between blue, magenta, or white when I highlight text, sometimes hiding some but not all of the text under the block I've highlighted.

Lots of issues have been redirected here as duplicates, however in my case I'm using Ubuntu 22.04. If my problem sounds like a duplicate of this issue then please update this issue's title so it doesn't say "macOS". Otherwise I can make a new issue. Thanks.

@weinand weinand unpinned this issue Jul 8, 2022
@its-codetime
Copy link

Both of the methods listed above did not work for me. I'm on an intel mac(monterey 12.2.1).
What did work is removing "disable-color-correct-rendering": true from ~/.vscode/argv.json file and restarting vscode. Now the different coloured patch on the side and bottom is gone.

@RickyRomero
Copy link

I've noticed a situation where this issue doesn't appear which may help the team debug it.

For me, this problem disappears when my Mac's display is set to the sRGB color profile (System Preferences > Displays > Display Settings... > Color Profile > sRGB IEC61966-2.1). After relaunching VS Code, the bug doesn't reappear.

So, it appears this issue is indeed related to mismatched color profiles somewhere in the rendering pipeline.

macOS Monterey 12.4 / Apple M1 Max / VS Code 1.69.0

⚠️ I don't recommend others use this as a solution, as it may prevent accurate color rendering across the entire OS.

@JackyChan
Copy link

Had the same problem on my M1 macbook air, I had to open the argv.json file (you can use Shift + CMD + P and type Configure Runtime Arguments to open it) and set this line to false :

"disable-color-correct-rendering": false

(it was on true, maybe by default).

After that, just close your VS Code instance with CMD + Q and restart it.

Awesome, work for me.

@eduard-ungureanu
Copy link

eduard-ungureanu commented Jul 25, 2022

None of the above options worked for me on a MacBook Air M1, except by editing the file ~/.vscode/argv.json and commenting out this line of code:

"disable-color-correct-rendering": true

The same can be achieved by setting the false value instead of true.

Code - argv json — Divi

@barrd
Copy link

barrd commented Aug 4, 2022

Fixed in 1.70.0 release Apple Mac, Intel macOS Monterey

@RickyRomero
Copy link

1.70.0 fixed it for me too!

@carlosbelardi
Copy link

carlosbelardi commented Aug 8, 2022

I'm still seeing super faded colors on 1.70.0 on my 16-inch M1 Mac. For context my theme is One Dark Pro Darker, and this is what my argv.json file looks like. I've tried other themes and it looks a bit better? So not super sure if the issue is with One Dark Pro

Screen Shot 2022-08-08 at 12 58 08 PM

Not sure how visible it is in these screenshots, but text that should be red looks almost like a rust orange, and the green and blue text also looks very dull/faded compared to how it was about a month ago.

Screen Shot 2022-08-08 at 1 00 23 PM

I first noticed this a few weeks ago, and adding "disable-hardware-acceleration": true to my argv.json file fixed it, but that's no longer the case

@Enubia
Copy link

Enubia commented Aug 12, 2022

I'm still seeing super faded colors on 1.70.0 on my 16-inch M1 Mac. For context my theme is One Dark Pro Darker, and this is what my argv.json file looks like. I've tried other themes and it looks a bit better? So not super sure if the issue is with One Dark Pro

Screen Shot 2022-08-08 at 12 58 08 PM

Not sure how visible it is in these screenshots, but text that should be red looks almost like a rust orange, and the green and blue text also looks very dull/faded compared to how it was about a month ago.

Screen Shot 2022-08-08 at 1 00 23 PM

I first noticed this a few weeks ago, and adding "disable-hardware-acceleration": true to my argv.json file fixed it, but that's no longer the case

Can confirm this behavior, at first glance everything seems fine but if you look close the colors are still messed up. It's just not as present as it was before the release that "fixed" it.

After setting "disable-hardware-acceleration": true it was fine again.
I removed the setting again and it stayed "fixed", at least for now.

Whatever's causing this, in my case disabling and enabling hardware-acceleration fixed it.

@jenky
Copy link

jenky commented Aug 18, 2022

I'm still seeing super faded colors on 1.70.0 on my 16-inch M1 Mac. For context my theme is One Dark Pro Darker, and this is what my argv.json file looks like. I've tried other themes and it looks a bit better? So not super sure if the issue is with One Dark Pro

Screen Shot 2022-08-08 at 12 58 08 PM

Not sure how visible it is in these screenshots, but text that should be red looks almost like a rust orange, and the green and blue text also looks very dull/faded compared to how it was about a month ago.

Screen Shot 2022-08-08 at 1 00 23 PM

I first noticed this a few weeks ago, and adding "disable-hardware-acceleration": true to my argv.json file fixed it, but that's no longer the case

I had the same issue, except that both "disable-hardware-acceleration" and "disable-color-correct-rendering" didn't work for me. Everything was fine in 1.68

@alxlacayo
Copy link

I'm also getting washed out colors on my late 2015 imac

@kydva
Copy link

kydva commented Sep 13, 2022

"disable-hardware-acceleration" and "disable-color-correct-rendering" didn't work for me too.

@deepak1556
Copy link
Contributor

Closing since this is addressed in 1.70 and higher, refs #152816 (comment)

We still have issues for P3 display which is tracked in #161028

@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron electron-18-update macos Issues with VS Code on MAC/OS X upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests