Test impacted extensions with Electron 22 and custom memory allocator

[bpasero]

Refs: #177338

• macOS: @rzhao271
• linux: @deepak1556 @isidorn
• windows: @bpasero

Complexity: 5

Create Issue

---

The new custom memory allocator in VS Code with Electron 22 should be tested to ensure:

• our top extensions continue to work as before
• extensions with known problematic native modules continue to work as before and do not crash VS Code

Prerequisites

Testing has to be done on (orange) VS Code exploration builds with Electron 22. Downloads:

• macOS: c49c0f16
• Windows: c49c0f16
• Linux: c49c0f16

Test Strategy

• do exploratory smoke testing of the extension triggering some of its functionality to verify it works
• see the native module the extension depends on to try to explicitly trigger the native code if possible
• limit testing to 5 minutes max, since there are many extensions to test
• watch out for extension host crashes or crashes in general

Test Problematic Extensions

All of the below extensions depend on a native module with a problematic memory allocation. Pick 1-3 extensions per native module to ensure coverage. Skip those that are obscure to test.

• samundrak.esdoc-mdn
  • uws
• litleleprikon.socket-io-vscode
  • uws
• sasxa-net.angular-gui
  • uws
• appcandev.appcanmaswin <- seems like an account is needed
  • uws
• lucasbento.react-native-actions
  • uws
• samundrak.esdoc-mdn
  • uws
• dkupco.viewx
  • uws
• litleleprikon.socket-io-vscode
  • uws
• lereenadem.pascalabcnet
  • tree-sitter
• appresso.navigateto
  • tree-sitter
• polarmutex.beancount-langserver
  • tree-sitter
• CJDNS.safepkt-verifier
  • tree-sitter
• ganezdragon.perl-language-server
  • tree-sitter
• GuanceCloud.platypus-vscode
  • tree-sitter
• Elmtooling.elm-ls-vscode
  • tree-sitter
• PenguinCabinet.writer-stock <- doesn't seem to work even on Insiders
  • canvas
• manhen.latex-workshop-2
  • canvas
• gregk.botbuilder
  • canvas
• NourEldeen.LiteGraph <- has a bunch of CSP problems
  • canvas
• FastAutomate.FastAutomateVisualise
  • canvas
• mdk.vega-preview
  • canvas
• mrakgr.spiral-lang-vscode
  • zeromq
• data-chimp.data-chimp
  • zeromq
• njpipeorgan.wolfram-language-notebook
  • zeromq
• appcandev.appcanmaswin
  • odbc
• ElbekVejrup.ev-business-central-dev-tool
  • odbc
• aliprodfmir.dfmir2
  • odbc
• zdldove.font-spider
  • ttf2woff2
• george.svg2font-extension <- on macOS, there's the console error "Invalid asm.js: Invalid member of stdlib"
  • ttf2woff2
• algo-sh.algo-sh
  • libpq
• uniquevision.vscode-plpgsql-lsp
  • libpq
• zat.vartrace
  • better-sqlite3
• widyhu.cpptips
  • better-sqlite3
• gustavofsantos.dat-dir
  • sodium-native
• m417z.regedit
  • native-reg

[rzhao271]

A bunch of the extensions don't seem to work, but I never had the entire exthost or Code - Exploration crash.

[deepak1556]

@rzhao271 to confirm, did you test with exploration build based on v22.4.2 ? the version in the screenshot above is invalid.

[isidorn]

I suggest to skip all extensions that have less < 500 installs.

[bpasero]

Had a hard time getting most of the extensions to work. RegEdit was really nice on Windows though ✔️

[rzhao271]

@rzhao271 to confirm, did you test with exploration build based on v22.4.2 ? the version in the screenshot above is invalid.

I tested with the linked commit SHA, which started with b.
Edit: It looks like the linked commit changed? I can test some extensions again following Isidor's advice.
Edit 2: Tested again with the linked commit SHA that starts with c. Same results as before. LGTM.

[deepak1556]

Thanks for confirming!