Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nondeterministic CodeWindow: detected unresponsive failure on Windows in CI #178241

Closed
pokey opened this issue Mar 24, 2023 · 3 comments
Closed
Assignees

Comments

@pokey
Copy link
Contributor

pokey commented Mar 24, 2023

Does this issue occur when all extensions are disabled?: ?

  • VS Code Version: 1.76.2
  • OS Version:
Operating System
  Microsoft Windows Server 2022
  10.0.20348
  Datacenter
Runner Image
  Image: windows-2022
  Version: 20230314.1
  Included Software: https://github.com/actions/runner-images/blob/win22/20230314.1/images/win/Windows2022-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/win22%2F20230314.1

Steps to Reproduce

In CI on Windows, we frequently get test failures with message CodeWindow: detected unresponsive. It is transient: rerunning the test usually fixes it

Below are a bad run and a good run, for comparison

❌ A bad run

See https://github.com/cursorless-dev/cursorless/actions/runs/4512412864/jobs/7945824269. The relevant portion is

Found --crash-reporter-directory argument. Setting crashDumps directory to be 'D:\a\cursorless\cursorless\artifacts\dumps'
Warning: 'disable-software-rasterizer' is not in the list of known options, but still passed to Electron/Chromium.
[main 2023-03-24T14:52:30.965Z] update#ctor - updates are disabled by the environment
[1888:0324/145231.463:ERROR:network_service_instance_impl.cc(470)] Network service crashed, restarting service.
workbench#open()
[main 2023-03-24T14:52:46.465Z] CodeWindow: detected unresponsive
Exit code:   1

✅ A good run

See https://github.com/cursorless-dev/cursorless/actions/runs/4512250535/jobs/7945440628. Here is the relevant portion:

Found --crash-reporter-directory argument. Setting crashDumps directory to be 'D:\a\cursorless\cursorless\artifacts\dumps'
Warning: 'disable-software-rasterizer' is not in the list of known options, but still passed to Electron/Chromium.
[main 2023-03-24T14:33:06.915Z] update#ctor - updates are disabled by the environment
workbench#open()
[main 2023-03-24T14:33:14.419Z] [UtilityProcess id: 1, type: extensionHost, pid: <none>]: creating new...
IExtensionHostStarter.start() took 5 ms.
[main 2023-03-24T14:33:14.456Z] [UtilityProcess id: 1, type: extensionHost, pid: 3532]: successfully created
Loading development extension at d:\a\cursorless\cursorless\packages\cursorless-vscode\dist
@rebornix rebornix assigned deepak1556 and unassigned rebornix Mar 27, 2023
pokey added a commit to cursorless-dev/cursorless that referenced this issue Jun 6, 2023
pokey added a commit to cursorless-dev/cursorless that referenced this issue Jun 6, 2023
pokey added a commit to cursorless-dev/cursorless that referenced this issue Jun 6, 2023
@pokey
Copy link
Contributor Author

pokey commented Jun 15, 2023

Any updates on this one? The network_service_instance_impl.cc(470)] Network service crashed, restarting service. workbench#open() error looks like maybe it's similar to electron/electron#31675?

github-merge-queue bot pushed a commit to cursorless-dev/cursorless that referenced this issue Jun 15, 2023
- Fixes #1363

## Checklist

- [x] Fails when test case legitimately fails
- [x] Retries when test case fails with "codewindow unresponsive"
- [x] Succeeds when test case succeeds
- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet
@deepak1556
Copy link
Contributor

We have had some runtime updates, can you confirm if this issue still persists with latest version ?

@deepak1556 deepak1556 added the info-needed Issue requires more information from poster label Dec 5, 2023
@pokey
Copy link
Contributor Author

pokey commented Dec 5, 2023

Fwiw it turned out that this appears to only occur when we ask for a crash dump. Removing flags in https://github.com/cursorless-dev/cursorless/pull/1515/files#diff-229802fa88c9cc039006534daa153d4a62e8bbbda74a72dfea59829b5450d753L67-L70 fixed the issue for us

I'd be fine to just close this one

@deepak1556 deepak1556 removed the info-needed Issue requires more information from poster label Dec 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants