Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.titleBarStyle should be native by default for SR users #204862

Open
meganrogge opened this issue Feb 9, 2024 · 4 comments
Open

window.titleBarStyle should be native by default for SR users #204862

meganrogge opened this issue Feb 9, 2024 · 4 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues titlebar VS Code main title bar issues

Comments

@meganrogge
Copy link
Contributor

@jooyoungseo has said that the native style is more accessible

@meganrogge meganrogge added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Feb 9, 2024
@benibenj benibenj assigned benibenj and unassigned bpasero Feb 9, 2024
@bpasero bpasero added the titlebar VS Code main title bar issues label Feb 10, 2024
@bpasero
Copy link
Member

bpasero commented Feb 10, 2024

I am not sure I would agree here: the native menu on Windows is not accessible, and that is actually why we initially implemented our own custom menu that checks of the accessible requirements. So if we go down this path we have to really make sure that the native menu on Windows is now accessible (it is possible that Electron improved it meanwhile).

//cc @deepak1556

@deepak1556
Copy link
Contributor

deepak1556 commented Feb 12, 2024

Electron improved the accessibility of menus on Windows via electron/electron#15302 which landed first in v5, @meganrogge please test and let me know if the native menu is not accessible with latest stable.

@meganrogge
Copy link
Contributor Author

I don't have access to windows atm, but was told by @jooyoungseo that the native menu is very accessible on windows

@jooyoungseo
Copy link

jooyoungseo commented Feb 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues titlebar VS Code main title bar issues
Projects
None yet
Development

No branches or pull requests

5 participants