Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing deb package dependencies when installing on Debian #21654

Closed
Tyriar opened this issue Mar 1, 2017 · 4 comments
Closed

Add missing deb package dependencies when installing on Debian #21654

Tyriar opened this issue Mar 1, 2017 · 4 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux verified Verification succeeded
Milestone
March 2017

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 1, 2017

https://news.ycombinator.com/item?id=13768705
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux labels Mar 1, 2017
@Tyriar Tyriar self-assigned this Mar 1, 2017
@intdel
Copy link

intdel commented Mar 1, 2017

Other dependencies that are missing are:
libasound2, libxss1, libgconf2.0

@Tyriar
Copy link
Member Author

Tyriar commented Mar 1, 2017

@intdel thanks, #13089 was tracking those (and more)

If they're blocking installation on Debian I'll try get it into the recovery build with this then. Are you using regular 64-bit Debian?

@Tyriar Tyriar changed the title Add apt-transport-https as a deb dependency Add missing deb package dependencies when installing on Debian Mar 1, 2017
@Tyriar Tyriar added this to the February Recovery 2017 milestone Mar 1, 2017
@intdel
Copy link

intdel commented Mar 1, 2017 •
edited

Yes, I am running Debian 64 bit testing. It doesn't block it but it will just give you an error when launching "code". Like "libxss.so missing" or something like that. So I have to install them manually.

Tyriar added a commit to microsoft/vscode-docs that referenced this issue Mar 2, 2017
@Tyriar
Install deb repo with http, not https
38eeeca 
Debian doesn't support this without installing the apt-transport-https
package. The download is secure enough due to the signing key (fetched
with https) so no man-in-the-middle attacks should happen.

Part of microsoft/vscode#21654
@Tyriar Tyriar closed this as completed in 4db944b Mar 2, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Mar 2, 2017

@intdel so turns out the right fix for this is to install the repository using the http protocol, not https. This appears to be how Debian's system packages are installed and since we have a signing key which is installed via https (either by downloading deb or via curl) no man-in-the-middle attacks should occur. Further reading: http://askubuntu.com/a/352972

As for the other packages I'll defer to #13089, I also don't think this meets the bar for the recovery build since it's pretty easily fixed and should be obvious what went wrong if it happens.

@Tyriar Tyriar added the verified Verification succeeded label Mar 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
Install apt repository as http, not https
e187c56 
Fixes microsoft#21654
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux verified Verification succeeded
Projects
None yet
Milestone
March 2017
Development

No branches or pull requests
2 participants
@Tyriar @intdel