Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: switch dark/light theme when system theme changes #59262

Closed
sergeysova opened this issue Sep 24, 2018 · 13 comments
Closed

macOS: switch dark/light theme when system theme changes #59262

sergeysova opened this issue Sep 24, 2018 · 13 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality mojave VS Code on OS X Mojave issues themes Color theme issues

Comments

@sergeysova
Copy link

What about add function to set light and dark themes and switch them on system theme changes?

Like in IINA

image

When system theme changes, then changes theme in app.

image

@vscodebot vscodebot bot added the themes Color theme issues label Sep 24, 2018
@sergeysova sergeysova changed the title Theme matched the system Theme in vscode should match the system theme Sep 24, 2018
@bpasero bpasero added feature-request Request for new features or functionality mojave VS Code on OS X Mojave issues labels Sep 25, 2018
@bpasero bpasero changed the title Theme in vscode should match the system theme macOS: theme in vscode should match the system theme Sep 25, 2018
@sergeysova
Copy link
Author

Reference: electron/electron#13387

@bpasero bpasero changed the title macOS: theme in vscode should match the system theme macOS: switch dark/light theme when system theme changes Oct 1, 2018
@LinusU
Copy link

LinusU commented Nov 21, 2018

For anyone that doesn't want to wait, I made a little extension that does this for you:

https://marketplace.visualstudio.com/items?itemName=LinusU.auto-dark-mode

You can set the dark and light mode in the settings:

screenshot 2018-11-21 at 12 59 28

Hope this helps someone!

@wajdi-b
Copy link

wajdi-b commented Nov 21, 2018

Someone can confirm but I think this was in the last release?

@LinusU
Copy link

LinusU commented Nov 21, 2018

@Lapsusone I think that the only thing that was in the last release was that the window borders and system dialogues will now follow the system dark theme settings. It still doesn't have a mechanism for automatically switching the editor theme...

@samplenull
Copy link

@LinusU, thanks for extension, it works!

@sergeysova
Copy link
Author

@LinusU So thank you!

@sergeysova
Copy link
Author

@bpasero what about add built in support of that feature?

@miguelsolorio
Copy link
Contributor

I would also like this, but I can see this getting complicated with themes that provide multiple light/dark themes. Here is what GitHub Desktop does this:

image

@jerguslejko
Copy link

I'd love to see this built-in. I've been using @LinusU's extension (https://marketplace.visualstudio.com/itemdetails?itemName=LinusU.auto-dark-mode) which works well most of the time but sometimes does not pick up the change.

Anyhow, I think it makes sense for this to be in the core.

@rapgru
Copy link

rapgru commented May 20, 2019

As I wasn't completely satisfied with @LinusU's extension, there's now another extension for this task:

ThemeSwitch on VS Code Marketplace

It is customizable and can therefore switch between more than 2 themes. You can choose any time of day and combine that time with the theme you prefer at that time.

@bpasero
Copy link
Member

bpasero commented Oct 10, 2019

/duplicate #61519

@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 10, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 10, 2019

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Oct 10, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality mojave VS Code on OS X Mojave issues themes Color theme issues
Projects
None yet
Development

No branches or pull requests

8 participants