Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS: Show native tabs in dark when dark mode enabled #59283

Closed
alesso-x opened this issue Sep 25, 2018 · 6 comments · Fixed by #59742
Closed

macOS: Show native tabs in dark when dark mode enabled #59283

alesso-x opened this issue Sep 25, 2018 · 6 comments · Fixed by #59742
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug mojave VS Code on OS X Mojave issues verified Verification succeeded workbench-electron Electron-VS Code issues
Milestone
October 2018

Comments

@alesso-x
Copy link

When dark mode is enabled on macOS the native tabs should be dark. i.e. maps app
screen shot 2018-09-24 at 10 51 06 pm

Instead of this
screen shot 2018-09-24 at 10 50 05 pm
@vscodebot
Copy link

vscodebot bot commented Sep 25, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron labels Sep 25, 2018
@bpasero
Copy link
Member

bpasero commented Sep 25, 2018

@alessandrodimarco please also report this to https://github.com/atom/electron

@bpasero bpasero self-assigned this Sep 25, 2018
@bpasero bpasero added the workbench-electron Electron-VS Code issues label Sep 25, 2018
@bpasero bpasero changed the title Dark mode for macOS native tabs macOS: Show native tabs in dark when dark mode enabled Sep 25, 2018
@alesso-x
Copy link
Author

@alessandrodimarco please also report this to https://github.com/atom/electron

There is a open PR for adding dark mode support electron/electron#14755

@bpasero bpasero mentioned this issue Sep 25, 2018
Closed
@bpasero
Copy link
Member

bpasero commented Sep 25, 2018

I am not sure that PR fixes all of the issues, I have asked the developer.

@MarshallOfSound
Copy link
Contributor

@bpasero You should be able to test this out on the latest v4.0.0 nightly 👍

@MarshallOfSound MarshallOfSound mentioned this issue Oct 1, 2018
Merged
@bpasero bpasero added the mojave VS Code on OS X Mojave issues label Oct 1, 2018
@bpasero
Copy link
Member

bpasero commented Oct 1, 2018

Via #59742

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Oct 1, 2018
@bpasero bpasero added this to the October 2018 milestone Oct 1, 2018
@alesso-x alesso-x mentioned this issue Oct 4, 2018
Closed
@mjbvz mjbvz added the verified Verification succeeded label Oct 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug mojave VS Code on OS X Mojave issues verified Verification succeeded workbench-electron Electron-VS Code issues
Projects
None yet
Milestone
October 2018
Development

Successfully merging a pull request may close this issue.

feat: enable mojave dark mode support MarshallOfSound/vscode
4 participants
@bpasero @MarshallOfSound @alesso-x @mjbvz