Mojave dark mode adds black border around app for light themes

[miguelsolorio]

Issue Type: Bug

Related to #54838

When dark mode is enabled, a black border is added around the app, which looks great in out dark theme:

But in our light theme this looks bad:

It would be great to disable this when on light themes.

VS Code version: Code - Insiders 1.29.0-insider (d7ac6e8, 2018-11-01T06:11:43.390Z)
OS version: Darwin x64 18.2.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz (8 x 3100)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Load (avg)	1, 2, 2
Memory (System)	16.00GB (1.74GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions (4)

Extension	Author (truncated)	Version
gitlens	eam	8.5.6
vscode-pull-request-github	Git	0.2.2
vscode-colorize	kam	0.7.2
material-icon-theme	PKi	3.6.0

(3 theme extensions excluded)

[octref]

When it's not in dark mode, it's the dark theme that looks bad:

[bpasero]

@MarshallOfSound any ideas?

[MarshallOfSound]

@bpasero My understanding of these issues so far is that this is "intended behavior" on Mojave. macOS adds these color highlights to the window to match the theme under the assumption that the apps theme matches the OS theme. (This assumption is based on the NSRequiresAquaSystemAppearance key)

If you're using a VS Code light theme with Mojave dark mode this is just going to happen unless Apple change there mind on enforcing this weird window border or someone finds a hidden window style for turning it off in native land.

[bpasero]

@MarshallOfSound yeah that is what I am thinking as well. Closing as designed by Apple.