Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorted/prioritized completions #74348

Closed
svipas opened this issue May 26, 2019 · 2 comments
Closed

Sorted/prioritized completions #74348

svipas opened this issue May 26, 2019 · 2 comments
Assignees
@mjbvz
Labels
*duplicate Issue identified as a duplicate of another issue(s) typescript Typescript support issues

Comments

@svipas
Copy link
Contributor

svipas commented May 26, 2019 •
edited

@mjbvz since microsoft/TypeScript#31484 is already merged it will be enabled by default with 3.5 TS, or something should be done additionally from VS Code side?

Also, how it will work with locality bonus setting or it will be deprecated?
@vscodebot vscodebot bot added the typescript Typescript support issues label May 26, 2019
@mjbvz mjbvz closed this as completed May 28, 2019
@mjbvz
Copy link
Contributor

mjbvz commented May 28, 2019

We designed it so no work is required on the vs code side

@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label May 28, 2019
@svipas
Copy link
Contributor Author

svipas commented May 29, 2019 •
edited

@mjbvz Amazing, so it will be enabled by default with TS 3.5? Also, what about locality bonus setting, it's still relevant?

EDIT: I tested it with TS 3.5, omg it's amazing! It even works better without locality bonus setting.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
*duplicate Issue identified as a duplicate of another issue(s) typescript Typescript support issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svipas @mjbvz